JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cygwin: FIFO: remove incorrect duplexer code

Browse Source 
raw_read had some code that was based on an incorrect implementation
of duplexers.
This commit is contained in:
Ken Brown 2019-05-09 10:47:47 -04:00
parent 674b4fe995
commit 1372021a2d
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
winsup/cygwin/fhandler_fifo.cc
View File

@ -780,21 +780,14 @@ fhandler_fifo::raw_read (void *in_ptr, size_t& len)
fifo_client_unlock (); fifo_client_unlock ();
return; return;
} }
/* If the pipe is empty, we usually get nread == -1 with /* If the pipe is empty, we get nread == -1 with
ERROR_NO_DATA or ERROR_PIPE_LISTENING. An exception is ERROR_NO_DATA. */
that in the duplex case we may get nread == 0 when we else if (nread < 0 && GetLastError () != ERROR_NO_DATA)
attempt to read from the duplex pipe (fc_handler[0]). */
else if (nread < 0)
switch (GetLastError ())
{ {
case ERROR_NO_DATA:
case ERROR_PIPE_LISTENING:
break;
default:
fifo_client_unlock (); fifo_client_unlock ();
goto errout; goto errout;
} }
else if (nread == 0 && (!duplexer || i > 0)) else if (nread == 0)
/* Client has disconnected. */ /* Client has disconnected. */
{ {
fc_handler[i].state = fc_invalid; fc_handler[i].state = fc_invalid;