JehanneOS
/
newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* fhandler_disk_file.cc (fhandler_base::fstat_helper): Alwasy set 

st_size of directories to 0.  Explain why.
This commit is contained in:
Corinna Vinschen 2011-01-13 13:50:02 +00:00
parent cf8d5ec5ae
commit 07c43238cf
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,8 @@
2011-01-13 Corinna Vinschen <corinna@vinschen.de>
* fhandler_disk_file.cc (fhandler_base::fstat_helper): Alwasy set
st_size of directories to 0. Explain why.
2011-01-12 Corinna Vinschen <corinna@vinschen.de> 2011-01-12 Corinna Vinschen <corinna@vinschen.de>
* posix.sgml: Add madvise to BSD list. * posix.sgml: Add madvise to BSD list.

9
winsup/cygwin/fhandler_disk_file.cc
View File

@ -497,7 +497,14 @@ fhandler_base::fstat_helper (struct __stat64 *buf,
&buf->st_ctim); &buf->st_ctim);
to_timestruc_t ((PFILETIME) &pfnoi->CreationTime, &buf->st_birthtim); to_timestruc_t ((PFILETIME) &pfnoi->CreationTime, &buf->st_birthtim);
buf->st_rdev = buf->st_dev = get_dev (); buf->st_rdev = buf->st_dev = get_dev ();
buf->st_size = (_off64_t) pfnoi->EndOfFile.QuadPart; /* CV 2011-01-13: Observations on the Cygwin mailing list point to an
interesting behaviour in some Windows versions. Apparently the size of
a directory is computed at the time the directory is first scanned. This
can result in two subsequent NtQueryInformationFile calls to return size
0 in the first call and size > 0 in the second call. This in turn can
affect applications like newer tar.
FIXME: Is the allocation size affected as well? */
buf->st_size = pc.isdir () ? 0 : (_off64_t) pfnoi->EndOfFile.QuadPart;
/* The number of links to a directory includes the number of subdirectories /* The number of links to a directory includes the number of subdirectories
in the directory, since all those subdirectories point to it. However, in the directory, since all those subdirectories point to it. However,
this is painfully slow, so we do without it. */ this is painfully slow, so we do without it. */