JehanneOS/netcat
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix a few harmless compiler warnings

Browse Source
This commit is contained in:
Mike Frysinger
2018-01-11 03:50:29 -05:00
parent fce106d40c
commit 98c8f686aa
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
netcat.c
View File

@@ -730,7 +730,7 @@ int doexec_use_sh = 0; /* `-c' or `-e' option? */
that would be security-critical, which is why it's ifdefed out by default. that would be security-critical, which is why it's ifdefed out by default.
Use at your own hairy risk; if you leave shells lying around behind open Use at your own hairy risk; if you leave shells lying around behind open
listening ports you deserve to lose!! */ listening ports you deserve to lose!! */
doexec_new (fd) void doexec_new (fd)
int fd; int fd;
{ {
dup2 (fd, 0); /* the precise order of fiddlage */ dup2 (fd, 0); /* the precise order of fiddlage */
@@ -750,7 +750,7 @@ Debug (("gonna exec \"%s\" using /bin/sh...", pr00gie))
that would be security-critical, which is why it's ifdefed out by default. that would be security-critical, which is why it's ifdefed out by default.
Use at your own hairy risk; if you leave shells lying around behind open Use at your own hairy risk; if you leave shells lying around behind open
listening ports you deserve to lose!! */ listening ports you deserve to lose!! */
doexec (fd) void doexec (fd)
int fd; int fd;
{ {
register char * p; register char * p;
@@ -1528,7 +1528,7 @@ void oprint (which, buf, n)
} /* if bc < x */ } /* if bc < x */
bc -= x; /* fix wrt current line size */ bc -= x; /* fix wrt current line size */
sprintf (&stage[2], "%8.8x ", obc); /* xxx: still slow? */ sprintf ((char*)&stage[2], "%8.8x ", obc); /* xxx: still slow? */
obc += x; /* fix current offset */ obc += x; /* fix current offset */
op = &stage[11]; /* where hex starts */ op = &stage[11]; /* where hex starts */
a = &stage[61]; /* where ascii starts */ a = &stage[61]; /* where ascii starts */
@@ -1590,7 +1590,7 @@ void atelnet (buf, size)
obuf[1] = y; obuf[1] = y;
p++; x--; p++; x--;
obuf[2] = *p; /* copy actual option byte */ obuf[2] = *p; /* copy actual option byte */
(void) write (netfd, obuf, 3); if (write (netfd, obuf, 3)) {}
/* if one wanted to bump wrote_net or do a hexdump line, here's the place */ /* if one wanted to bump wrote_net or do a hexdump line, here's the place */
y = 0; y = 0;
} /* if y */ } /* if y */
@@ -2100,7 +2100,7 @@ Debug (("fd_set size %d", sizeof (*ding1))) /* how big *is* it? */
} }
#endif /* G_S_H */ #endif /* G_S_H */
if (o_wfile) { if (o_wfile) {
ofd = open (stage, O_WRONLY | O_CREAT | O_TRUNC, 0664); ofd = open ((char*)stage, O_WRONLY | O_CREAT | O_TRUNC, 0664);
if (ofd <= 0) /* must be > extant 0/1/2 */ if (ofd <= 0) /* must be > extant 0/1/2 */
bail ("can't open %s", stage); bail ("can't open %s", stage);
stage = (unsigned char *) Hmalloc (100); stage = (unsigned char *) Hmalloc (100);
@@ -2153,11 +2153,12 @@ Debug (("after go: x now %c, optarg %x optind %d", x, optarg, optind))
/* dolisten does its own connect reporting, so we don't holler anything here */ /* dolisten does its own connect reporting, so we don't holler anything here */
if (netfd > 0) { if (netfd > 0) {
#ifdef GAPING_SECURITY_HOLE #ifdef GAPING_SECURITY_HOLE
if (pr00gie) /* -c or -e given? */ if (pr00gie) { /* -c or -e given? */
if (doexec_use_sh) /* -c */ if (doexec_use_sh) /* -c */
doexec_new (netfd); doexec_new (netfd);
else /* -e */ else /* -e */
doexec (netfd); doexec (netfd);
}
#endif /* GAPING_SECURITY_HOLE */ #endif /* GAPING_SECURITY_HOLE */
x = readwrite (netfd); /* it even works with UDP! */ x = readwrite (netfd); /* it even works with UDP! */
if (o_verbose > 1) /* normally we don't care */ if (o_verbose > 1) /* normally we don't care */