Gitea
/
git-touch-android-ios-app
mirror of https://github.com/git-touch/git-touch
1
0
Fork 0
Code Issues Releases Wiki Activity

refactor: common padding

This commit is contained in:
Rongjian Zhang 2019-10-02 15:39:47 +08:00
parent ae5660061c
commit a9d5cfef55
14 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/scaffolds/long_list.dart
View File

@ -115,7 +115,7 @@ class _LongListScaffoldState<T, K> extends State<LongListScaffold<T, K>> {
payload.leadingItems.length +
payload.trailingItems.length;
return Container(
padding: EdgeInsets.all(16),
padding: commonItemPadding,
decoration: BoxDecoration(
image: DecorationImage(
image: ExactAssetImage('images/progressive-disclosure-line.png',
@ -127,7 +127,7 @@ class _LongListScaffoldState<T, K> extends State<LongListScaffold<T, K>> {
child: Link(
onTap: _loadMore,
child: Container(
padding: EdgeInsets.all(10),
padding: commonItemPadding,
decoration: BoxDecoration(
border: Border.all(color: Colors.black12),
),

3
lib/screens/code_theme.dart
View File

@ -5,6 +5,7 @@ import 'package:flutter_highlight/theme_map.dart';
import 'package:git_touch/models/code.dart';
import 'package:git_touch/models/theme.dart';
import 'package:git_touch/scaffolds/single.dart';
import 'package:git_touch/utils/utils.dart';
import 'package:git_touch/widgets/app_bar_title.dart';
import 'package:git_touch/widgets/table_view.dart';
import 'package:provider/provider.dart';
@ -95,7 +96,7 @@ class CodeThemeScreen extends StatelessWidget {
fontSize: codeProvider.fontSize.toDouble(),
fontFamily: codeProvider.fontFamilyUsed,
),
padding: const EdgeInsets.all(10),
padding: commonItemPadding,
),
)
],

2
lib/screens/commits.dart
View File

@ -90,7 +90,7 @@ class CommitsScreen extends StatelessWidget {
return Link(
url: payload['url'],
child: Container(
padding: EdgeInsets.all(12),
padding: commonItemPadding,
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[

2
lib/screens/issue.dart
View File

@ -355,7 +355,7 @@ mutation {
crossAxisAlignment: CrossAxisAlignment.stretch,
children: <Widget>[
Container(
padding: EdgeInsets.all(10),
padding: commonItemPadding,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[

3
lib/screens/login.dart
View File

@ -1,6 +1,7 @@
import 'package:flutter/material.dart';
import 'package:git_touch/models/auth.dart';
import 'package:git_touch/scaffolds/single.dart';
import 'package:git_touch/utils/utils.dart';
import 'package:git_touch/widgets/app_bar_title.dart';
import 'package:provider/provider.dart';
import '../widgets/link.dart';
@ -24,7 +25,7 @@ class _LoginScreenState extends State<LoginScreen> {
settings.setActiveAccountIndex(index);
},
child: Container(
padding: EdgeInsets.all(10),
padding: commonItemPadding,
decoration: BoxDecoration(
border: Border(bottom: BorderSide(color: Colors.black12)),
),

4
lib/screens/object.dart
View File

@ -116,7 +116,7 @@ class ObjectScreen extends StatelessWidget {
case 'md':
case 'markdown':
return Padding(
padding: const EdgeInsets.all(12),
padding: commonItemPadding,
child: MarkdownView(payload['text']),
);
case 'png':
@ -133,7 +133,7 @@ class ObjectScreen extends StatelessWidget {
payload['text'],
language: _language,
theme: themeMap[codeProvider.theme],
padding: EdgeInsets.all(10),
padding: commonItemPadding,
textStyle: TextStyle(
fontSize: codeProvider.fontSize.toDouble(),
fontFamily: codeProvider.fontFamilyUsed),

9
lib/screens/repository.dart
View File

@ -26,8 +26,6 @@ class RepositoryScreen extends StatelessWidget {
final String name;
final String branch;
static const _languageBarPadding = 10.0;
RepositoryScreen(this.owner, this.name, {this.branch});
RepositoryScreen.fromFullName(String fullName, {this.branch})
: owner = fullName.split('/')[0],
@ -213,7 +211,8 @@ class RepositoryScreen extends StatelessWidget {
var readme = payload.data[1] as String;
final langWidth = MediaQuery.of(context).size.width -
_languageBarPadding * 2 -
commonItemPadding.left -
commonItemPadding.right -
(data['languages']['edges'] as List).length +
1;
@ -246,7 +245,7 @@ class RepositoryScreen extends StatelessWidget {
if ((data['languages']['edges'] as List).isNotEmpty)
Container(
color: Colors.white,
padding: const EdgeInsets.all(_languageBarPadding),
padding: commonItemPadding.copyWith(top: 8, bottom: 8),
child: ClipRRect(
borderRadius: BorderRadius.circular(2),
child: SizedBox(
@ -370,7 +369,7 @@ class RepositoryScreen extends StatelessWidget {
verticalGap,
if (readme != null)
Container(
padding: EdgeInsets.all(12),
padding: commonItemPadding,
color: Colors.white,
child: MarkdownView(readme),
),

2
lib/screens/user.dart
View File

@ -127,7 +127,7 @@ class UserScreen extends StatelessWidget {
return Container(
color: Colors.white,
padding: EdgeInsets.all(10),
padding: commonItemPadding,
child: SingleChildScrollView(
scrollDirection: Axis.horizontal,
reverse: true,

4
lib/utils/utils.dart
View File

@ -125,7 +125,7 @@ bool isNotNullOrEmpty(String text) {
}
const borderView = BorderView();
const verticalGap = SizedBox(height: 20);
const verticalGap = SizedBox(height: 18);
String getBranchQueryKey(String branch, {bool withParams = false}) {
if (branch == null) return 'defaultBranchRef';
@ -171,3 +171,5 @@ launchUrl(String url) async {
// TODO: fallback
}
}
const commonItemPadding = EdgeInsets.all(12);

2
lib/widgets/event_item.dart
View File

@ -72,7 +72,7 @@ class EventItem extends StatelessWidget {
screenBuilder: screenBuilder,
url: url,
child: Container(
padding: EdgeInsets.all(12),
padding: commonItemPadding,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[

2
lib/widgets/issue_item.dart
View File

@ -49,7 +49,7 @@ class IssueItem extends StatelessWidget {
);
},
child: Container(
padding: EdgeInsets.all(12),
padding: commonItemPadding,
// color: payload.unread ? Colors.white : Colors.black12,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,

2
lib/widgets/repository_item.dart
View File

@ -126,7 +126,7 @@ class RepositoryItem extends StatelessWidget {
? null
: (_) => RepositoryScreen(payload['owner']['login'], payload['name']),
child: Container(
padding: EdgeInsets.all(10),
padding: commonItemPadding,
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[

2
lib/widgets/timeline_item.dart
View File

@ -302,7 +302,7 @@ class TimelineItem extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Container(
padding: EdgeInsets.all(12),
padding: commonItemPadding,
child: _buildByType(context),
);
}

3
lib/widgets/user_item.dart
View File

@ -1,6 +1,7 @@
import 'package:flutter/material.dart';
import 'package:git_touch/screens/organization.dart';
import 'package:git_touch/screens/user.dart';
import 'package:git_touch/utils/utils.dart';
import 'package:git_touch/widgets/avatar.dart';
import 'package:git_touch/widgets/link.dart';
import 'package:git_touch/widgets/text_contains_organization.dart';
@ -46,7 +47,7 @@ class UserItem extends StatelessWidget {
: (_) =>
isOrganization ? OrganizationScreen(login) : UserScreen(login),
child: Container(
padding: EdgeInsets.all(10),
padding: commonItemPadding,
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[