From 68e031ebe5b8950b42321c015ed6145c6956e91f Mon Sep 17 00:00:00 2001 From: Rongjian Zhang Date: Sat, 4 Jan 2020 22:47:48 +0800 Subject: [PATCH] improvement: action tap effect --- lib/widgets/action_button.dart | 6 ++++-- lib/widgets/action_entry.dart | 7 +++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/widgets/action_button.dart b/lib/widgets/action_button.dart index 8f17ea7..d227a7c 100644 --- a/lib/widgets/action_button.dart +++ b/lib/widgets/action_button.dart @@ -48,9 +48,11 @@ class ActionButton extends StatelessWidget { final theme = Provider.of(context); switch (theme.theme) { case AppThemeType.cupertino: - return GestureDetector( + return CupertinoButton( + minSize: 0, child: Icon(iconData, size: 22), - onTap: () async { + padding: EdgeInsets.zero, + onPressed: () async { var value = await showCupertinoModalPopup( context: context, builder: (BuildContext context) { diff --git a/lib/widgets/action_entry.dart b/lib/widgets/action_entry.dart index fb51e46..1ded9c4 100644 --- a/lib/widgets/action_entry.dart +++ b/lib/widgets/action_entry.dart @@ -1,3 +1,4 @@ +import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:git_touch/models/theme.dart'; import 'package:provider/provider.dart'; @@ -11,9 +12,11 @@ class ActionEntry extends StatelessWidget { Widget build(BuildContext context) { switch (Provider.of(context).theme) { case AppThemeType.cupertino: - return GestureDetector( + return CupertinoButton( + minSize: 0, child: Icon(iconData, size: 22), - onTap: onTap, + padding: EdgeInsets.zero, + onPressed: onTap, ); default: return IconButton(