refactor: merge pull and issue screens

This commit is contained in:
Rongjian Zhang 2019-12-14 22:36:02 +08:00
parent 6b08ceae9e
commit 5ca9f98978
5 changed files with 12 additions and 43 deletions

View File

@ -12,8 +12,6 @@ import 'package:git_touch/screens/issue_form.dart';
import 'package:git_touch/screens/issues.dart';
import 'package:git_touch/screens/notification.dart';
import 'package:git_touch/screens/object.dart';
import 'package:git_touch/screens/pull.dart';
import 'package:git_touch/screens/pulls.dart';
import 'package:git_touch/screens/repository.dart';
import 'package:git_touch/screens/settings.dart';
import 'package:git_touch/screens/stargazers.dart';

View File

@ -14,6 +14,12 @@ final issueRouter = RouterScreen(
(context, params) => IssueScreen(params['owner'].first,
params['name'].first, int.parse(params['number'].first)));
final pullRouter = RouterScreen(
'/:owner/:name/pulls/:number',
(context, params) => IssueScreen(params['owner'].first,
params['name'].first, int.parse(params['number'].first),
isPullRequest: true));
final reactionChunk = emojiMap.entries.map((entry) {
var key = entry.key;
return '''

View File

@ -13,6 +13,12 @@ final issuesRouter = RouterScreen(
(context, params) =>
IssuesScreen(params['owner'].first, params['name'].first));
final pullsRouter = RouterScreen(
'/:owner/:name/pulls',
(context, params) => IssuesScreen(
params['owner'].first, params['name'].first,
isPullRequest: true));
class IssuesScreen extends StatelessWidget {
final String owner;
final String name;

View File

@ -1,21 +0,0 @@
import 'package:flutter/material.dart';
import 'package:git_touch/screens/issue.dart';
import 'package:git_touch/utils/utils.dart';
final pullRouter = RouterScreen(
'/:owner/:name/pulls/:number',
(context, params) => PullScreen(params['owner'].first, params['name'].first,
int.parse(params['number'].first)));
class PullScreen extends StatelessWidget {
final String owner;
final String name;
final int number;
PullScreen(this.owner, this.name, this.number);
@override
Widget build(BuildContext context) {
return IssueScreen(owner, name, number, isPullRequest: true);
}
}

View File

@ -1,20 +0,0 @@
import 'package:flutter/material.dart';
import 'package:git_touch/screens/issues.dart';
import 'package:git_touch/utils/utils.dart';
final pullsRouter = RouterScreen(
'/:owner/:name/pulls',
(context, params) =>
PullsScreen(params['owner'].first, params['name'].first));
class PullsScreen extends StatelessWidget {
final String owner;
final String name;
PullsScreen(this.owner, this.name);
@override
Widget build(BuildContext context) {
return IssuesScreen(owner, name, isPullRequest: true);
}
}