diff --git a/Code-Standards.md b/Code-Standards.md index e79f3ce..209f7c4 100644 --- a/Code-Standards.md +++ b/Code-Standards.md @@ -151,10 +151,6 @@ Every layout must have components with defined ID's. Example, android:textColorLink="@color/lightBlue" /> ``` -#### ICONs are taken from Feathericons -If an symbole is needed and not included in GitNex jet. Search for on in the [Feather Icon Colection](https://feathericons.com/). -copy the svg data into an xml file at `app/src/main/res/drawable/`. - #### String names All the string names in `strings.xml` must be meaningful. Also check for the string if it is already defined. @@ -163,8 +159,11 @@ All the string names in `strings.xml` must be meaningful. Also check for the str Pull Request is not available for merge ``` -#### Drawables/Icons -GitNex use all the default icons provided with Android Studio licensed under Apache. All drawables are SVG. In case there is no matching resource found in the drawable library, a third party resource can be used under an allowed license for that resource. Resource must be SVG. **No gif/png etc are allowed**. +#### Drawables/Icons +Most of the icons used in GitNex are taken from open source project [Feather Icons](https://feathericons.com/). Please download an appropriate icon from feather site and use the AS tool to upload it to drawable directory. +e.g: Right click on drawable directory in the project and choose New -> Vector Asset and select local file. +1) **No gif/png etc are allowed**. +2) **All drawables must be SVG**. #### Standard Variable Names App Context should be stored at the beggining once in `appCtx`.