Run `gradle :app:spotlessApply` to apply formatting.
# Changes from current code format
This does not match with the old intellij based code format because I can't apply some rules there.
- newlines after `else`, `catch` etc. (means there are `} else {` statements)
- no spaces around `if` braces (there are statements like `if (true) {` instead of `if(true) {`
Closes https://codeberg.org/gitnex/GitNex/issues/1187
Closes https://codeberg.org/gitnex/GitNex/issues/1202
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1208
Reviewed-by: 6543 <6543@obermui.de>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Actually it is working, just need to restart the app.
So closing #1119 and also porting the Alert dialogs for accepting the certificates and remove account to M3.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1184
There are not any functinality changes except more of UI changes which comes with M3. There are still few things left but that are not there yet from Google side.
I will be merging this PR as it does not break any function but attaching a few screenshots if you would like to know how it looks like. Feel free to build from `main` to test it out.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1181
Extend CI workflows (-> https://codeberg.org/gitnex/GitNex/issues/1099)
1. pull translations and push them again on every pull
@mmarif this needs the secrets and `BOT_TOKEN`
the code for this comes from tea4j-autodeploy
2. add a **template** for a check workflow which only does some static checks right now. It is disabled because it requires some investigation and discussion on how we should deal with these issues. The checks are currently (if we would enable it):
1. check code style and formatting according to the project file in `.idea/`
2. make sure every Java file has an `@author` annotation
I would wait until you reviewed with enabling them because we have to reformat all the files which results in changes with a few thousand changed lines (tried this once).
Closes https://codeberg.org/gitnex/GitNex/issues/141
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1155
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
This PR mostly intend to improve and re visualize the UI across the app including clean up of layouts and strings.
Some UI changes are experimental like bottom sheet grid layout for repo items and can be extended once mature enough for use.
Few screen shots attached.
Closes#1077Closes#976
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1074
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after c9172f85ef, Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes#354
* replaces #897
* fixes#947
* closes#1001
* closes#1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Adds support for Custom Tabs (at laest supported by Chrome and Firefox).
This is also useful if you set the app as default app for links from the supported Gitea instances.
If you then try to use the "Open in browser" buttons, this will just open the link in GitNex itself.
With Custom Tabs, the links are opened as Custom Tabs (only if the default browser supports them).
I also deleted the unused `OpenRepoInBrowserActivity` and added the mechanism to open an URL in the browser to the `AppUtil`.
I also improved the setting switches:
* hide settings if required settings are disabled (only notification settings)
* allow click on full layouts
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1019
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
### Describe what your pull request does and which issue you’re targeting
<!-- Create a new issue, if it doesn't exist yet -->
Closes#860
<br><br>
<!-- Make sure you are targeting the "main" branch, pull requests on release branches are only allowed for bug fixes. -->
- [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md).
- [X] I'm following the code standards as defined [here](https://codeberg.org/gitnex/GitNex/wiki/Code-Standards).
- [X] By submitting this pull request, I permit GitNex to license my work under the [GNU General Public License v3](https://codeberg.org/GitNex/GitNex/src/branch/main/LICENSE).
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/929
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Minor improvements.
Merge branch 'master' into biometric-support
# Conflicts:
# app/src/main/res/values/strings.xml
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
UI transition improvements
check for older version(android 6+), support for android 10 and below
Fix material lib builds with new version
Merge branch 'biometric-support' of codeberg.org:gitnex/GitNex into biometric-support
Merge branch 'master' into biometric-support
# Conflicts:
# app/src/main/java/org/mian/gitnex/activities/BaseActivity.java
# app/src/main/res/values/strings.xml
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
set status to false
Merge branch 'master' into biometric-support
check for bimetric status on device
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into biometric-support
close app if back button or cancel is clicked
Enable/disable and show biometric auth dialog
Layout
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/820
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Co-Authored-By: M M Arif <mmarif@noreply.codeberg.org>
Co-Committed-By: M M Arif <mmarif@noreply.codeberg.org>
Fixing layout issues and crashes.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/810
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Remove jetbrain import
Merge branch 'master' into deprecations
View bindings #3
View bindings #2
View bindings #1
Rewriting deprecated code.
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/809
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Merge branch 'performance-highlight-refactor' of https://codeberg.org/opyale/GitNex into performance-highlight-refactor
Fixing theme recognition.
Merge branch 'master' into performance-highlight-refactor
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Add new field issueType to db
Improving theme recognition.
Fixing alignment of menu button.
Fixing cut off text.
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Fixing crash.
Refactoring activities.
Improving drafts.
Calculating density for avatars.
Improving drafts.
Calculating density for avatars.
Increasing size of avatar.
Decreasing size of avatar.
Restoring DeepLinksActivity
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into performance-highlight-refactor
Conflicts:
app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
Initial commit.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/755
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Merge branch 'master' into enhance-settings-screen
# Conflicts:
# app/src/main/java/org/mian/gitnex/activities/FileViewActivity.java
Cleanup and refactor of activities
Fix bottomsheet
enhance code blocks and refactors
Move home screen to general, make it ready for translation
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/735
change to server error on onFailure
Fix keyboard move issue
Fix statusbar color, remove social, enhance other things
Merge branch 'master' into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Conflicts:
app/src/main/java/org/mian/gitnex/activities/IssueDetailActivity.java
Making it work.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
First major changes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Cleanup.
Simplifying title.
Adding BottomSheetFragment layout for future changes.
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: opyale <example@example.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/555
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Enhance and update the buttons across the app, colorful animation on tap
update toasty in view models
update toasty in fragments
update toasty in actions, activities, adapters
Alert dialogs buttons arrangements
strings fixes
switch to fab buttons
remove snackbar
Enhance whole app UI, bring consistency among the elements
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/630
Cleanup
Extending and improving notifications
Using new icons instead
Lowering polling delay to one minute and other improvements
Fixing minor issues
Simplifying progress layout
Fixing bugs and other improvements
Adding translations
Notifications
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/554
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Moving TinyDB and AppUtil to helpers.
Co-authored-by: opyale <opyale@noreply.gitea.io>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/579
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
decrease the compression to have better results
Move cache size outside of maxsize method. fix progress bar alignment for files
Add cache size to picasso
Use getAbsolutePath
Merge branch 'app-cache' of gitea.com:gitnex/GitNex into app-cache
Few imprvoements
Merge branch 'master' into app-cache
small improvement
Implement configure cache size and clear it
Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/482
Reviewed-by: opyale <opyale@noreply.gitea.io>
Merge branch 'master' into fix-refactor-context
reorder + space
fix
R E F A C T O R
set ctx and appCtx in LoginActivity
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/469
Reviewed-by: M M Arif <mmarif@swatian.com>
Reviewed-by: opyale <opyale@noreply.gitea.io>
M M Arif
M M Arif
qwerty287
opyale
6543