Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after c9172f85ef, Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes#354
* replaces #897
* fixes#947
* closes#1001
* closes#1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Closes#930
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/940
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-committed-by: M M Arif <mmarif@noreply.codeberg.org>
### Describe what your pull request does and which issue you’re targeting
Closes#928
This allows to select the time to switch between themes. The mentioned color/contrast problem with the time selection isn't fixed. I also simplified the settings code (0fe854fd49). And with [this](a590f5bc4c) GitNex hides the two options to change the time if your theme isn't `Auto (Light/Dark)` or `Auto (Retro/Dark)`. I could apply this also to the notifications settings, that means that the advanced settings for notifications (polling delay, light...) are hidden if the notifications aren't enabled.
this is ready to review/merge
<br><br>
<!-- Make sure you are targeting the "main" branch, pull requests on release branches are only allowed for bug fixes. -->
- [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md).
- [X] I'm following the code standards as defined [here](https://codeberg.org/gitnex/GitNex/wiki/Code-Standards).
- [X] By submitting this pull request, I permit GitNex to license my work under the [GNU General Public License v3](https://codeberg.org/GitNex/GitNex/src/branch/main/LICENSE).
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/932
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into notifications-performance-improvements
Conflicts:
app/src/main/java/org/mian/gitnex/adapters/DraftsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/NotificationsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/UserAccountsNavAdapter.java
app/src/main/res/layout/bottom_sheet_repository_in_list.xml
app/src/main/res/layout/list_files.xml
Merge branch 'master' into notifications-performance-improvements
Merge branch 'master' into notifications-performance-improvements
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into notifications-performance-improvements
Conflicts:
app/src/main/res/values-it/strings.xml
Add ripple effect to buttons.
Run syntax highlighting on separate thread. (#859)
Initial commit.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/875
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Move acra to application
[Frontport] Fix Acra and workmanager errors, update gradle
Fix ACRA and workmanager errors
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/856
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Co-Authored-By: M M Arif <mmarif@noreply.codeberg.org>
Co-Committed-By: M M Arif <mmarif@noreply.codeberg.org>
Removing file size selection dialog in favor of hardcoded value.
Adding warning to file size picker and minor improvements.
Bump dependencies and gradle
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improving credits, adding symlink and submodule icons to FilesAdapter and removing unused libraries.
Minor improvements and bug fixes.
Add true progress indication routine for copying streams.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Performance and memory usage improvements
Notification improvements
Renaming StaticGlobalVariables to Constants
Overall improvements and fixes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Add additional image formats.
Adding audio and video categories.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improve file type handling.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/841
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Minor improvements.
Merge branch 'master' into biometric-support
# Conflicts:
# app/src/main/res/values/strings.xml
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
UI transition improvements
check for older version(android 6+), support for android 10 and below
Fix material lib builds with new version
Merge branch 'biometric-support' of codeberg.org:gitnex/GitNex into biometric-support
Merge branch 'master' into biometric-support
# Conflicts:
# app/src/main/java/org/mian/gitnex/activities/BaseActivity.java
# app/src/main/res/values/strings.xml
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
Merge branch 'master' into biometric-support
set status to false
Merge branch 'master' into biometric-support
check for bimetric status on device
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into biometric-support
close app if back button or cancel is clicked
Enable/disable and show biometric auth dialog
Layout
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/820
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Co-Authored-By: M M Arif <mmarif@noreply.codeberg.org>
Co-Committed-By: M M Arif <mmarif@noreply.codeberg.org>
remove unknown case for editing
Improve var names and code formatting
Minor improvements.
Restoring ACRA functionality.
Fixing and improving scaling of images, improving performance by doing work that has to be done once only once and using different terminology.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/831
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>