Potentially closes#1226closes#1234
- Fix UI issues
- Use FAB where needed instead of bottom sheet entries
- Other fixes
Update: added screen shots
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1259
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Closes#1222
Need `Android 12L API 32` if want to test on emulator.
Change to Dynamic colors in Settings -> Appearance -> Themes.
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1257
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Addresses https://codeberg.org/gitnex/GitNex/issues/435 but only supports commits and not PRs.
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1212
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Run `gradle :app:spotlessApply` to apply formatting.
# Changes from current code format
This does not match with the old intellij based code format because I can't apply some rules there.
- newlines after `else`, `catch` etc. (means there are `} else {` statements)
- no spaces around `if` braces (there are statements like `if (true) {` instead of `if(true) {`
Closes https://codeberg.org/gitnex/GitNex/issues/1187
Closes https://codeberg.org/gitnex/GitNex/issues/1202
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1208
Reviewed-by: 6543 <6543@obermui.de>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Closes#953
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1201
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Closes https://codeberg.org/gitnex/GitNex/issues/1200
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1203
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
This is an app only feature and could be useful to some users including me.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1178
Side note: I don't know why but Gitea notifications listing is very random even on the web UI. Olds are in the 1st page and new ones on the last page.
Closes#1164Closes#1160
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1170
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
1. bad layout on translation settings
2. fix ACRA notifications (happened during the cleanup of the deprecated code)
3. final newline in file viewer
4. top newline in diffs
5. missing newline if diff has multiple parts
Closes https://codeberg.org/gitnex/GitNex/issues/1093
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1118
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Various refactoring to simplify code. See separate commit for the refactorings.
~~Note to the font refactoring: it didn't work for me. The font was always `Manrope`. I don't know why - the issue is the FontsOverride.setDefaultFont` method, however, how this works hasn't changed. Maybe it was an issue with my device, could you please test it?~~
Also closes#1110 and closes#1073
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1115
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Move to https://codeberg.org/GitNex/tea4j-autodeploy as Retrofit interfaces. Closes#907closes#1084
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1088
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Add some tests to test Android-only features: `MainActivityTest` (just start the activity), `AppUtilTest` (some Android-related methods), `ToastyTest` (only to test if toasts are working). Actually, this doesn't really test something, but just as a first step.
https://codeberg.org/gitnex/GitNex/issues/1098
I think it's REALLY hard to write tests that really work well in testing features. Starting activities is possible, but it's hard to test it. Also, this will run with the same database and tinydb the real app uses - it's hard for us to make this usable, we have to replace the DB and TinyDB and then add values again.
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1105
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after c9172f85ef, Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes#354
* replaces #897
* fixes#947
* closes#1001
* closes#1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Cherry-pick enhancements and features from #897. I didn't pick database-related stuff because I don't think it's a good idea to do this (see discord conversation).
Closes#598Closes#887Closes#888Closes#901Closes#1024Closes#1035
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1032
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Improves #1018
Sorry for the many commits, I reused my branch that was already used in #1018 and just merged main in it.
* Open repo details directly instead of using deep links (we should avoid using the activity directly)
* improve some code
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1026
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Allows clicks on submodules and symlinks in the file browser.
Symlinks opens the file viewer which will view the link target (same behavior as Gitea)
Submodules will redirect to the repository from where they are
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1018
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Adds support for Custom Tabs (at laest supported by Chrome and Firefox).
This is also useful if you set the app as default app for links from the supported Gitea instances.
If you then try to use the "Open in browser" buttons, this will just open the link in GitNex itself.
With Custom Tabs, the links are opened as Custom Tabs (only if the default browser supports them).
I also deleted the unused `OpenRepoInBrowserActivity` and added the mechanism to open an URL in the browser to the `AppUtil`.
I also improved the setting switches:
* hide settings if required settings are disabled (only notification settings)
* allow click on full layouts
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1019
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into notifications-performance-improvements
Conflicts:
app/src/main/java/org/mian/gitnex/adapters/DraftsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/NotificationsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java
app/src/main/java/org/mian/gitnex/adapters/UserAccountsNavAdapter.java
app/src/main/res/layout/bottom_sheet_repository_in_list.xml
app/src/main/res/layout/list_files.xml
Merge branch 'master' into notifications-performance-improvements
Merge branch 'master' into notifications-performance-improvements
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into notifications-performance-improvements
Conflicts:
app/src/main/res/values-it/strings.xml
Add ripple effect to buttons.
Run syntax highlighting on separate thread. (#859)
Initial commit.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/875
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Fixing crash and minor improvements.
Add ".properties" and ".ini" formats.
Increase surface area of files list item.
Fixing issue where some source code is not visible.
Replacing highlightJS with custom view due to performance issues and high file sizes.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/837
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Removing file size selection dialog in favor of hardcoded value.
Adding warning to file size picker and minor improvements.
Bump dependencies and gradle
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improving credits, adding symlink and submodule icons to FilesAdapter and removing unused libraries.
Minor improvements and bug fixes.
Add true progress indication routine for copying streams.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Performance and memory usage improvements
Notification improvements
Renaming StaticGlobalVariables to Constants
Overall improvements and fixes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Add additional image formats.
Adding audio and video categories.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improve file type handling.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/841
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Merge branch 'master' into threadsafe-singletons
Make singletons threadsafe.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/838
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
remove unknown case for editing
Improve var names and code formatting
Minor improvements.
Restoring ACRA functionality.
Fixing and improving scaling of images, improving performance by doing work that has to be done once only once and using different terminology.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/831
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Allow multi line text in desc inputs
Minor improvements.
Improving the selection of branches.
Default to first branch in spinner.
Minor improvements.
fix crash on creating new file
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/819
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Co-Authored-By: M M Arif <mmarif@noreply.codeberg.org>
Co-Committed-By: M M Arif <mmarif@noreply.codeberg.org>
Support hx and ts files
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/811
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Co-Authored-By: M M Arif <mmarif@noreply.codeberg.org>
Co-Committed-By: M M Arif <mmarif@noreply.codeberg.org>
Moving UI-related code to message queue of main thread.
Removing NetworkObserver in favor of NetworkStatusObserver
Some fixes.
Removing deprecated PreferenceManager.
Fixing crash.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into fix-performance-regression
Conflicts:
app/src/main/java/org/mian/gitnex/clients/RetrofitClient.java
Rewriting deprecated code.
Improving degraded performance due to unnecessary object allocation.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/800
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Minor performance improvements.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions
Improving color of selected elements.
First, fully working implementation of reactions.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions
Conflicts:
app/src/main/res/layout/bottom_sheet_issue_comments.xml
app/src/main/res/layout/list_issue_comments.xml
(Hopefully) fixing merge issues.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into issue-reactions
Conflicts:
app/src/main/java/org/mian/gitnex/interfaces/ApiInterface.java
app/src/main/res/layout/activity_issue_detail.xml
app/src/main/res/layout/bottom_sheet_issue_comments.xml
app/src/main/res/layout/bottom_sheet_single_issue.xml
app/src/main/res/values/colors.xml
Moving reactions below time frame on comments.
Merge branch 'master' into layout-reactions
Add IssueReactions
Merge remote-tracking branch 'origin/layout-reactions' into layout-reactions
Merge branch 'master' of https://gitea.com/gitnex/GitNex into layout-reactions
Merge branch 'master' into layout-reactions
Applying to pulls and issues.
Merge branch 'master' of https://gitea.com/gitnex/GitNex into layout-reactions
Providing external layouts.
Some improvements.
Adding comment emote indications.
Adding circle around emotes.
Adding some padding.
First tests.
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/557
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Merge branch 'performance-highlight-refactor' of https://codeberg.org/opyale/GitNex into performance-highlight-refactor
Fixing theme recognition.
Merge branch 'master' into performance-highlight-refactor
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Add new field issueType to db
Improving theme recognition.
Fixing alignment of menu button.
Fixing cut off text.
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Fixing crash.
Refactoring activities.
Improving drafts.
Calculating density for avatars.
Improving drafts.
Calculating density for avatars.
Increasing size of avatar.
Decreasing size of avatar.
Restoring DeepLinksActivity
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into performance-highlight-refactor
Conflicts:
app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
Initial commit.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/755
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
change to server error on onFailure
Fix keyboard move issue
Fix statusbar color, remove social, enhance other things
Merge branch 'master' into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Conflicts:
app/src/main/java/org/mian/gitnex/activities/IssueDetailActivity.java
Making it work.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
First major changes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Cleanup.
Simplifying title.
Adding BottomSheetFragment layout for future changes.
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: opyale <example@example.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/555
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Cleanup
Extending and improving notifications
Using new icons instead
Lowering polling delay to one minute and other improvements
Fixing minor issues
Simplifying progress layout
Fixing bugs and other improvements
Adding translations
Notifications
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/554
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Moving TinyDB and AppUtil to helpers.
Co-authored-by: opyale <opyale@noreply.gitea.io>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/579
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
M M Arif
M M Arif
qwerty287
opyale