Run `gradle :app:spotlessApply` to apply formatting.
# Changes from current code format
This does not match with the old intellij based code format because I can't apply some rules there.
- newlines after `else`, `catch` etc. (means there are `} else {` statements)
- no spaces around `if` braces (there are statements like `if (true) {` instead of `if(true) {`
Closes https://codeberg.org/gitnex/GitNex/issues/1187
Closes https://codeberg.org/gitnex/GitNex/issues/1202
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1208
Reviewed-by: 6543 <6543@obermui.de>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
As title
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1185
Reviewed-by: 6543 <6543@noreply.codeberg.org>
There are not any functinality changes except more of UI changes which comes with M3. There are still few things left but that are not there yet from Google side.
I will be merging this PR as it does not break any function but attaching a few screenshots if you would like to know how it looks like. Feel free to build from `main` to test it out.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1181
Extend CI workflows (-> https://codeberg.org/gitnex/GitNex/issues/1099)
1. pull translations and push them again on every pull
@mmarif this needs the secrets and `BOT_TOKEN`
the code for this comes from tea4j-autodeploy
2. add a **template** for a check workflow which only does some static checks right now. It is disabled because it requires some investigation and discussion on how we should deal with these issues. The checks are currently (if we would enable it):
1. check code style and formatting according to the project file in `.idea/`
2. make sure every Java file has an `@author` annotation
I would wait until you reviewed with enabling them because we have to reformat all the files which results in changes with a few thousand changed lines (tried this once).
Closes https://codeberg.org/gitnex/GitNex/issues/141
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1155
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
1. improve menu time (show when loading finished)
2. fix crashes from deleted forks
I mainly tried to fix issue https://codeberg.org/gitnex/GitNex/issues/1137, but:
1. the missing UI options are Gitea's issue (the permission values are not correct when using notification endpoints)
2. the comments crash is an `SQLiteConstraintException` which we had already in #1084 but it seems that it wasn't fixed
Closes https://codeberg.org/gitnex/GitNex/issues/1137 closes https://codeberg.org/gitnex/GitNex/issues/1144
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1146
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
* remove arguments from alert dialogs funcs
* clean up strings
* fix strings with multiple `%s`
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1121
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
* view team repos
* add team repos
* removing does not work due to missing APIs
Closes#7 and replaces https://codeberg.org/gitnex/GitNex/pulls/701
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1113
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Move to https://codeberg.org/GitNex/tea4j-autodeploy as Retrofit interfaces. Closes#907closes#1084
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1088
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
This PR mostly intend to improve and re visualize the UI across the app including clean up of layouts and strings.
Some UI changes are experimental like bottom sheet grid layout for repo items and can be extended once mature enough for use.
Few screen shots attached.
Closes#1077Closes#976
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1074
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after c9172f85ef, Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes#354
* replaces #897
* fixes#947
* closes#1001
* closes#1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Cherry-pick enhancements and features from #897. I didn't pick database-related stuff because I don't think it's a good idea to do this (see discord conversation).
Closes#598Closes#887Closes#888Closes#901Closes#1024Closes#1035
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1032
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
### Describe what your pull request does and which issue you’re targeting
<!-- Create a new issue, if it doesn't exist yet -->
Closes#967
<br><br>
<!-- Make sure you are targeting the "main" branch, pull requests on release branches are only allowed for bug fixes. -->
- [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md).
- [X] I'm following the code standards as defined [here](https://codeberg.org/gitnex/GitNex/wiki/Code-Standards).
- [X] By submitting this pull request, I permit GitNex to license my work under the [GNU General Public License v3](https://codeberg.org/GitNex/GitNex/src/branch/main/LICENSE).
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/973
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
### Describe what your pull request does and which issue you’re targeting
<!-- Create a new issue, if it doesn't exist yet -->
Closes#860
<br><br>
<!-- Make sure you are targeting the "main" branch, pull requests on release branches are only allowed for bug fixes. -->
- [X] I carefully read the [contribution guidelines](https://codeberg.org/GitNex/GitNex/src/branch/main/CONTRIBUTING.md).
- [X] I'm following the code standards as defined [here](https://codeberg.org/gitnex/GitNex/wiki/Code-Standards).
- [X] By submitting this pull request, I permit GitNex to license my work under the [GNU General Public License v3](https://codeberg.org/GitNex/GitNex/src/branch/main/LICENSE).
Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/929
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Removing file size selection dialog in favor of hardcoded value.
Adding warning to file size picker and minor improvements.
Bump dependencies and gradle
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improving credits, adding symlink and submodule icons to FilesAdapter and removing unused libraries.
Minor improvements and bug fixes.
Add true progress indication routine for copying streams.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Performance and memory usage improvements
Notification improvements
Renaming StaticGlobalVariables to Constants
Overall improvements and fixes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Add additional image formats.
Adding audio and video categories.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into improve-filetype-recognition
Improve file type handling.
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/841
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
remove unknown case for editing
Improve var names and code formatting
Minor improvements.
Restoring ACRA functionality.
Fixing and improving scaling of images, improving performance by doing work that has to be done once only once and using different terminology.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/831
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Gradle v6.8.2
Use release instead of commit hash.
Moving ApiInterface, WebInterface and models to different repository.
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/824
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-Authored-By: opyale <opyale@noreply.codeberg.org>
Co-Committed-By: opyale <opyale@noreply.codeberg.org>
Merge branch 'performance-highlight-refactor' of https://codeberg.org/opyale/GitNex into performance-highlight-refactor
Fixing theme recognition.
Merge branch 'master' into performance-highlight-refactor
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Add new field issueType to db
Improving theme recognition.
Fixing alignment of menu button.
Fixing cut off text.
Merge commit 'refs/pull/755/head' of codeberg.org:gitnex/GitNex into performance-highlight-refactor
Fixing crash.
Refactoring activities.
Improving drafts.
Calculating density for avatars.
Improving drafts.
Calculating density for avatars.
Increasing size of avatar.
Decreasing size of avatar.
Restoring DeepLinksActivity
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into performance-highlight-refactor
Conflicts:
app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
Initial commit.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/755
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
change to server error on onFailure
Fix keyboard move issue
Fix statusbar color, remove social, enhance other things
Merge branch 'master' into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Conflicts:
app/src/main/java/org/mian/gitnex/activities/IssueDetailActivity.java
Making it work.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
First major changes.
Merge branch 'master' of https://codeberg.org/gitnex/GitNex into bottomsheet-issue-comments
Cleanup.
Simplifying title.
Adding BottomSheetFragment layout for future changes.
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: opyale <example@example.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/555
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Preventing lists to store duplicate collaborators (#726)
Using login instead of id.
Merge branch 'new-popup-labels-assigness' of https://codeberg.org/gitnex/GitNex into new-popup-labels-assigness
To prevent lists storing duplicate Collaborators
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/726
Add current logged user to list
Change to collection
Fix depricated handler calls
Change to List and better naming
Move to actions
Merge branch 'master' into new-popup-labels-assigness
Add assignees popup and remove multi select
update to view binding
add/remove labels in edit issue
remove org call
Add org members to assignees list
Add assignees adapter
Add color to labels
Refactor and add new labels popup
Clean up build libs
Co-authored-by: opyale <opyale@noreply.codeberg.org>
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/723
Reviewed-by: opyale <opyale@noreply.codeberg.org>
Merge branch 'master' into 627-save-edit-draft
# Conflicts:
# app/src/main/java/org/mian/gitnex/actions/IssueActions.java
Merge branch 'master' into 627-save-edit-draft
Improve drafts, add edited comments, create new ones on each call.
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/628
Enhance and update the buttons across the app, colorful animation on tap
update toasty in view models
update toasty in fragments
update toasty in actions, activities, adapters
Alert dialogs buttons arrangements
strings fixes
switch to fab buttons
remove snackbar
Enhance whole app UI, bring consistency among the elements
Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/630
Cleanup
Extending and improving notifications
Using new icons instead
Lowering polling delay to one minute and other improvements
Fixing minor issues
Simplifying progress layout
Fixing bugs and other improvements
Adding translations
Notifications
Co-authored-by: opyale <opyale@noreply.gitea.io>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/554
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Moving TinyDB and AppUtil to helpers.
Co-authored-by: opyale <opyale@noreply.gitea.io>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/579
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Implement archived repo in all adapters
Merge branch 'archive-repo2' into archive-repo
Fix typos
Fixing gravity.
Restoring old names.
Design changes.
Adjusting sizing.
Improving design of archived message.
Show archived repo message and other fixes
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: opyale <opyale@noreply.gitea.io>
Reviewed-by: opyale <opyale@noreply.codeberg.org>
remove strings
translation: generic but with contecxt
Merge branch 'milestones-filter' of gitea.com:gitnex/GitNex into milestones-filter
Clean up strings
Merge branch 'master' into milestones-filter
clean up and add missing parts
enhance and refactor milestone, added filter for closed and open ms
change to viewbinding
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/506
Reviewed-by: 6543 <6543@noreply.gitea.io>
update string names
Update strings
Merge branch 'master' into imprufe-issue-subscription-checking
switch icon as per @mmarif
Migrate to new Version Check & disable IssueSubscription function for gitea < 1.12.0
Merge branch 'master' into imprufe-issue-subscription-checking
Merge branch 'master' into imprufe-issue-subscription-checking
Merge branch 'master' into imprufe-issue-subscription-checking
refactor & use dismiss()
realy check If issue is subscribed
add 200 http Status check and handle it
Rename WatchRepository to WatchInfo & add checkIssueWatchStatus
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/445
Reviewed-by: M M Arif <mmarif@swatian.com>
Search as user type, fix datalist.
Code Format
Fix users search theme
add and remove user from team
Add interface and user search and check for being team member or not
bottom sheet menu and few refactors
Co-authored-by: 6543 <6543@noreply.gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/483
Reviewed-by: 6543 <6543@noreply.gitea.io>
Code Reformat
Use return from 6543 commit
Fix typo
Move delete method to adapter to update the recyclerview
make it work
add to bottomsheet entry
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/478
Reviewed-by: 6543 <6543@noreply.gitea.io>
Merge branch 'master' into 427-dismiss-bottom-sheet
Does not really fix the issue as there is way to handle this without a proper call.
And dismiss does not work properly either.
But added few improvements and fixed close/reopen issue along the way.
Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/428
Reviewed-by: 6543 <6543@noreply.gitea.io>
rename Context
move things to IssueActions
rm unused API func
get Context only one time
add repoWatch into tinyDB
add maginal Issue Un-/Subscription support
add Issue Subscribtion
* api
* layout
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/203
Reviewed-by: M M Arif <mmarif@swatian.com>
qwerty287
M M Arif
opyale
M M Arif
6543