From 685844d41ffa5e9f7d65140c3d48546d975feb1e Mon Sep 17 00:00:00 2001 From: qwerty287 Date: Sat, 30 Apr 2022 13:47:15 +0200 Subject: [PATCH] Fix invalid version detection (#1116) Co-authored-by: qwerty287 Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1116 Reviewed-by: M M Arif Co-authored-by: qwerty287 Co-committed-by: qwerty287 --- app/src/main/java/org/mian/gitnex/helpers/Version.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/mian/gitnex/helpers/Version.java b/app/src/main/java/org/mian/gitnex/helpers/Version.java index ed6d9209..fafdcf83 100644 --- a/app/src/main/java/org/mian/gitnex/helpers/Version.java +++ b/app/src/main/java/org/mian/gitnex/helpers/Version.java @@ -51,7 +51,10 @@ public class Version { final Pattern patternNumberDotNumber = Pattern.compile("^\\d+(\\.(\\d)+)*"); - if(!valid(raw) || raw.equals("main")) { + if(!valid(raw)) { + throw new IllegalArgumentException("Invalid version format: " + raw); + } + if(raw.equals("main")) { dev = true; values = new ArrayList<>(); return;