From 4f0091f151ec84b8e088925443c798a4e5f23e0b Mon Sep 17 00:00:00 2001 From: M M Arif Date: Mon, 1 Jun 2020 15:53:56 +0000 Subject: [PATCH] Improve layouts (#524) make release checkboxes unchecked admin users layout update update commits and releases layout profile fragments layout updates improve labels Merge branch 'master' into improve-layouts branches and milestones layout update. Fix milestone infinite pagination loop for lower versions layout updates for issues, pr. Fix pr nullable objects for lower versions improve files layout improve org info and list orgs improve teams list layout by org Fix repo layouts Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/524 Reviewed-by: opyale --- .../gitnex/adapters/PullRequestsAdapter.java | 8 +- .../gitnex/fragments/MilestonesFragment.java | 38 +-- .../fragments/OrganizationInfoFragment.java | 24 +- .../res/layout/activity_admin_get_users.xml | 3 +- app/src/main/res/layout/activity_commits.xml | 3 +- .../res/layout/activity_create_release.xml | 6 +- .../layout/activity_create_team_by_org.xml | 32 +-- app/src/main/res/layout/fragment_branches.xml | 3 +- app/src/main/res/layout/fragment_files.xml | 3 +- app/src/main/res/layout/fragment_issues.xml | 3 +- app/src/main/res/layout/fragment_labels.xml | 3 +- .../main/res/layout/fragment_milestones.xml | 3 +- .../res/layout/fragment_my_repositories.xml | 3 +- .../res/layout/fragment_organization_info.xml | 21 +- .../res/layout/fragment_organizations.xml | 1 - .../res/layout/fragment_profile_emails.xml | 3 +- .../res/layout/fragment_profile_followers.xml | 3 +- .../res/layout/fragment_profile_following.xml | 3 +- .../res/layout/fragment_pull_requests.xml | 3 +- app/src/main/res/layout/fragment_releases.xml | 3 +- .../layout/fragment_repositories_by_org.xml | 3 +- .../layout/fragment_starred_repositories.xml | 3 +- .../main/res/layout/fragment_teams_by_org.xml | 3 +- app/src/main/res/layout/list_admin_users.xml | 5 +- app/src/main/res/layout/list_branches.xml | 3 +- app/src/main/res/layout/list_commits.xml | 8 +- app/src/main/res/layout/list_files.xml | 4 +- app/src/main/res/layout/list_issues.xml | 122 +++++----- app/src/main/res/layout/list_labels.xml | 40 ++-- app/src/main/res/layout/list_milestones.xml | 222 ++++++++++-------- .../main/res/layout/list_organizations.xml | 14 +- app/src/main/res/layout/list_pr.xml | 114 ++++----- .../main/res/layout/list_profile_emails.xml | 5 +- .../res/layout/list_profile_followers.xml | 8 +- .../res/layout/list_profile_following.xml | 8 +- app/src/main/res/layout/list_releases.xml | 8 +- 36 files changed, 373 insertions(+), 366 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/adapters/PullRequestsAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/PullRequestsAdapter.java index 992f0184..60a2c9fb 100644 --- a/app/src/main/java/org/mian/gitnex/adapters/PullRequestsAdapter.java +++ b/app/src/main/java/org/mian/gitnex/adapters/PullRequestsAdapter.java @@ -188,9 +188,11 @@ public class PullRequestsAdapter extends RecyclerView.Adapter(); adapter = new MilestonesAdapter(ctx, dataList); - adapter.setLoadMoreListener(() -> viewBinding.recyclerView.post(() -> { + if(new Version(tinyDb.getString("giteaVersion")).higherOrEqual("1.12.0")) { - if(dataList.size() == resultLimit || pageSize == resultLimit) { + adapter.setLoadMoreListener(() -> viewBinding.recyclerView.post(() -> { - int page = (dataList.size() + resultLimit) / resultLimit; - loadMore(Authorization.returnAuthentication(getContext(), loginUid, instanceToken), repoOwner, repoName, page, resultLimit, tinyDb.getString("milestoneState")); + if(dataList.size() == resultLimit || pageSize == resultLimit) { - } + int page = (dataList.size() + resultLimit) / resultLimit; + loadMore(Authorization.returnAuthentication(getContext(), loginUid, instanceToken), repoOwner, repoName, page, resultLimit, tinyDb.getString("milestoneState")); - })); + } + + })); + + } viewBinding.recyclerView.setHasFixedSize(true); viewBinding.recyclerView.setLayoutManager(new LinearLayoutManager(ctx)); @@ -113,16 +117,21 @@ public class MilestonesFragment extends Fragment { dataList.clear(); adapter = new MilestonesAdapter(ctx, dataList); - adapter.setLoadMoreListener(() -> viewBinding.recyclerView.post(() -> { - if(dataList.size() == resultLimit || pageSize == resultLimit) { + if(new Version(tinyDb.getString("giteaVersion")).higherOrEqual("1.12.0")) { - int page = (dataList.size() + resultLimit) / resultLimit; - loadMore(Authorization.returnAuthentication(getContext(), loginUid, instanceToken), repoOwner, repoName, page, resultLimit, milestoneState); + adapter.setLoadMoreListener(() -> viewBinding.recyclerView.post(() -> { - } + if(dataList.size() == resultLimit || pageSize == resultLimit) { - })); + int page = (dataList.size() + resultLimit) / resultLimit; + loadMore(Authorization.returnAuthentication(getContext(), loginUid, instanceToken), repoOwner, repoName, page, resultLimit, milestoneState); + + } + + })); + + } tinyDb.putString("milestoneState", milestoneState); @@ -171,7 +180,7 @@ public class MilestonesFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { assert response.body() != null; if(response.body().size() > 0) { @@ -222,7 +231,7 @@ public class MilestonesFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { //remove loading view dataList.remove(dataList.size() - 1); @@ -238,7 +247,6 @@ public class MilestonesFragment extends Fragment { } else { - Toasty.info(ctx, getString(R.string.noMoreData)); adapter.setMoreDataAvailable(false); } diff --git a/app/src/main/java/org/mian/gitnex/fragments/OrganizationInfoFragment.java b/app/src/main/java/org/mian/gitnex/fragments/OrganizationInfoFragment.java index 71cda317..adeb45b4 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/OrganizationInfoFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/OrganizationInfoFragment.java @@ -12,6 +12,7 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import android.widget.ImageView; +import android.widget.LinearLayout; import android.widget.ProgressBar; import android.widget.TextView; import org.mian.gitnex.R; @@ -37,6 +38,7 @@ public class OrganizationInfoFragment extends Fragment { private TextView orgDescInfo; private TextView orgWebsiteInfo; private TextView orgLocationInfo; + private LinearLayout orgInfoLayout; private RepoInfoFragment.OnFragmentInteractionListener mListener; @@ -76,6 +78,7 @@ public class OrganizationInfoFragment extends Fragment { orgDescInfo = v.findViewById(R.id.orgDescInfo); orgWebsiteInfo = v.findViewById(R.id.orgWebsiteInfo); orgLocationInfo = v.findViewById(R.id.orgLocationInfo); + orgInfoLayout = v.findViewById(R.id.orgInfoLayout); orgNameInfo.setText(orgName); @@ -99,19 +102,22 @@ public class OrganizationInfoFragment extends Fragment { Organization orgInfo = response.body(); - if (response.isSuccessful()) { + if (response.code() == 200) { - if (response.code() == 200) { + orgInfoLayout.setVisibility(View.VISIBLE); - assert orgInfo != null; - PicassoService.getInstance(ctx).get().load(orgInfo.getAvatar_url()).placeholder(R.drawable.loader_animated).transform(new RoundedTransformation(8, 0)).resize(180, 180).centerCrop().into(orgAvatar); - orgDescInfo.setText(orgInfo.getDescription()); - orgWebsiteInfo.setText(orgInfo.getWebsite()); - orgLocationInfo.setText(orgInfo.getLocation()); + assert orgInfo != null; + PicassoService.getInstance(ctx).get().load(orgInfo.getAvatar_url()).placeholder(R.drawable.loader_animated).transform(new RoundedTransformation(8, 0)).resize(180, 180).centerCrop().into(orgAvatar); + orgDescInfo.setText(orgInfo.getDescription()); + orgWebsiteInfo.setText(orgInfo.getWebsite()); + orgLocationInfo.setText(orgInfo.getLocation()); - mProgressBar.setVisibility(View.GONE); + mProgressBar.setVisibility(View.GONE); - } + } + else if(response.code() == 404) { + + mProgressBar.setVisibility(View.GONE); } else { diff --git a/app/src/main/res/layout/activity_admin_get_users.xml b/app/src/main/res/layout/activity_admin_get_users.xml index 06805643..26afb6f8 100644 --- a/app/src/main/res/layout/activity_admin_get_users.xml +++ b/app/src/main/res/layout/activity_admin_get_users.xml @@ -54,7 +54,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:background="?attr/primaryBackgroundColor" - android:padding="4dp" android:scrollbars="vertical" /> @@ -70,4 +69,4 @@ android:textSize="20sp" android:visibility="visible" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/activity_commits.xml b/app/src/main/res/layout/activity_commits.xml index a8fd5e10..25b259e0 100644 --- a/app/src/main/res/layout/activity_commits.xml +++ b/app/src/main/res/layout/activity_commits.xml @@ -58,7 +58,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:background="?attr/primaryBackgroundColor" - android:padding="4dp" android:scrollbars="vertical" /> @@ -83,4 +82,4 @@ android:indeterminate="true" android:visibility="visible" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/activity_create_release.xml b/app/src/main/res/layout/activity_create_release.xml index 8700f820..c102c437 100644 --- a/app/src/main/res/layout/activity_create_release.xml +++ b/app/src/main/res/layout/activity_create_release.xml @@ -160,7 +160,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:text="@string/releaseTypeText" - android:checked="true" + android:checked="false" android:textSize="16sp" android:layout_marginTop="10dp" android:textColor="?attr/primaryTextColor"/> @@ -170,7 +170,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:text="@string/releaseDraftText" - android:checked="true" + android:checked="false" android:textSize="16sp" android:layout_marginTop="10dp" android:textColor="?attr/primaryTextColor"/> @@ -194,4 +194,4 @@ - \ No newline at end of file + diff --git a/app/src/main/res/layout/activity_create_team_by_org.xml b/app/src/main/res/layout/activity_create_team_by_org.xml index 435f4358..e9a3f416 100644 --- a/app/src/main/res/layout/activity_create_team_by_org.xml +++ b/app/src/main/res/layout/activity_create_team_by_org.xml @@ -74,7 +74,7 @@ android:background="@drawable/shape_inputs" android:textColor="?attr/inputTextColor" android:textColorHint="?attr/hintColor" - android:textColorHighlight="?attr/primaryTextColor"/> + android:textColorHighlight="?attr/primaryTextColor" /> + android:textColorHighlight="?attr/primaryTextColor" /> + android:layout_marginTop="10dp" /> + android:textColor="?attr/inputTextColor" + android:textColorHint="?attr/hintColor" + android:textColorHighlight="?attr/primaryTextColor" + android:inputType="none" /> + android:visibility="gone" /> + android:layout_marginTop="10dp" /> + android:textColor="?attr/inputTextColor" + android:textColorHint="?attr/hintColor" + android:textColorHighlight="?attr/primaryTextColor" + android:inputType="none" /> + android:visibility="gone" />