Gitea/GitNex-Android-App
1
0
Fork 0
mirror of https://codeberg.org/gitnex/GitNex synced 2025-03-09 08:07:48 +01:00
Code Issues Releases Wiki Activity

Fix infined load on Issues/Pulls if they dont exist (#507)

Browse Source 
404 fix for issues

add 404 for pr

Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/507
Reviewed-by: 6543 <6543@noreply.gitea.io>
This commit is contained in:
M M Arif 2020-05-23 18:30:33 +00:00 committed by 6543
parent b30e2da387
commit 34f8f82b63
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java
View File

@ -180,7 +180,7 @@ public class IssuesFragment extends Fragment {
@Override @Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) { public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) { if(response.code() == 200) {
assert response.body() != null; assert response.body() != null;
if(response.body().size() > 0) { if(response.body().size() > 0) {
@ -192,11 +192,21 @@ public class IssuesFragment extends Fragment {
} }
else { else {
issuesList.clear(); issuesList.clear();
adapter.notifyDataChanged(); adapter.notifyDataChanged();
noDataIssues.setVisibility(View.VISIBLE); noDataIssues.setVisibility(View.VISIBLE);
} }
mProgressBar.setVisibility(View.GONE); mProgressBar.setVisibility(View.GONE);
}
else if(response.code() == 404) {
noDataIssues.setVisibility(View.VISIBLE);
mProgressBar.setVisibility(View.GONE);
} }
else { else {
Log.e(TAG, String.valueOf(response.code())); Log.e(TAG, String.valueOf(response.code()));
@ -227,7 +237,7 @@ public class IssuesFragment extends Fragment {
@Override @Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) { public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) { if(response.code() == 200) {
//remove loading view //remove loading view
issuesList.remove(issuesList.size() - 1); issuesList.remove(issuesList.size() - 1);

16
app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java
View File

@ -183,7 +183,7 @@ public class PullRequestsFragment extends Fragment {
@Override @Override
public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) { public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) {
if(response.isSuccessful()) { if(response.code() == 200) {
assert response.body() != null; assert response.body() != null;
if(response.body().size() > 0) { if(response.body().size() > 0) {
@ -195,14 +195,26 @@ public class PullRequestsFragment extends Fragment {
} }
else { else {
prList.clear(); prList.clear();
adapter.notifyDataChanged(); adapter.notifyDataChanged();
noData.setVisibility(View.VISIBLE); noData.setVisibility(View.VISIBLE);
} }
mProgressBar.setVisibility(View.GONE); mProgressBar.setVisibility(View.GONE);
}
else if(response.code() == 404) {
noData.setVisibility(View.VISIBLE);
mProgressBar.setVisibility(View.GONE);
} }
else { else {
Log.i(TAG, String.valueOf(response.code())); Log.i(TAG, String.valueOf(response.code()));
} }
Log.i(TAG, String.valueOf(response.code())); Log.i(TAG, String.valueOf(response.code()));
@ -232,7 +244,7 @@ public class PullRequestsFragment extends Fragment {
@Override @Override
public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) { public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) {
if(response.isSuccessful()) { if(response.code() == 200) {
//remove loading view //remove loading view
prList.remove(prList.size() - 1); prList.remove(prList.size() - 1);