Commit Graph

10 Commits

Author SHA1 Message Date
tzugen cc7e273d50
Fix remaining warnings 2021-05-27 11:18:29 +02:00
tzugen df047dd463
Refactor MediaPlayerController to Kotlin
and also make MediaPlayerService context-free
2021-05-21 22:35:22 +02:00
tzugen b559f6420e
Move certain ignores from the baseline to the specified files. This makes refactoring much less fragile. 2021-05-20 18:16:55 +02:00
tzugen 13b00f75f0
Use default values for LongMethod, LongParameterList, LargeClass and ComplexMethod.
The algrorithms in detekt had changed when I updated detekt to v1.16, but our values not,
resulting in a very long baseline file with many non-sensical warnings.
By removing our config we follow the detekt config when they modify their algorithms again.
2021-05-16 17:42:31 +02:00
tzugen 237f7ab181
Update baseline files. I have moved several methods, which now get triggered again.
To keep this PR manageable, I don't intent to split up the classes now.
2021-04-27 20:41:14 +02:00
tzugen 410e1df980
Upgrade detekt to v1.16.0 to get Type Resolution support
In course I had to modify the rules (many were renamed or dropped),
and create a new baseline (many new rules added errors in old files)
2021-04-23 11:26:15 +02:00
tzugen df54d3450b
Detekt: Remove "warningThreshold and failThreshold properties are deprecated. Please use the new 'maxIssues' config property." 2021-04-23 11:26:14 +02:00
tzugen e63f24242b
Change detekt config: Allow TODO comments, but continue to block FIXME comments
Our code still has so many TODOs that sometimes they can't be fixed immediately
because the require a much larger refactor, and are also so specific that they
don't warrant an own bug.
2021-04-23 11:20:13 +02:00
Yahor Berdnikau e71d8a09af Increase allowed functions count in detekt config.
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
2017-08-24 22:04:53 +02:00
Yahor Berdnikau 07c2bfaeaf Add detekt - static code analysis tool for Kotlin.
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
2017-07-30 22:22:13 +02:00