fd48367cab
Reduce function length
2021-05-29 15:00:46 +02:00
f510638571
Fix KtLint issue
2021-05-26 08:49:23 +02:00
31850bf270
Cleanup AlertDialog method
...
The other method was unused, so we can get rid of it.
Also use a lambda for the callback
2021-05-26 08:49:12 +02:00
3c4a5064b0
change exception type
2021-05-25 19:30:02 +02:00
070e0ac792
Fix lintFormat + remove synchronized
2021-05-25 18:51:00 +02:00
1b7f48c53a
Implement server feature checking
2021-05-24 23:25:12 +02:00
2db7d2daf1
Hide cluttering koin warning, which was added in 2.2.0 and will be removed again in 2.3.0
...
See https://github.com/InsertKoinIO/koin/issues/939 for more details
2021-05-22 11:01:12 +02:00
79fd1ac84f
Remove resolved issues from baselines
2021-05-21 23:34:57 +02:00
0500bd5e88
Handle also UnknownHostException in GenericListModel
2021-05-21 23:34:57 +02:00
005c1cb8f7
Fix an String resource int that wasn't converted to a String
2021-05-21 23:34:57 +02:00
3d99269c41
Remove context from ShufflePlayBuffer
2021-05-21 23:34:57 +02:00
ed6c6c9057
Remove two warnings in Downloader
2021-05-21 23:34:57 +02:00
b8fbbd8c49
Remove Context from Downloader & DownloadFile
2021-05-21 23:34:52 +02:00
9b2e54b94e
Remove context from JukeboxMediaPlayer and Scrobbler
2021-05-21 22:52:16 +02:00
00e64cdddc
Use lambdas in OfflineMusicService
2021-05-21 22:39:21 +02:00
1b5db9da1f
Make ExternalStorageMonitor context-free
2021-05-21 22:37:43 +02:00
df047dd463
Refactor MediaPlayerController to Kotlin
...
and also make MediaPlayerService context-free
2021-05-21 22:35:22 +02:00
a801e276ee
Rename .java to .kt
2021-05-21 22:35:21 +02:00
05cb82921d
Fix remaining warnings in MediaPlayerLifecycleSupport
2021-05-21 19:43:37 +02:00
f596dc77c1
Make MediaPlayerLifecycleSupport context-free
2021-05-21 19:43:32 +02:00
7922d6caad
Prevent leaks by making cleanup tasks static
2021-05-21 19:11:26 +02:00
b25a118148
Remove unused context from CacheCleaner
2021-05-21 18:50:57 +02:00
402fe961ba
Merge MediaPlayerController interface & implementation
2021-05-21 18:50:33 +02:00
f1713fdbd3
Use a recently maintained version of DSLV, which compiles correctly with newer Gradles.
2021-05-21 09:16:06 +02:00
387119a90c
Make the CI fail if any new lint issues (warnings or errors) are added.
2021-05-20 18:16:55 +02:00
d26f8595ab
Manually disable IconMissingDensityFolder
2021-05-20 18:16:55 +02:00
dff054847a
Regenerate lint baseline
...
Removes 238 fixed issues
Adds 177 previously unlisted issues
2021-05-20 18:16:55 +02:00
3a05f30907
Fix more warnings
2021-05-20 18:16:55 +02:00
b559f6420e
Move certain ignores from the baseline to the specified files. This makes refactoring much less fragile.
2021-05-20 18:16:55 +02:00
8b01118233
Remove local copy of com.mobeta.android.dslv in favour of importing it from maven
2021-05-20 18:16:42 +02:00
5f08e7e7cd
Create a new SelectMusicFolderViewHolder instance when the Adapter is recreated,
...
instead of reusing an old one. This lead to a crash.
Also make the AlbumList use the correct placeholder,
remove an unused resource file, and update the placeholder to look less clumsy.
2021-05-18 08:50:04 +02:00
2cf80707f7
Correctly display the folder header also in album view
...
Also fix a number of smaller issues
2021-05-16 21:06:04 +02:00
72c03cc500
Introduce new Generic Fragments, ViewModels, and Adapters for the display of API data.
...
* Splits former SelectAlbumFragment into separate fragments for Albums and general collections of tracks
* Renames and refactors SelectArtist view to extend the new Generic classes
* Adds error handling (Fixes #484 )
* Adds EndlessScrolling capabilities to all Album Lists
* Uses RecyclerViews and LiveData for performance and in-memory caching
* Refreshes the UI to be aligned with the ArtistList UI
* Add a new GenericEntry to the domain data classes, and make other types extend it
2021-05-16 17:42:31 +02:00
c6a744cc14
Rename classes in preparation of split.
2021-05-16 17:42:31 +02:00
a60be2157b
Removing remaining context from MusicService signatures.
2021-05-11 14:26:29 +02:00
c66118172c
Revert accidental changes in the method signature.
2021-05-11 12:04:29 +02:00
5b6fa20050
This was literally the result of removing one(!) dependency on context inside FileUtil
...
17 Classes with x function which don't need to pass around context anymore..
2021-05-11 12:04:29 +02:00
f2b1ba0e94
Remove unused context references in MusicServiceFactory
2021-05-11 12:04:29 +02:00
76ba4c8ac9
Remove more context dependencies
2021-05-11 12:04:29 +02:00
2c5f8d9dd0
Now we can stop passing around the context for a lot of API calls
2021-05-11 12:04:29 +02:00
9ec92c6cf3
Make all preference operations context-free
...
(use the application context for them)
2021-05-11 12:04:26 +02:00
6c122b9e80
Fix #415
2021-05-09 18:31:54 +02:00
e0eb2aaf61
Fix a number of warnings
2021-05-09 18:30:38 +02:00
ec21e14e33
Merge branch 'develop' into lockscreen-controls
2021-05-07 16:15:20 +02:00
e37791e37c
Fixed deprecation warnings for kluent
2021-05-07 15:36:11 +02:00
afccbf3f65
Merge branch 'develop' into patch-further
2021-05-07 09:14:27 +02:00
a6c914cf7f
Make the server setting model a local val
2021-05-06 20:45:45 +02:00
9ca15deef2
Fix a copy & paste mistake
...
(Wrongly inserted if clause)
2021-05-06 20:45:45 +02:00
094c0d2757
Cache requireArguments() in a local val
2021-05-06 20:45:45 +02:00
bc2c591ff2
Set isActive correctly when pausing.
2021-05-06 13:23:38 +02:00
Maxence G
tzugen
tzugen
Nite
Nite