Move subsonic api client to it's own DI module.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>

subsonic-api/build.gradle

@@ -13,6 +13,8 @@ dependencies {
     api other.kotlinStdlib
     api other.retrofit
     api other.jacksonConverter
+    api other.koinCore
+
     implementation(other.jacksonKotlin) {
         exclude module: 'kotlin-reflect'
     }
@@ -36,7 +38,8 @@ jacoco {
 ext {
     // Excluding data classes
     jacocoExclude = [
-            '**/models/**'
+            '**/models/**',
+            '**/di/**'
     ]
 }
 

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/di/SubsonicApiModule.kt

@@ -0,0 +1,10 @@
+package org.moire.ultrasonic.api.subsonic.di
+
+import org.koin.dsl.context.Context
+import org.moire.ultrasonic.api.subsonic.SubsonicAPIClient
+
+const val SUBSONIC_API_CLIENT_CONTEXT = "SubsonicApiClientContext"
+
+fun Context.subsonicApiModule() = context(SUBSONIC_API_CLIENT_CONTEXT) {
+    bean { return@bean SubsonicAPIClient(get()) }
+}

ultrasonic/build.gradle

@@ -70,7 +70,7 @@ dependencies {
     testImplementation testing.kluent
 }
 
-// Excluding all non-kotlin classes
+// Excluding all java classes and stuff that should not be covered
 ext {
     jacocoExclude = [
             '**/activity/**',
@@ -84,7 +84,8 @@ ext {
             '**/view/**',
             '**/R$*.class',
             '**/R.class',
-            '**/BuildConfig.class'
+            '**/BuildConfig.class',
+            '**/di/**'
     ]
 }
 jacocoAndroidUnitTestReport {

ultrasonic/src/main/kotlin/org/moire/ultrasonic/di/MusicServiceModule.kt

@@ -8,6 +8,7 @@ import org.moire.ultrasonic.BuildConfig
 import org.moire.ultrasonic.api.subsonic.SubsonicAPIClient
 import org.moire.ultrasonic.api.subsonic.SubsonicAPIVersions
 import org.moire.ultrasonic.api.subsonic.SubsonicClientConfiguration
+import org.moire.ultrasonic.api.subsonic.di.subsonicApiModule
 import org.moire.ultrasonic.cache.PermanentFileStorage
 import org.moire.ultrasonic.service.CachedMusicService
 import org.moire.ultrasonic.service.MusicService
@@ -25,6 +26,8 @@ private const val LOG_TAG = "MusicServiceModule"
 
 fun musicServiceModule(sp: SharedPreferences) = applicationContext {
     context(MUSIC_SERVICE_CONTEXT) {
+        subsonicApiModule()
+
         bean(name = "ServerInstance") {
             return@bean sp.getInt(
                 Constants.PREFERENCES_KEY_SERVER_INSTANCE,