Merge remote-tracking branch 'mine/NPE' into NPE

fastlane/metadata/android/en-US/changelogs/91.txt

@@ -0,0 +1,5 @@
+Bug fixes
+- #395: Fixed layout to correctly display podcasts.
+
+Others
+- #399: Convert SelectAlbumFragment to kotlin.

fastlane/metadata/android/es-ES/changelogs/91.txt

@@ -0,0 +1,5 @@
+Bug fixes
+- #395: Corregido el diseño para mostrar correctamente los podcasts.
+
+Others
+- #399: Se ha convertido SelectAlbumFragment a kotlin.

ultrasonic/src/main/java/org/moire/ultrasonic/fragment/PlayerFragment.java

@@ -304,15 +304,8 @@ public class PlayerFragment extends Fragment implements GestureDetector.OnGestur
                     @Override
                     protected Boolean doInBackground()
                     {
-                        if (mediaPlayerControllerLazy.getValue().getCurrentPlayingNumberOnPlaylist() < mediaPlayerControllerLazy.getValue().getPlaylistSize() - 1)
+                        mediaPlayerControllerLazy.getValue().next();
-                        {
+                        return true;
-                            mediaPlayerControllerLazy.getValue().next();
-                            return true;
-                        }
-                        else
-                        {
-                            return false;
-                        }
                     }
 
                     @Override
@@ -1508,12 +1501,9 @@ public class PlayerFragment extends Fragment implements GestureDetector.OnGestur
         if (e1X - e2X > swipeDistance && absX > swipeVelocity)
         {
             networkAndStorageChecker.getValue().warnIfNetworkOrStorageUnavailable();
-            if (mediaPlayerController.getCurrentPlayingNumberOnPlaylist() < mediaPlayerController.getPlaylistSize() - 1)
+            mediaPlayerController.next();
-            {
+            onCurrentChanged();
-                mediaPlayerController.next();
+            onSliderProgressChanged();
-                onCurrentChanged();
-                onSliderProgressChanged();
-            }
             return true;
         }
 

ultrasonic/src/main/java/org/moire/ultrasonic/service/MediaPlayerControllerImpl.java

@@ -458,7 +458,20 @@ public class MediaPlayerControllerImpl implements MediaPlayerController
 		int index = downloader.getCurrentPlayingIndex();
 		if (index != -1)
 		{
-			play(index + 1);
+			switch (getRepeatMode())
+			{
+				case SINGLE:
+				case OFF:
+					if (index + 1 >= 0 && index + 1 < downloader.downloadList.size()) {
+						play(index + 1);
+					}
+					break;
+				case ALL:
+					play((index + 1) % downloader.downloadList.size());
+					break;
+				default:
+					break;
+			}
 		}
 	}
 

ultrasonic/src/main/java/org/moire/ultrasonic/service/MediaPlayerLifecycleSupport.java

@@ -221,10 +221,7 @@ public class MediaPlayerLifecycleSupport
 						mediaPlayerController.previous();
 						break;
 					case KeyEvent.KEYCODE_MEDIA_NEXT:
-						if (downloader.getCurrentPlayingIndex() < downloader.downloadList.size() - 1)
+						mediaPlayerController.next();
-						{
-							mediaPlayerController.next();
-						}
 						break;
 					case KeyEvent.KEYCODE_MEDIA_STOP:
 						mediaPlayerController.stop();