From 00d7ce326cda4c0fac9a349515190678df8a9cab Mon Sep 17 00:00:00 2001 From: tzugen <67737443+tzugen@users.noreply.github.com> Date: Mon, 20 Jun 2022 09:48:28 +0200 Subject: [PATCH 1/2] Rm comment --- .../kotlin/org/moire/ultrasonic/playback/PlaybackService.kt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/PlaybackService.kt b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/PlaybackService.kt index 3d456587..1cc994d2 100644 --- a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/PlaybackService.kt +++ b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/PlaybackService.kt @@ -42,11 +42,6 @@ class PlaybackService : MediaLibraryService(), KoinComponent { private var isStarted = false - /* - * For some reason the LocalConfiguration of MediaItem are stripped somewhere in ExoPlayer, - * and thereby customarily it is required to rebuild it.. - */ - override fun onCreate() { Timber.i("onCreate called") super.onCreate() From ab4196694366ddfeba3764ed89213a58da59b9d5 Mon Sep 17 00:00:00 2001 From: tzugen <67737443+tzugen@users.noreply.github.com> Date: Mon, 20 Jun 2022 09:49:49 +0200 Subject: [PATCH 2/2] Readd comment --- .../moire/ultrasonic/playback/AutoMediaBrowserCallback.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/AutoMediaBrowserCallback.kt b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/AutoMediaBrowserCallback.kt index cbaa3879..a28a7249 100644 --- a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/AutoMediaBrowserCallback.kt +++ b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/playback/AutoMediaBrowserCallback.kt @@ -177,7 +177,12 @@ class AutoMediaBrowserCallback(var player: Player) : return onLoadChildren(parentId) } - // https://stackoverflow.com/questions/70096715/adding-mediaitem-when-using-the-media3-library-caused-an-error + + /* + * For some reason the LocalConfiguration of MediaItem are stripped somewhere in ExoPlayer, + * and thereby customarily it is required to rebuild it.. + * See also: https://stackoverflow.com/questions/70096715/adding-mediaitem-when-using-the-media3-library-caused-an-error + */ override fun onAddMediaItems( mediaSession: MediaSession, controller: MediaSession.ControllerInfo,