Funkwhale
/
ultrasonic-app-subsonic-android
mirror of https://github.com/ultrasonic/ultrasonic
1
0
Fork 0
Code Issues Releases Wiki Activity

Generify check error response. 

This will help easier to test each method error response.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
This commit is contained in:
Yahor Berdnikau 2017-04-02 17:57:32 +02:00
parent cfa90e0a8d
commit 4dec26de9c
1 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
subsonic-api/src/integrationTest/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPITest.kt
View File

@ -53,21 +53,12 @@ class SubsonicAPITest {
} }
@Test @Test
fun `Should parse error response`() { fun `Should parse ping error response`() {
enqueueResponse("generic_error_response.json") checkErrorCallParsed { api.getApi().ping().execute() }
val response = api.getApi().ping().execute()
assertResponseSuccessful(response)
with(response.body()) {
status `should be` SubsonicResponse.Status.ERROR
version `should be` SubsonicAPIVersions.V1_13_0
error `should be` SubsonicError.GENERIC
}
} }
@Test @Test
fun `Should parse get license response`() { fun `Should parse get license ok response`() {
enqueueResponse("license_ok.json") enqueueResponse("license_ok.json")
val response = api.getApi().getLicense().execute() val response = api.getApi().getLicense().execute()
@ -81,17 +72,10 @@ class SubsonicAPITest {
} }
@Test @Test
fun `Should parse error get license response`() { fun `Should parse get license error response`() {
enqueueResponse("generic_error_response.json") val response = checkErrorCallParsed { api.getApi().getLicense().execute() }
val response = api.getApi().getLicense().execute() response.license `should be` null
assertResponseSuccessful(response)
with(response.body()) {
status `should be` SubsonicResponse.Status.ERROR
error `should be` SubsonicError.GENERIC
license `should be` null
}
} }
private fun enqueueResponse(resourceName: String) { private fun enqueueResponse(resourceName: String) {
@ -116,4 +100,17 @@ class SubsonicAPITest {
return result return result
} }
private fun <T: SubsonicResponse> checkErrorCallParsed(apiRequest: () -> Response<T>): T {
enqueueResponse("generic_error_response.json")
val response = apiRequest()
assertResponseSuccessful(response)
with(response.body()) {
status `should be` SubsonicResponse.Status.ERROR
error `should be` SubsonicError.GENERIC
}
return response.body()
}
} }