From 435376b48bb8a6fb3026ccebccce21b9f820a22a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 1 Nov 2021 11:02:54 +0000 Subject: [PATCH 1/5] Bump lifecycle-viewmodel-ktx from 2.2.0 to 2.4.0 Bumps lifecycle-viewmodel-ktx from 2.2.0 to 2.4.0. --- updated-dependencies: - dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- dependencies.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependencies.gradle b/dependencies.gradle index 5099db74..8953acd1 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -23,7 +23,7 @@ ext.versions = [ room : "2.3.0", kotlin : "1.5.31", kotlinxCoroutines : "1.5.2-native-mt", - viewModelKtx : "2.2.0", + viewModelKtx : "2.4.0", retrofit : "2.6.4", jackson : "2.9.5", From dc312d45929e297ad70768ddaf3bdcb99bdd0b3a Mon Sep 17 00:00:00 2001 From: tzugen <67737443+tzugen@users.noreply.github.com> Date: Mon, 1 Nov 2021 13:05:26 +0100 Subject: [PATCH 2/5] Update dependencies.gradle --- dependencies.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependencies.gradle b/dependencies.gradle index 8953acd1..26b0bbb4 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -23,7 +23,7 @@ ext.versions = [ room : "2.3.0", kotlin : "1.5.31", kotlinxCoroutines : "1.5.2-native-mt", - viewModelKtx : "2.4.0", + viewModelKtx : "2.3.0", retrofit : "2.6.4", jackson : "2.9.5", From 7e3cb19bac4d323b57cfa95490645c0e9ed397f0 Mon Sep 17 00:00:00 2001 From: tzugen Date: Tue, 9 Nov 2021 17:26:38 +0100 Subject: [PATCH 3/5] Visually align song details. * Also cleanup unused layout and color files --- ultrasonic/lint-baseline.xml | 42 ------------------- .../kotlin/org/moire/ultrasonic/util/Util.kt | 2 +- ultrasonic/src/main/res/drawable/btn_bg.xml | 17 -------- ultrasonic/src/main/res/drawable/line.xml | 12 ------ .../src/main/res/drawable/line_drawable.xml | 9 ---- .../src/main/res/layout/now_playing.xml | 6 ++- .../main/res/layout/select_album_header.xml | 2 +- .../src/main/res/layout/song_details.xml | 9 ++-- ultrasonic/src/main/res/menu/main.xml | 13 ------ ultrasonic/src/main/res/values/colors.xml | 2 - ultrasonic/src/main/res/values/themes.xml | 2 +- ultrasonic/src/main/res/xml/settings.xml | 2 +- 12 files changed, 13 insertions(+), 105 deletions(-) delete mode 100644 ultrasonic/src/main/res/drawable/btn_bg.xml delete mode 100644 ultrasonic/src/main/res/drawable/line.xml delete mode 100644 ultrasonic/src/main/res/drawable/line_drawable.xml delete mode 100644 ultrasonic/src/main/res/menu/main.xml diff --git a/ultrasonic/lint-baseline.xml b/ultrasonic/lint-baseline.xml index d74e6655..c5d97926 100644 --- a/ultrasonic/lint-baseline.xml +++ b/ultrasonic/lint-baseline.xml @@ -286,38 +286,6 @@ column="5"/> - - - - - - - - - - - - - - { - context!!.setTheme(R.style.UltrasonicTheme) + context!!.setTheme(R.style.UltrasonicTheme_Dark) } Constants.PREFERENCES_KEY_THEME_BLACK -> { context!!.setTheme(R.style.UltrasonicTheme_Black) diff --git a/ultrasonic/src/main/res/drawable/btn_bg.xml b/ultrasonic/src/main/res/drawable/btn_bg.xml deleted file mode 100644 index 79d40784..00000000 --- a/ultrasonic/src/main/res/drawable/btn_bg.xml +++ /dev/null @@ -1,17 +0,0 @@ - - - - - - - - - \ No newline at end of file diff --git a/ultrasonic/src/main/res/drawable/line.xml b/ultrasonic/src/main/res/drawable/line.xml deleted file mode 100644 index e3f2eaac..00000000 --- a/ultrasonic/src/main/res/drawable/line.xml +++ /dev/null @@ -1,12 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/ultrasonic/src/main/res/drawable/line_drawable.xml b/ultrasonic/src/main/res/drawable/line_drawable.xml deleted file mode 100644 index 4f79f470..00000000 --- a/ultrasonic/src/main/res/drawable/line_drawable.xml +++ /dev/null @@ -1,9 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/ultrasonic/src/main/res/layout/now_playing.xml b/ultrasonic/src/main/res/layout/now_playing.xml index 5cf76272..60012de0 100644 --- a/ultrasonic/src/main/res/layout/now_playing.xml +++ b/ultrasonic/src/main/res/layout/now_playing.xml @@ -21,7 +21,8 @@ android:layout_height="64.0dip" android:focusable="true" android:gravity="center" - android:layout_marginStart="6dp" /> + android:layout_marginStart="6dp" + android:importantForAccessibility="no"/> + android:src="?attr/media_pause" + android:contentDescription="@string/buttons.play"/> diff --git a/ultrasonic/src/main/res/layout/select_album_header.xml b/ultrasonic/src/main/res/layout/select_album_header.xml index 95e3096e..c33df633 100644 --- a/ultrasonic/src/main/res/layout/select_album_header.xml +++ b/ultrasonic/src/main/res/layout/select_album_header.xml @@ -7,7 +7,7 @@ a:id="@+id/select_album_art" a:layout_width="160dip" a:layout_height="160dip" - a:layout_alignParentLeft="true" + a:layout_alignParentStart="true" a:layout_alignParentTop="true" a:layout_marginEnd="10dip" a:contentDescription="@null" diff --git a/ultrasonic/src/main/res/layout/song_details.xml b/ultrasonic/src/main/res/layout/song_details.xml index 7cab9d5f..4de05f9d 100644 --- a/ultrasonic/src/main/res/layout/song_details.xml +++ b/ultrasonic/src/main/res/layout/song_details.xml @@ -26,10 +26,10 @@ a:layout_height="wrap_content" a:layout_gravity="left|center_vertical" a:layout_weight="1" - a:drawablePadding="6dip" + a:drawablePadding="4dip" a:ellipsize="end" - a:paddingStart="4dip" - a:paddingEnd="2dip" + a:paddingStart="6dip" + a:paddingEnd="4dip" a:singleLine="true" a:textAppearance="?android:attr/textAppearanceMedium"/> @@ -55,7 +55,8 @@ a:layout_gravity="left|center_vertical" a:layout_weight="1" a:ellipsize="middle" - a:paddingStart="4dip" + a:paddingStart="1dip" + a:paddingEnd="4dip" a:singleLine="true" a:textAppearance="?android:attr/textAppearanceSmall"/> diff --git a/ultrasonic/src/main/res/menu/main.xml b/ultrasonic/src/main/res/menu/main.xml deleted file mode 100644 index 78713454..00000000 --- a/ultrasonic/src/main/res/menu/main.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/ultrasonic/src/main/res/values/colors.xml b/ultrasonic/src/main/res/values/colors.xml index 9d5bf7c3..189a0d42 100644 --- a/ultrasonic/src/main/res/values/colors.xml +++ b/ultrasonic/src/main/res/values/colors.xml @@ -6,8 +6,6 @@ #0099cc #6200EE #BB86FC - #8033b5e5 - #00000000 #80000000 #000000 #333333 diff --git a/ultrasonic/src/main/res/values/themes.xml b/ultrasonic/src/main/res/values/themes.xml index 286b548c..4e23d827 100644 --- a/ultrasonic/src/main/res/values/themes.xml +++ b/ultrasonic/src/main/res/values/themes.xml @@ -64,7 +64,7 @@ @drawable/list_selector_holo_dark_selected -