2020-09-24 14:19:33 +02:00
<?xml version="1.0" encoding="UTF-8"?>
2022-06-21 21:05:58 +02:00
<issues format= "6" by= "lint 7.2.1" type= "baseline" client= "gradle" dependencies= "false" name= "AGP (7.2.1)" variant= "all" version= "7.2.1" >
2020-09-24 14:19:33 +02:00
<issue
id="InflateParams"
message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout' s root element)"
2022-04-05 22:52:02 +02:00
errorLine1=" val view = inflater.inflate(R.layout.jukebox_volume, null)"
errorLine2=" ~~~~">
2020-09-24 14:19:33 +02:00
<location
2022-04-05 22:52:02 +02:00
file="src/main/kotlin/org/moire/ultrasonic/service/JukeboxMediaPlayer.kt"
line="331"
column="66"/>
2020-09-24 14:19:33 +02:00
</issue>
<issue
2021-05-19 18:58:12 +02:00
id="PluralsCandidate"
message="Formatting %d followed by words (" tracks" ): This should probably be a plural rather than a string"
2021-12-16 18:55:35 +01:00
errorLine1=" < string name=" select_album.n_selected" >%d tracks selected< /string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2020-09-24 14:19:33 +02:00
<location
2021-05-19 18:58:12 +02:00
file="src/main/res/values/strings.xml"
2022-04-20 22:03:17 +02:00
line="154"
2021-05-19 18:58:12 +02:00
column="5"/>
2020-09-24 14:19:33 +02:00
</issue>
<issue
id="AllowAllHostnameVerifier"
2021-05-19 18:58:12 +02:00
message="Using the `AllowAllHostnameVerifier` HostnameVerifier is unsafe because it always returns true, which could cause insecure network traffic due to trusting TLS/SSL server certificates for wrong hostnames"
2020-09-24 14:19:33 +02:00
errorLine1=" public static final X509HostnameVerifier ALLOW_ALL_HOSTNAME_VERIFIER = new AllowAllHostnameVerifier();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/moire/ultrasonic/service/ssl/SSLSocketFactory.java"
line="142"
column="73"/>
</issue>
2021-12-20 21:25:51 +01:00
<issue
id="TrustAllX509TrustManager"
message="`checkClientTrusted` is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers">
<location
file="org/moire/ultrasonic/api/subsonic/SubsonicAPIClient$allowSelfSignedCertificates$trustManager$1.class"/>
</issue>
<issue
id="TrustAllX509TrustManager"
message="`checkServerTrusted` is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers">
<location
file="org/moire/ultrasonic/api/subsonic/SubsonicAPIClient$allowSelfSignedCertificates$trustManager$1.class"/>
</issue>
2021-05-19 18:58:12 +02:00
<issue
2021-12-16 18:55:35 +01:00
id="ExportedContentProvider"
message="Exported content providers can provide access to potentially sensitive data"
errorLine1=" < provider"
2021-05-19 18:58:12 +02:00
errorLine2=" ~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
2022-06-20 19:49:17 +02:00
line="155"
2020-09-24 14:19:33 +02:00
column="10"/>
</issue>
2021-05-19 18:58:12 +02:00
<issue
2021-12-16 18:55:35 +01:00
id="ExportedReceiver"
message="Exported receiver does not require permission"
2022-05-04 11:59:48 +02:00
errorLine1=" < receiver android:name=" .receiver.UltrasonicIntentReceiver" "
2021-12-16 18:55:35 +01:00
errorLine2=" ~~~~~~~~">
2021-05-19 18:58:12 +02:00
<location
2021-12-16 18:55:35 +01:00
file="src/main/AndroidManifest.xml"
2022-06-20 19:49:17 +02:00
line="79"
2021-12-16 18:55:35 +01:00
column="10"/>
2021-05-19 18:58:12 +02:00
</issue>
2021-12-20 21:25:51 +01:00
<issue
2022-04-05 22:52:02 +02:00
id="ExportedService"
message="Exported service does not require permission"
errorLine1=" < service android:name=" .playback.PlaybackService" "
errorLine2=" ~~~~~~~">
2021-12-20 21:25:51 +01:00
<location
file="src/main/AndroidManifest.xml"
2022-06-20 19:49:17 +02:00
line="68"
2021-12-20 21:25:51 +01:00
column="10"/>
</issue>
2020-09-24 14:19:33 +02:00
<issue
id="ObsoleteLayoutParam"
message="Invalid layout param in a `LinearLayout`: `layout_above`"
errorLine1=" android:layout_above=" @+id/bottom" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/time_span_dialog.xml"
line="12"
column="9"/>
</issue>
<issue
id="ObsoleteLayoutParam"
message="Invalid layout param in a `LinearLayout`: `layout_below`"
errorLine1=" android:layout_below=" @+id/top" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/time_span_dialog.xml"
line="28"
column="9"/>
</issue>
<issue
id="Overdraw"
2021-05-19 18:58:12 +02:00
message="Possible overdraw: Root element paints background `@drawable/appwidget_dark_bg_trans` with a theme that also paints a background (inferred theme is `@style/NoActionBar`)"
2020-09-24 14:19:33 +02:00
errorLine1=" a:background=" @drawable/appwidget_dark_bg_trans" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="7"
column="5"/>
</issue>
<issue
id="Overdraw"
2021-05-19 18:58:12 +02:00
message="Possible overdraw: Root element paints background `@drawable/appwidget_dark_bg_trans` with a theme that also paints a background (inferred theme is `@style/NoActionBar`)"
2020-09-24 14:19:33 +02:00
errorLine1=" a:background=" @drawable/appwidget_dark_bg_trans" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="7"
column="5"/>
</issue>
<issue
id="Overdraw"
2021-05-19 18:58:12 +02:00
message="Possible overdraw: Root element paints background `@drawable/appwidget_dark_bg_trans` with a theme that also paints a background (inferred theme is `@style/NoActionBar`)"
2020-09-24 14:19:33 +02:00
errorLine1=" a:background=" @drawable/appwidget_dark_bg_trans" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="7"
column="5"/>
</issue>
<issue
id="Overdraw"
2021-05-19 18:58:12 +02:00
message="Possible overdraw: Root element paints background `@drawable/appwidget_dark_bg_trans` with a theme that also paints a background (inferred theme is `@style/NoActionBar`)"
2020-09-24 14:19:33 +02:00
errorLine1=" a:background=" @drawable/appwidget_dark_bg_trans" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="8"
column="5"/>
</issue>
<issue
id="UnusedResources"
2022-04-05 22:52:02 +02:00
message="The resource `R.drawable.ic_baseline_close` appears to be unused"
2021-05-19 18:58:12 +02:00
errorLine1="< vector xmlns:android=" http://schemas.android.com/apk/res/android" "
2020-09-24 14:19:33 +02:00
errorLine2="^">
<location
2022-04-05 22:52:02 +02:00
file="src/main/res/drawable/ic_baseline_close.xml"
2021-05-19 18:58:12 +02:00
line="1"
2020-09-24 14:19:33 +02:00
column="1"/>
</issue>
<issue
id="UnusedResources"
2022-04-05 22:52:02 +02:00
message="The resource `R.drawable.ic_menu_arrow` appears to be unused"
2021-05-19 18:58:12 +02:00
errorLine1="< vector xmlns:android=" http://schemas.android.com/apk/res/android" "
errorLine2="^">
2020-09-24 14:19:33 +02:00
<location
2022-04-05 22:52:02 +02:00
file="src/main/res/drawable/ic_menu_arrow.xml"
2021-05-19 18:58:12 +02:00
line="1"
column="1"/>
2020-09-24 14:19:33 +02:00
</issue>
2022-06-20 19:49:17 +02:00
<issue
id="UnusedResources"
message="The resource `R.drawable.media3_notification_pause` appears to be unused"
errorLine1="< vector android:height=" 48dp" "
errorLine2="^">
<location
file="src/main/res/drawable/media3_notification_pause.xml"
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.drawable.media3_notification_play` appears to be unused"
errorLine1="< vector android:height=" 48dp" "
errorLine2="^">
<location
file="src/main/res/drawable/media3_notification_play.xml"
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.drawable.media3_notification_seek_to_next` appears to be unused"
errorLine1="< vector android:height=" 32dp" "
errorLine2="^">
<location
file="src/main/res/drawable/media3_notification_seek_to_next.xml"
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.drawable.media3_notification_seek_to_previous` appears to be unused"
errorLine1="< vector android:height=" 32dp" "
errorLine2="^">
<location
file="src/main/res/drawable/media3_notification_seek_to_previous.xml"
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.drawable.media3_notification_small_icon` appears to be unused"
errorLine1="< vector xmlns:android=" http://schemas.android.com/apk/res/android" "
errorLine2="^">
<location
file="src/main/res/drawable/media3_notification_small_icon.xml"
line="1"
column="1"/>
</issue>
2020-09-24 14:19:33 +02:00
<issue
id="IconDuplicates"
2021-05-19 18:58:12 +02:00
message="The following unrelated icon files have identical contents: list_pressed_holo_dark.9.png, list_pressed_holo_light.9.png">
2020-09-24 14:19:33 +02:00
<location
2021-05-19 18:58:12 +02:00
file="src/main/res/drawable-hdpi/list_pressed_holo_light.9.png"/>
2020-09-24 14:19:33 +02:00
<location
2021-05-19 18:58:12 +02:00
file="src/main/res/drawable-hdpi/list_pressed_holo_dark.9.png"/>
2020-09-24 14:19:33 +02:00
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/chat.xml"
2021-05-19 18:58:12 +02:00
line="27"
2020-09-24 14:19:33 +02:00
column="10"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/save_playlist.xml"
line="9"
column="6"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/share_details.xml"
2021-10-15 13:52:07 +02:00
line="30"
2020-09-24 14:19:33 +02:00
column="10"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/time_span_dialog.xml"
line="30"
column="10"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/update_playlist.xml"
line="18"
column="4"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/update_playlist.xml"
line="40"
column="4"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="Custom view ``AutoRepeatButton`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" this.setOnTouchListener(new OnTouchListener()"
errorLine2=" ^">
<location
file="src/main/java/org/moire/ultrasonic/view/AutoRepeatButton.java"
2021-05-19 18:58:12 +02:00
line="36"
2020-09-24 14:19:33 +02:00
column="3"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="10"
column="6"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="76"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="85"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="94"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="10"
column="6"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="97"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="106"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="115"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="10"
column="6"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="82"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="91"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="100"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="10"
column="6"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="83"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="92"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="101"
column="14"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageButton"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/res/layout/chat.xml"
2021-05-19 18:58:12 +02:00
line="38"
2020-09-24 14:19:33 +02:00
column="10"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/chat_item.xml"
line="7"
column="6"/>
</issue>
<issue
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/res/layout/chat_item_reverse.xml"
line="64"
column="6"/>
</issue>
<issue
id="LabelFor"
2021-10-13 08:31:34 +02:00
message="Missing accessibility label: provide either a view with an `android:labelFor` that references this view or provide an `android:hint`"
2020-09-24 14:19:33 +02:00
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/save_playlist.xml"
line="9"
column="6"/>
</issue>
<issue
id="LabelFor"
2021-10-13 08:31:34 +02:00
message="Missing accessibility label: provide either a view with an `android:labelFor` that references this view or provide an `android:hint`"
2020-09-24 14:19:33 +02:00
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/share_details.xml"
2021-10-15 13:52:07 +02:00
line="30"
2020-09-24 14:19:33 +02:00
column="10"/>
</issue>
<issue
id="LabelFor"
2021-10-13 08:31:34 +02:00
message="Missing accessibility label: provide either a view with an `android:labelFor` that references this view or provide an `android:hint`"
2020-09-24 14:19:33 +02:00
errorLine1=" < EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/time_span_dialog.xml"
line="30"
column="10"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Title" , should use `@string` resource"
errorLine1=" a:text=" Title" "
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="46"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Artist" , should use `@string` resource"
errorLine1=" a:text=" Artist" "
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x1.xml"
line="64"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Title" , should use `@string` resource"
errorLine1=" a:text=" Title" "
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="48"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Artist" , should use `@string` resource"
errorLine1=" a:text=" Artist" "
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="65"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Album" , should use `@string` resource"
errorLine1=" a:text=" Album" "
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x2.xml"
line="82"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Title" , should use `@string` resource"
errorLine1=" a:text=" Title" "
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="50"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Artist" , should use `@string` resource"
errorLine1=" a:text=" Artist" "
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x3.xml"
line="66"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Title" , should use `@string` resource"
errorLine1=" a:text=" Title" "
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="51"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " Artist" , should use `@string` resource"
errorLine1=" a:text=" Artist" "
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/appwidget4x4.xml"
line="67"
column="17"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " 0 dB" , should use `@string` resource"
errorLine1=" a:text=" 0 dB" "
errorLine2=" ~~~~~~~~~~~~~">
<location
file="src/main/res/layout/equalizer_bar.xml"
line="19"
column="13"/>
</issue>
<issue
id="HardcodedText"
message="Hardcoded string " http://" , should use `@string` resource"
errorLine1=" a:text=" http://" "
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/server_edit.xml"
2021-11-09 18:07:25 +01:00
line="43"
2020-09-24 14:19:33 +02:00
column="13"/>
</issue>
2021-05-19 18:58:12 +02:00
<issue
id="RelativeOverlap"
message="`@id/current_playing_duration` can overlap `@id/current_playing_position` if @string/util.no_time, @string/util.no_time grow due to localized text expansion"
errorLine1=" < TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/player_slider.xml"
line="29"
column="10"/>
</issue>
2020-09-24 14:19:33 +02:00
</issues>
