Robert Gingras
e8be0adf37
TagReaderTagLib: Remove redundant ID3v2 validity check
...
TagLib will have created a valid ID3v2 tag on this file by this point in the code, due to the way it handles the tag() method for WAV::File. Thus the null pointer check is redundant and the hasID3v2() call is at best redundant and at worst will cause tags to not save when they otherwise should have
2024-04-24 01:23:51 +02:00
Robert Gingras
9f4a82bb62
TagReaderTagLib: Remove file_mpeg argument from the SetEmbeddedArt ID3v2 overload
2024-04-24 01:23:51 +02:00
Robert Gingras
8d7e14f21d
Song: Added WAV to list of supported filetypes
2024-04-24 01:23:51 +02:00
Robert Gingras
d03d3622aa
TagReaderTagLib: Have RIFF WAV files save ID3v2 tags, when applicable
2024-04-24 01:23:51 +02:00
Robert Gingras
821c32992d
TagReaderTagLib: Refactor ID3v2 saving to a dedicated function
2024-04-24 01:23:51 +02:00
Robert Gingras
b52cf9f3cd
TagReaderTagLib: Reposition ParseID3v2Tag
2024-04-24 01:23:51 +02:00
Robert Gingras
ab8e687f96
TagReaderTagLib: Add id3v2 parsing for RIFF WAV files
2024-04-24 01:23:51 +02:00
Robert Gingras
90703703aa
TagReaderTagLib: Make id3v2 parsing reusable
2024-04-24 01:23:51 +02:00
Jonas Kvinge
176984afe0
RadioPlaylistItem: Set correct col position for InitFromQuery
...
Fixes #1430
2024-04-23 22:34:00 +02:00
Jonas Kvinge
542efa17ff
Fix position for song and internet playlist items
...
Fixes #1430
2024-04-23 20:18:28 +02:00
Jonas Kvinge
6a2c2dbba1
Song: Fix loading length
2024-04-23 20:16:41 +02:00
Jonas Kvinge
426de61525
Add const and std::as_const
2024-04-23 17:15:42 +02:00
Jonas Kvinge
24c8d06d41
SongPlaylistItem: Use static_cast
2024-04-23 17:00:10 +02:00
Jonas Kvinge
227f5e5176
Replace QStringLiteral with QLatin1String
2024-04-23 16:57:49 +02:00
Jonas Kvinge
92e39a3e21
GlobalShortcut: Use optional
2024-04-23 16:54:54 +02:00
Jonas Kvinge
fb2300e2fa
EBUR128State: Add missing const reference
2024-04-23 16:54:22 +02:00
Jonas Kvinge
78becae5e9
AlbumCoverLoader: Use fully qualified namespace in slot
2024-04-23 16:53:40 +02:00
Jonas Kvinge
d10eb4370e
Player: Use chrono_literals
2024-04-23 16:53:12 +02:00
Jonas Kvinge
9c92ef941f
CollectionModel: Remove redundant const_cast
2024-04-23 16:52:17 +02:00
Jonas Kvinge
7aefe3d71b
Change QList<QString> to QStringList
2024-04-23 16:51:42 +02:00
Jonas Kvinge
398db964b8
Use QDateTime::currentSecsSinceEpoch
2024-04-23 16:48:51 +02:00
Jonas Kvinge
579349b104
ResizableTextEdit: Add Q_OBJECT macro
2024-04-23 16:44:44 +02:00
Jonas Kvinge
5f9a83871d
Playlist: Cast to int
2024-04-23 02:45:27 +02:00
Jonas Kvinge
da0c5e67c5
Playlist: Use optional::has_value
2024-04-23 02:45:11 +02:00
Jonas Kvinge
a0cfde18c3
PlaylistSequence: Use constexpr
2024-04-23 02:44:48 +02:00
Jonas Kvinge
0ad4889936
PlaylistSequence: Remove unused member variable
2024-04-23 02:44:36 +02:00
Jonas Kvinge
36e809d530
InternetPlaylistItem: Cast to int
2024-04-23 02:18:24 +02:00
Jonas Kvinge
78096658e2
Chromaprinter: Remove useless cast
2024-04-23 02:18:08 +02:00
Jonas Kvinge
3edd218e3a
Remove redundant casts
2024-04-23 01:58:08 +02:00
Jonas Kvinge
569bf6335b
CollectionView: Add action_search_for_this_ to initialization list
2024-04-23 01:57:16 +02:00
Jonas Kvinge
7b8919d706
CommandlineOptions: Add const
2024-04-23 01:56:55 +02:00
Jonas Kvinge
147fd87d8c
MainWindow: Only pass progress to UpdateTaskbarProgress
2024-04-23 01:56:30 +02:00
Jonas Kvinge
ac0926d40b
Song: Add ColumnIndex helper function
2024-04-23 01:55:57 +02:00
Jonas Kvinge
105d472f5d
README: Fix badge
2024-04-21 22:35:15 +02:00
Jonas Kvinge
c1a49da385
tests: Use QStringLiteral
2024-04-21 19:37:39 +02:00
Jonas Kvinge
c3f596e64e
CI: Add devel-tools-building repo for Leap
2024-04-21 17:03:06 +02:00
Jonas Kvinge
adfda84c41
nsi: Bump icu from 74 to 75
2024-04-21 16:44:07 +02:00
Jonas Kvinge
345cc118a3
CI: Use different mirror for Mageia
2024-04-21 16:10:26 +02:00
Jonas Kvinge
df070ac0cf
Optimize `Song::InitFromQuery`
...
Use `QSqlQuery::value(int)` or `QSqlRecord::value(int)` instead of `QSqlQuery::value(QString)`.
Make `SqlRow` use `QSqlRecord` directly instead iterating over all columns.
2024-04-21 15:42:29 +02:00
Jonas Kvinge
7b88be2635
CollectionModel: Only set grouping if it's selected
2024-04-21 15:42:29 +02:00
Kientz Arnaud
c30a39d29a
Fix infinitive in french translations
2024-04-16 00:24:59 +02:00
Jonas Kvinge
36db41a1f0
Add sidebar background
2024-04-13 23:47:48 +02:00
Jonas Kvinge
8b249dc06a
QSearchField: Remove NSSearchField workaround
...
This was a workaround for QTBUG-124160.
2024-04-13 05:39:19 +02:00
Jonas Kvinge
0c6872b352
Disable automatic conversions from 8-bit strings
2024-04-13 05:05:33 +02:00
Jonas Kvinge
58944993b8
Use QStringLiteral
2024-04-09 23:20:26 +02:00
Olivier HUMBERT
3cfffa5fbb
Adds French to the menu item
2024-04-07 19:26:23 +02:00
Jonas Kvinge
4873b8b413
CI: Move OpenMandriva if false
2024-04-06 21:24:19 +02:00
Jonas Kvinge
0b85f5192c
CI: Enable Mageia
2024-04-06 21:19:03 +02:00
Jonas Kvinge
3e9a1776a1
CI: Run upload and attach independent of failure
2024-04-06 21:10:10 +02:00
Jonas Kvinge
e1fbe9ae54
Resolve song from collection using track with Cue in XSPF
...
Fixes #1181
2024-04-04 22:22:02 +02:00