Commit Graph

618 Commits

Author SHA1 Message Date
Jonas Kvinge ed09627fdb Use std::make_unique 2021-06-21 15:40:44 +02:00
Jonas Kvinge 589bdf5dcd Use default 2021-06-21 15:40:44 +02:00
Jonas Kvinge 50be44adf8 Add namespace comments 2021-06-20 23:55:02 +02:00
Jonas Kvinge e1bf4347ab Fix uninitialized variables 2021-06-20 23:53:28 +02:00
Jonas Kvinge 3a3305c020 Uppercase literal suffix 2021-06-20 23:49:04 +02:00
Jonas Kvinge 1295033fae Clang-Tidy and Clazy fixes 2021-06-20 19:04:08 +02:00
Jonas Kvinge 755abec636 Use QProcess::startCommand with Qt 6 2021-06-20 02:48:58 +02:00
Jonas Kvinge bee30e572f Fix incorrect use of return 2021-06-20 02:25:36 +02:00
Jonas Kvinge 081df59ed7 Only call QSystemTrayIcon::isSystemTrayAvailable once
Workaround file descriptor leak

Fixes #724
2021-06-15 00:25:54 +02:00
Jonas Kvinge e56defdc50 Formatting 2021-06-13 20:55:37 +02:00
Jonas Kvinge f786a17014 Formatting 2021-06-12 20:53:23 +02:00
Jonas Kvinge 8fd32aba4f Improve resume playback on startup, re-request stream URL when unpausing
Fixes #270
2021-06-10 23:14:05 +02:00
Jonas Kvinge f8ed2afef1 Add song fingerprinting and tracking
Fixes #296
2021-06-05 21:56:40 +02:00
Jonas Kvinge a4a20ec220 Make sure schedule playlist save timer is started from correct thread 2021-06-05 00:07:15 +02:00
Jonas Kvinge 0c5236ebcb Fix crash when no system tray is available 2021-05-29 18:52:47 +02:00
Jonas Kvinge 67f831beba Refactor systemtrayicon code 2021-05-20 21:40:08 +02:00
jonas@jkvinge.net efcd35d4a1 Remove use of X11Extras and WinExtras
Modules are deprecated in Qt 6
See: QTBUG-83251
2021-05-12 23:15:04 +02:00
jonas@jkvinge.net 639ea35921 Use wchar version of GetDiskFreeSpaceEx on Windows Qt 5 2021-05-11 20:32:28 +02:00
jonas@jkvinge.net 4a0a1a32a4 Rename ENABLE_CHROMAPRINT to ENABLE_MUSICBRAINZ 2021-05-10 21:17:50 +02:00
Jonas Kvinge 2625d72818 Don't strip off "Live" from song title 2021-05-01 18:03:26 +02:00
Jonas Kvinge 88562890ae Use int in MainWindow::UpdateTrackSliderPosition 2021-04-26 23:36:59 +02:00
Jonas Kvinge 86c267eb89 Seconds is already qint64 2021-04-26 23:13:37 +02:00
Jonas Kvinge 8c64d3b55c Do most item reloading in the background, schedule playlist saving 2021-04-26 22:57:08 +02:00
Jonas Kvinge 9b60559855 Use QFile::encodeName() in Song::InitFromFilePartial
Fixes #693
2021-04-21 20:11:37 +02:00
Jonas Kvinge 83ad7d4935 Set exit before quit is called 2021-04-16 18:34:38 +02:00
Jonas Kvinge ae2ca175d3 Fix remembering hidden state
Prevent SetHiddenInTray() or Exit() from being called again after
qApp->quit() in MainWindow::closeEvent()
2021-04-16 18:27:24 +02:00
Jonas Kvinge 4c0f7c3dd4 Add commandline option to resize window 2021-04-14 19:50:38 +02:00
Jonas Kvinge efaf917939 Add pragma unused 2021-04-11 19:16:07 +02:00
Jonas Kvinge 7d3ceb7d8c Fix Tidal authentication on macOS 2021-04-11 18:33:35 +02:00
Jonas Kvinge e13c27d32c Allow editing of playlist metadata for streams 2021-04-11 02:01:53 +02:00
Jonas Kvinge c7bc9d471a Allow keep running option on macOS too 2021-04-10 08:22:08 +02:00
Jonas Kvinge 5a58ac2845 Make CollectionQuery subclass QSqlQuery, don't copy QSqlQuery 2021-04-10 03:21:05 +02:00
Jonas Kvinge b5cea4c27e Make enabling FTS3 non-fatal 2021-04-08 22:33:43 +02:00
Jonas Kvinge b7de5d6df3 Only enable FTS3 when schema needs upgrading 2021-04-08 22:13:21 +02:00
Jonas Kvinge bddb371e31 Fix open in file browser when inode/directory mimetype is set to thunar
Fixes #677
2021-04-01 18:31:19 +02:00
Jonas Kvinge a87f0e0475 Also strip variables with uppercase letters in OpenInFileManager() 2021-03-31 23:14:16 +02:00
Jonas Kvinge f63e05b7d4 Use QString::SkipEmptyParts for older Qt versions 2021-03-29 22:45:01 +02:00
Jonas Kvinge 84b7fa02bb Strip all variables from command in OpenInFileManager
Fixes #674
2021-03-29 22:37:55 +02:00
Jonas Kvinge c6604734c9 Remove using std::placeholders 2021-03-26 23:33:56 +01:00
Jonas Kvinge 14fb647647 Fix uninitialized variables 2021-03-26 21:30:13 +01:00
Jonas Kvinge 29cbfe7c1a Change last played to qint64 2021-03-25 23:23:13 +01:00
Jonas Kvinge 6b6117653a Allow audio formats unsupported by taglib to be added
Fixes #669
2021-03-21 19:19:35 +01:00
Jonas Kvinge 59bffed47f Use static_cast 2021-03-21 18:53:02 +01:00
Jonas Kvinge 78588d8cdf Fix various clazy warnings 2021-03-21 04:47:11 +01:00
Jonas Kvinge 54f2aa5f77 Update copyrights 2021-03-20 21:14:47 +01:00
Jonas Kvinge 2695169514 Add type to metadata bundle to avoid updating previous song when it shouldn't 2021-03-13 03:14:30 +01:00
Jonas Kvinge e2cd68e3e8 Fix saving existing cover from file embedded for multiple albums 2021-03-07 07:01:22 +01:00
Jonas Kvinge 89f1f8e6dc Check for empty art automatic 2021-03-07 05:41:49 +01:00
Jonas Kvinge 04bbff338d Fix deleting multiple covers in album cover manager 2021-03-07 03:43:49 +01:00
Jonas Kvinge bbcd6a3261 Fix saving empty cleared cover 2021-03-07 03:42:11 +01:00
Jonas Kvinge 869f8cf380 Enable cover actions based on current cover 2021-03-07 02:34:17 +01:00
Jonas Kvinge 1ff6ba9480 Only enable album cover options for collection songs 2021-03-07 01:49:38 +01:00
Jonas Kvinge 5807bee23b Load album cover controller settings when album cover manager is opened 2021-03-07 00:54:20 +01:00
Jonas Kvinge 32b94555c3 Remove 3rdparty taglib 2021-02-27 16:55:41 +01:00
Jonas Kvinge 133f094d72 Add support for saving embedded album covers
Fixes #286
2021-02-26 21:03:51 +01:00
Jonas Kvinge 193cf1c750 Rename protobuf namespace
Fixes #654
2021-02-20 17:06:55 +01:00
Jonas Kvinge 0ab214fd5d Add methods to tagreader for saving embedded art 2021-02-16 22:50:35 +01:00
Jonas Kvinge 7fc5b70553 Remove const reference from signals 2021-02-10 18:32:10 +01:00
Jonas Kvinge b3681002a7 Change int to qint64 2021-02-10 18:27:40 +01:00
Jonas Kvinge 03959a68d5 Formatting 2021-02-02 21:08:58 +01:00
Jonas Kvinge 98d5e27a8c Remove use of NewClosure for playback resume 2021-01-30 21:52:17 +01:00
Jonas Kvinge 576956fa1d Use QTimer::singleShot directly for database backup 2021-01-30 21:51:32 +01:00
Jonas Kvinge 60528525e0 Use QObject::connect() everywhere for consistency 2021-01-29 18:53:20 +01:00
Jonas Kvinge cb5a7f8c9d Replace NewClosure with lamdas 2021-01-29 18:47:50 +01:00
Jonas Kvinge daff2c1f84 Add option to append explicit to album titles for Tidal 2021-01-28 19:55:28 +01:00
Jonas Kvinge ad5e476920 Fix compile without moodbar
Fixes #638
2021-01-26 22:34:31 +01:00
Jonas Kvinge 2a92ce867a Rename global shortcuts classes 2021-01-26 20:48:51 +01:00
Jonas Kvinge bf7c8df353
Connection syntax migration (#637) 2021-01-26 16:48:04 +01:00
Jonas Kvinge 50d83dc070 Fix memory leak when moodbar is disabled
Only call MoodbarLoader::Load when moodbar is enabled.
2021-01-25 22:35:56 +01:00
Jonas Kvinge 72b194cd7e Rename network to networkaccessmanager 2021-01-11 16:48:46 +01:00
Jonas Kvinge b85819ed9d Decode HTML entities in lyrics 2021-01-11 16:05:39 +01:00
Mikalai Daronin 57709413e1
Add SPMediaKeyTap back (#621) 2021-01-06 14:46:21 +01:00
Jonas Kvinge bfaabafbfa Remove some unused utilities functions 2020-12-29 23:13:22 +01:00
Jonas Kvinge 057ec49a3e Remove hack in MergedProxyModel and use QAbstractProxyModel::modelAboutToBeReset() 2020-12-24 12:33:05 +01:00
Jonas Kvinge e407080057 Remove explicit for song 2020-12-23 20:24:15 +01:00
Jonas Kvinge 47fd30c23f Ignore NSUserNotificationCenter deprecation 2020-12-22 20:37:39 +01:00
Jonas Kvinge 128935b55e Use LPCSTR in RegisterWindowMessageA 2020-12-12 12:51:01 +01:00
Jonas Kvinge d5a0d67c7b Use ScopedWCharArray 2020-12-12 12:50:33 +01:00
Jonas Kvinge 497952611d Fix HTML escaping for custom OSD notifications
Fixes #618
2020-12-11 23:59:38 +01:00
Jonas Kvinge 8ed1ce4103 Move ThreadSafeNetworkDiskCache to own file 2020-12-09 18:41:07 +01:00
Jonas Kvinge d94c6b5aba Set active playlist when playlist doubleclick behaviour is enqueue
Fixes #610
2020-12-04 22:11:35 +01:00
Jonas Kvinge c482e264f4 Rename variable 2020-12-04 19:13:21 +01:00
Nicolas Toussaint 3a9a1f0a94
add CLI play-playlist option, to play given playlist name. (#608)
* add CLI play-playlist option, to play given playlist name.

* Apply MR change requests
2020-12-04 19:08:41 +01:00
Jonas Kvinge 7e6c16b287 Change progress and max progress to qint64 in taskmanager 2020-11-19 18:14:42 +01:00
Jonas Kvinge 042da74955 Change return type of qHash with Qt 6 to size_t 2020-11-17 01:22:38 +01:00
Jonas Kvinge b3b5a38c3a Minor code style fix 2020-11-11 22:55:56 +01:00
Jonas Kvinge 30c336726b Only backup database if schema version is correct 2020-11-09 23:10:43 +01:00
Jonas Kvinge 3821680817 Increase sqlite busy timeout to 30 seconds
Possible fix for #533
2020-11-09 22:49:33 +01:00
Jonas Kvinge 9bbed6e95c Use QClipboard::setText instead of QClipboard::setMimeData
Fixes #581

Fixes clipboard copying on Windows too
2020-11-08 00:51:24 +01:00
yavuzmert 47e2905edf
Re-enable progress on system tray icon (#578)
* Re-enable progress on system tray icon

* fix copy-paste typo in mac sources

* Make tray icon progress optional

* Move tray icon progress setting control to MainWindow

* Move trayicon settings to behavioursettings

Co-authored-by: Yavuz Mert <yavuz.mert@darkbluesystems.net>
2020-11-04 21:01:04 +01:00
Jonas Kvinge 62e0d9fe64 Remove all uses of QTextCodec 2020-11-04 18:16:23 +01:00
Jonas Kvinge 1d6baae6e0 Set ssl-strict false in songloader too 2020-11-03 18:48:35 +01:00
Jonas Kvinge d9d39d8e25 Only override MainWindow::nativeEvent for Windows 2020-10-27 20:17:28 +01:00
Jonas Kvinge a50c978ce3 Fix cancelling logout when window is maxmimized
Fixes #565
2020-10-25 19:59:27 +01:00
Jonas Kvinge f7b36ac4c7 Replace use of QVariant::type() with Qt 6 2020-10-24 03:32:40 +02:00
Jonas Kvinge 2dfa171b6a Save effective_albumartist as empty istead of null
Since we use the metadata now instead of the container keys for queries in
the model, there is a regression when the values are null.
2020-10-20 17:12:28 +02:00
Jonas Kvinge 6b2d7a67d8 Use Utilities::FiddleFileExtension in organize 2020-10-19 19:56:40 +02:00
Jonas Kvinge 0e258a5a32 Remove unused utilities functions 2020-10-18 14:12:01 +02:00
Jonas Kvinge 7ca65c81d8 Use QFileInfo instead of custom functions 2020-10-18 14:07:48 +02:00
Jonas Kvinge 295ac3c458 Add back thumbbar 2020-10-17 21:10:57 +02:00