Commit Graph

271 Commits

Author SHA1 Message Date
Jonas Kvinge 14fb647647 Fix uninitialized variables 2021-03-26 21:30:13 +01:00
Jonas Kvinge 02c30211a7 Call AbstractMessageHandler::AbortAll 2021-03-21 04:37:30 +01:00
Jonas Kvinge 5256d795b1 Fix tagreader process not starting on Windows in release build 2021-03-09 22:45:15 +01:00
Jonas Kvinge 49a0b0bff2 Show info logging when debugging is off 2021-03-04 01:06:02 +01:00
Jonas Kvinge 32b94555c3 Remove 3rdparty taglib 2021-02-27 16:55:41 +01:00
Jonas Kvinge 193cf1c750 Rename protobuf namespace
Fixes #654
2021-02-20 17:06:55 +01:00
Jonas Kvinge 3a7cecac31 Change message reply ID's back to int32
Fixes #653
2021-02-20 16:16:17 +01:00
Jonas Kvinge 0ab214fd5d Add methods to tagreader for saving embedded art 2021-02-16 22:50:35 +01:00
Jonas Kvinge eb603e942f Move semaphore release 2021-02-16 18:53:51 +01:00
Jonas Kvinge b1e1c704b1 Use QTimer::singleShot() to delay signal from MessageReply 2021-02-16 18:50:43 +01:00
Jonas Kvinge 88874f0dcd Remove NewClosure 2021-01-30 21:53:53 +01:00
Jonas Kvinge 477ee14b6d Remove unused waitforsignal class 2021-01-30 16:17:11 +01:00
Jonas Kvinge ebf6ba9ca1 Use new connect syntax in DoAfter() 2021-01-30 14:27:25 +01:00
Jonas Kvinge 1ea8b064cc Read/save vorbis comment grouping tag
Fixes #639
2021-01-28 18:11:49 +01:00
Jonas Kvinge bf7c8df353
Connection syntax migration (#637) 2021-01-26 16:48:04 +01:00
Jonas Kvinge 514becc53a Bundle strawberry-tagreader on macOS using macdeployqt 2020-12-24 22:05:22 +01:00
Jonas Kvinge 1b140535a8 Add worker debug 2020-12-24 20:44:16 +01:00
Jonas Kvinge d56b76c9e3 Save both ID3v1 and ID3v2
Fixes #598
2020-11-23 22:25:47 +01:00
Jonas Kvinge cf4856a0c9 Fix signal not always emitted from messagreply 2020-11-19 18:29:03 +01:00
Jonas Kvinge 1b791c82fc Use qint64 for message request ID 2020-11-19 18:26:50 +01:00
Jonas Kvinge 3a27a3e868 Format code 2020-11-19 18:22:57 +01:00
Jonas Kvinge ee6675aee0 No longer need Core5Compat 2020-11-04 18:17:33 +01:00
Jonas Kvinge 62e0d9fe64 Remove all uses of QTextCodec 2020-11-04 18:16:23 +01:00
Jonas Kvinge 4bccb1ab47 Only save as ID3v2, and remove empty tags
Fixes #571
2020-10-29 18:47:09 +01:00
Jonas Kvinge 23ee17594d Simplify CMake Qt 2020-10-27 20:54:25 +01:00
Jonas Kvinge ffd2e2188a Fix crash with empty APE tag for MPC files 2020-10-21 20:29:06 +02:00
Jonas Kvinge 0e8d5bdc5d Fix crash with empty APE tag for WavPack and APE files 2020-10-21 20:27:43 +02:00
Jonas Kvinge b6693a71f9 Rename initialise to initialize 2020-10-17 17:29:09 +02:00
Jonas Kvinge 246e7018c3 Remove concurrentrun.h 2020-10-14 22:50:19 +02:00
Jonas Kvinge 287f0a3739 Remove redundant check for isNull() 2020-10-02 19:27:47 +02:00
Jonas Kvinge ae6a50626d Change Qt 5/6 option 2020-10-01 19:43:39 +02:00
Jonas Kvinge bba7be99a3 Remove override.h 2020-09-10 23:41:53 +02:00
Jonas Kvinge 71dc47d6c9 Use deleteLater() when destroying lazy initialized objects
Fixes #530
2020-09-04 20:25:46 +02:00
Jonas Kvinge 8e135e3e79 Set compilation for "Various Artists" in album artist tag too 2020-09-03 19:20:11 +02:00
Jonas Kvinge f645099a39 Remove FMPS parser 2020-08-21 22:38:40 +02:00
Jonas Kvinge c315e5016d Change mtime and ctime to qint64 2020-08-13 21:09:06 +02:00
Jonas Kvinge 3ff4885973 Fix reading ASF comment tag 2020-08-03 21:03:14 +02:00
Jonas Kvinge f9d45f7657 Fix reading and saving MP4 lyrics tag 2020-08-03 20:44:25 +02:00
Jonas Kvinge 425dac478e Replace QProcess::error() with QProcess::errorOccurred() 2020-07-18 16:23:39 +02:00
Jonas Kvinge 7af64b0782 Fix QRegularExpressionMatch in FMPSParser 2020-07-18 05:02:34 +02:00
Jonas Kvinge b84c70e811 Link Qt6::Core5Compat in libstrawberry-tagreader 2020-07-18 05:01:54 +02:00
Jonas Kvinge f5b245c72d Add option to compile with Qt 6 2020-07-18 04:47:54 +02:00
Jonas Kvinge cbcc223150 Replace QRegExp with QRegularExpression 2020-07-18 04:21:19 +02:00
Jonas Kvinge f24b6a520c Replace QDateTime::toTime_t() with QDateTime::toSecsSinceEpoch() 2020-07-18 03:53:30 +02:00
Jonas Kvinge 71a1ea481b Replace some uses of static_cast with qobject_cast 2020-07-17 01:32:07 +02:00
Jonas Kvinge 9e32f0d778 Silence some compile warnings with reinterpret cast 2020-07-16 22:46:31 +02:00
Jonas Kvinge 904097b7b1 Add back option to use system taglib, add warning at the bottom 2020-07-07 23:44:04 +02:00
Jonas Kvinge 5f71a558b9 Adapt most changes from taglib2 2020-06-26 23:30:30 +02:00
Jonas Kvinge 837ae2932f Add SYSTEM to system includes in target_include_directories 2020-06-26 23:26:04 +02:00
Jonas Kvinge b51cc21140 Use override 2020-06-26 23:01:57 +02:00
Jonas Kvinge dc36aee7ff Change some explicit usage 2020-06-26 22:41:38 +02:00
Jonas Kvinge 3b58c02db0
Improve CMake files (#460) 2020-06-17 22:56:20 +02:00
Jonas Kvinge 651020388d Use override 2020-06-15 21:55:05 +02:00
Jonas Kvinge 72ede666d4 Replace use of C style casts 2020-06-15 17:59:02 +02:00
Jonas Kvinge a68c249d4e Use parentheses for macro arguments 2020-06-15 00:33:47 +02:00
Jonas Kvinge 56caab4461 Remove redundant initialization 2020-06-15 00:11:52 +02:00
Jonas Kvinge 13b60351a6 Replace use of deprecated C++ headers 2020-06-14 23:54:18 +02:00
Jonas Kvinge 082c9097e4 Fix parameter name mispatches 2020-06-14 18:58:24 +02:00
Jonas Kvinge 2fbdb29ebc Replace 0 with nullptr 2020-06-14 17:02:47 +02:00
Jonas Kvinge 577b7d8ec8 Use lengthInMilliseconds() 2020-06-14 16:08:18 +02:00
Jonas Kvinge c35235371a Replace QString::SkipEmptyParts with Qt::SkipEmptyParts on Qt 5.14.0 or higher 2020-05-29 17:40:11 +02:00
Jonas Kvinge 5d5723ad58 Replace qrand with QRandomGenerator when using Qt 5.10 or higher 2020-05-29 17:37:46 +02:00
Jonas Kvinge ea4dc6f040 Add link directories 2020-04-24 19:48:57 +02:00
Jonas Kvinge e62ab23de2 Add taglib includes 2020-04-24 00:01:23 +02:00
Jonas Kvinge 8da4c88fd3 Fix compile warnings 2020-04-23 21:08:28 +02:00
Jonas Kvinge ac40094d37 Update CMakeLists.txt files 2020-04-23 20:59:09 +02:00
Jonas Kvinge 0213b6556b Add missing memory include 2020-03-08 19:13:13 +01:00
Jonas Kvinge e55d9cafb6 Update logger 2020-03-08 18:40:39 +01:00
Jonas Kvinge 8e0d792bf0 Reduce includes 2020-02-08 03:40:30 +01:00
Daniel Kolesa 814bb3006c
libstrawberry-common: check for library/includes for backtrace() (#364)
This is a non-standard header, so it should be checked properly.
This fixes compilation with musl libc and possibly other C library
implementations.
2020-02-06 20:04:23 +01:00
Jonas Kvinge 2af6fc7452 Add -DTAGLIB_STATIC 2020-01-16 01:40:30 +01:00
Jonas Kvinge 793f6b00e6 Allow 4 tagreader workers 2019-11-27 22:57:51 +01:00
Jonas Kvinge 1b65dcd7df Fix comparison between signed/unsigned 2019-11-15 00:23:06 +01:00
Jonas Kvinge bbad45f1e7 Minor cmake fixes 2019-11-15 00:22:41 +01:00
Jonas Kvinge cf5198ac64 Limit tagreader workers to 2 2019-10-19 15:09:18 +02:00
Jonas Kvinge ab72207027 Change domain 2019-09-24 00:06:37 +02:00
Jonas Kvinge b0a2edf5fa tagreader: remove use of deprecated taglib functions 2019-09-20 18:07:43 +02:00
Jonas Kvinge bdc089290d Add fallthrough comments and remove -Wimplicit-fallthrough=0
Signed-off-by: Jonas Kvinge <jonas@jkvinge.net>
2019-09-16 21:20:12 +02:00
Jonas Kvinge 2d67279180 Fix minor code issues 2019-09-15 20:27:32 +02:00
Jonas Kvinge b5eb13449b Safely close database connections and delete backends
Also fix NewClosure leak caused by disconnected object signals
2019-07-24 19:16:51 +02:00
Jonas Kvinge 2657b80adb Fix memory leak in tagreader 2019-07-21 15:12:28 +02:00
Jonas Kvinge 83d3725240 Fix MessageReply crash in tagreader 2019-07-10 22:40:30 +02:00
Jonas Kvinge 4081bdd752 Fix ctime in tagreader 2019-07-10 20:02:51 +02:00
Jonas Kvinge 4150e3efde Use QT_VERSION to check whether to use QFileInfo::birthTime() or
QFileInfo::created()
2019-07-08 22:54:13 +02:00
Jonas Kvinge c752d28c6a Change QFileInfo::created() to birthTime(), read lyrics from MP3 files 2019-07-08 22:01:34 +02:00
Jonas Kvinge d5ca0ca283 Change compiler flags 2019-07-08 21:59:07 +02:00
Jonas Kvinge 732b37aca0 Use QMap::contains() 2019-07-01 19:20:57 +02:00
Jonas Kvinge 5ef5da687d Fix macOS build 2019-06-12 06:34:59 +02:00
Jonas Kvinge d0135a5ff7 Change namespaces for compatibility 2019-04-26 01:12:42 +02:00
Jonas Kvinge 1c926cca45 Use namespace for static taglib to avoid collision with taglib
linked to vlc
2019-04-25 23:00:25 +02:00
Jonas Kvinge 27bafa8ab2 Fir formatting 2019-04-18 18:28:11 +02:00
Jonas Kvinge 907d18a83a Add moodbar 2019-04-18 15:03:01 +02:00
Jonas Kvinge 368bb54870 Formatting 2019-04-12 19:55:19 +02:00
Jonas Kvinge d1c2188e5c Change compiler flags 2019-04-05 23:09:00 +02:00
Jonas Kvinge 7ae0f5e246 Add better support for APE tags 2019-03-22 23:13:49 +01:00
Jonas Kvinge 954e0e8a59
Add translations support (#82)
* Add translations support
* Update .gitignore
2019-02-22 20:24:38 +01:00
Jonas Kvinge 55f610f3b2 Fix formatting 2019-02-20 21:29:14 +01:00
Jonas Kvinge 2db77a248a Fix formatting 2019-02-20 21:27:04 +01:00
Jonas Kvinge f600274592 Replace NULL with nullptr 2019-02-20 21:26:14 +01:00
Jonas Kvinge 3c068eaba9 Remove support for older taglib in tagreader 2019-02-02 12:39:11 +01:00
Jonas Kvinge a11f43520e Add support for Monkey's Audio 2019-01-06 00:32:58 +01:00
Jonas Kvinge 7d8ba57e5f Fix bundle dir for macOS 2019-01-03 23:18:39 +01:00
Jonas Kvinge c5a521af1f Fix logging 2018-11-17 03:27:46 +01:00
Jonas Kvinge 0f4ffe4fce Add PCM as filetype 2018-10-23 20:21:01 +02:00
Jonas Kvinge db035351be Remove whitespaces 2018-10-02 00:38:52 +02:00
Jonas Kvinge 827898cd38 Fix taglib includes 2018-09-30 22:32:56 +02:00
Jonas Kvinge 6d686ee66a Add source to songs and playlist_items 2018-09-08 12:38:02 +02:00
Jonas Kvinge 0abeefd470 Fixed saving (APE) tags for WavPack files 2018-09-06 20:49:05 +02:00
Jonas Kvinge 1562585561 Added support for reading lyrics from tags
Also fixed tagreader crash when saving tags to MP3 files
2018-09-06 20:04:29 +02:00
Jonas Kvinge ee78b6f2bb Add DSF and DSDIFF/DFF support 2018-09-02 01:40:14 +02:00
Jonas Kvinge ab3569a285 More macos fixes 2018-07-03 17:51:52 +02:00
Jonas Kvinge ada7325a04 Fix macos build 2018-07-01 22:26:46 +02:00
Jonas Kvinge c4e75dea65 Fix macos build 2018-07-01 22:24:23 +02:00
Jonas Kvinge 985b91e5f4 Fix setting output/device for Xine and VLC backend
- Fixed setting output and device on Xine and VLC backend
- Fixed track slider for Xine, VLC and Phonon
- Improved backend settings to better support multiple backends
- Added group by samplerate and bitdepth in collection
- Fixed crash on exit when existing instance of the application is already runnung caused by NVIDIA driver
- Changed Q_OS_MAC to Q_OS_MACOS
2018-06-28 01:15:32 +02:00
Jonas Kvinge 54c2ad13a9 Change to target_link_libraries in makefiles 2018-05-12 20:30:16 +02:00
Jonas Kvinge 5392cc4109 Audio file detection by content 2018-05-10 15:29:28 +02:00
Jonas Kvinge 388fce358a Fix musicbrainz tag fetcher 2018-05-01 13:46:10 +02:00
Jonas Kvinge ad2b567216 Fix playback of WavPack 2018-05-01 13:34:32 +02:00
Jonas Kvinge e337b7933b Includes, comments and bugfixes
- Fix includes
- Use common regex (Song::kCoverRemoveDisc) for removing Disc/CD from album
- Remove Disc/CD from album when creating hash
- Make imobiledevice support compile
- Fix setting device on windows
2018-05-01 00:41:33 +02:00
Jonas Kvinge 8d5abef57a Add version. 2018-03-31 16:24:28 +02:00
Jonas Kvinge b2b1ba7abe Initial commit. 2018-02-27 18:06:05 +01:00