Commit Graph

275 Commits

Author SHA1 Message Date
Jonas Kvinge af0c6f9233 Logging: Use `stdout` unless critical or fatal, and flush stream 2021-10-31 13:18:26 +01:00
Jonas Kvinge 7697bbfa4e Logging: Formatting 2021-10-31 13:18:26 +01:00
Jonas Kvinge 5eae3ddd8a Use `float` for rating 2021-10-30 18:53:14 +02:00
Jonas Kvinge 3d0b6e6ea1 TagReader: Check for valid file times
Fixes #815
2021-10-30 17:57:13 +02:00
Jonas Kvinge 79ac53b2d9 Fix narrowing conversions 2021-10-30 02:21:29 +02:00
Jonas Kvinge 377e6fad25 gstmoodbar: Formatting 2021-10-30 00:48:58 +02:00
Jonas Kvinge 5cb88efc38 Remove debug line 2021-10-26 23:54:27 +02:00
Jonas Kvinge 6b64c43851 TagReaderTagLib: Read FMPS_Rating for MPEG ID3v2 tag 2021-10-26 01:10:01 +02:00
Jonas Kvinge 704e6c5448 TagReaderTagLib: Use double for ratings to match Song 2021-10-26 00:24:03 +02:00
Jonas Kvinge 072d7379df TagReaderTagLib: Add checks for nullptr 2021-10-26 00:02:36 +02:00
Jonas Kvinge 3ab86543ad Add support for saving playcounts and ratings to tags 2021-10-24 16:08:17 +02:00
Jonas Kvinge ec17dc9830 TagReaderClient: Sort functions 2021-10-18 23:15:50 +02:00
Jonas Kvinge 5945d0ebee Read rating from tags
Fixes #790
2021-10-16 23:33:03 +02:00
Jonas Kvinge 6d7a01fb4e Logging: Remove custom debug level for gst pipeline 2021-10-16 21:25:36 +02:00
Jonas Kvinge a6569d09ac Read XM and IT module music 2021-10-12 21:43:46 +02:00
Jonas Kvinge 92f6a0c6c8 Add mod and s3m to filetypes 2021-09-26 16:23:02 +02:00
EmmanuelMess 68c44daef2 Fix SingleApplication static functions called from instance 2021-09-10 18:44:36 +02:00
Jonas Kvinge 24a3ac9811 Use static QMetaObject::invokeMethod 2021-09-09 21:53:14 +02:00
Jonas Kvinge 49ccbddb17 Add Q_DISABLE_COPY 2021-08-25 02:56:30 +02:00
Jonas Kvinge be3c7eef60 Use default 2021-08-25 02:55:54 +02:00
Jonas Kvinge d02241d32c Fix compile with MSVC 2021-08-24 21:49:06 +02:00
Jonas Kvinge ea2bfbda44 Formatting 2021-08-23 21:21:08 +02:00
Jonas Kvinge c076933b52 Use FREEBSD variable 2021-08-22 23:22:15 +02:00
Jonas Kvinge cf2a0af3d9 Fix macdeploycheck link directories 2021-08-19 20:24:11 +02:00
Jonas Kvinge 9cc995cb52 Add macdeploycheck 2021-08-19 19:17:43 +02:00
Jonas Kvinge 6ede400f3a CMakeLists.txt formatting 2021-08-07 03:02:36 +02:00
Jonas Kvinge 7ce922b084 Simplify CMake by using macros 2021-07-30 21:17:50 +02:00
Jonas Kvinge f144c982e3 Minor CMakeLists.txt cleanup 2021-07-21 17:45:22 +02:00
Jonas Kvinge 16625b1dc7 Move some files from ext to src 2021-07-21 17:29:16 +02:00
Jonas Kvinge 2cb8fa62df Remove duplicate TAGLIB_LIBRARY_DIRS 2021-07-18 16:38:20 +02:00
Jonas Kvinge 68dbc29f2c Use QString::compare with Qt::CaseInsensitive to reduce allocations 2021-07-13 23:18:12 +02:00
Jonas Kvinge f02741284c Tagparser: Fix reading and writing year/originalyear 2021-07-12 07:54:01 +02:00
Jonas Kvinge af29acf462 tagparser: Save release and record date 2021-07-12 07:32:41 +02:00
Jonas Kvinge b47f29e87c tagparser: Parse tracks when saving 2021-07-12 07:32:17 +02:00
Jonas Kvinge e48b7d83a3 Formatting 2021-07-11 09:49:38 +02:00
Jonas Kvinge 9b9a32b053 tagparser: Fix opening file readonly 2021-07-11 04:36:44 +02:00
Jonas Kvinge f36997c7c5 Close MediaFileInfo 2021-07-02 01:39:21 +02:00
Jonas Kvinge b1640d3626 Remove tagparser/abstractattachment.h include 2021-07-02 01:38:56 +02:00
Jonas Kvinge 825c62c62b Fix typo in TagReaderTagLib constructor and destructor 2021-07-02 01:26:48 +02:00
Jonas Kvinge a4b0c6f37d Remove unused QVector include 2021-07-02 01:26:32 +02:00
Jonas Kvinge 239b88aa3b Add support for TagParser as an alternative to TagLib 2021-07-02 01:16:46 +02:00
Jonas Kvinge b071ecb45e Formatting 2021-06-22 14:04:42 +02:00
Jonas Kvinge 584f5e5935 Change bool/int condition 2021-06-22 14:04:42 +02:00
Jonas Kvinge 589bdf5dcd Use default 2021-06-21 15:40:44 +02:00
Jonas Kvinge 1295033fae Clang-Tidy and Clazy fixes 2021-06-20 19:04:08 +02:00
Jonas Kvinge 141957e4b5 Remove godaddy certificate 2021-06-12 19:14:47 +02:00
Jonas Kvinge 0caf76dfae Remove unneeded includes 2021-06-12 16:06:41 +02:00
Jonas Kvinge f8ed2afef1 Add song fingerprinting and tracking
Fixes #296
2021-06-05 21:56:40 +02:00
Jonas Kvinge 171db01401 Set default for original year 2021-05-31 19:07:55 +02:00
Jonas Kvinge a36b91ffe8 Cast to quint32 2021-04-10 08:21:58 +02:00
Jonas Kvinge 88da0db0f7 Update copyrights 2021-04-10 07:32:38 +02:00
Jonas Kvinge 816c2b0ca8 Use qint32 for unique worker number 2021-04-10 07:20:36 +02:00
Jonas Kvinge d6ff68339b Use qint64 for unique worker number 2021-04-10 07:02:08 +02:00
Jonas Kvinge cabb94b856 Move taglib include dir to system include dirs 2021-04-05 22:25:52 +02:00
Jonas Kvinge 14fb647647 Fix uninitialized variables 2021-03-26 21:30:13 +01:00
Jonas Kvinge 02c30211a7 Call AbstractMessageHandler::AbortAll 2021-03-21 04:37:30 +01:00
Jonas Kvinge 5256d795b1 Fix tagreader process not starting on Windows in release build 2021-03-09 22:45:15 +01:00
Jonas Kvinge 49a0b0bff2 Show info logging when debugging is off 2021-03-04 01:06:02 +01:00
Jonas Kvinge 32b94555c3 Remove 3rdparty taglib 2021-02-27 16:55:41 +01:00
Jonas Kvinge 193cf1c750 Rename protobuf namespace
Fixes #654
2021-02-20 17:06:55 +01:00
Jonas Kvinge 3a7cecac31 Change message reply ID's back to int32
Fixes #653
2021-02-20 16:16:17 +01:00
Jonas Kvinge 0ab214fd5d Add methods to tagreader for saving embedded art 2021-02-16 22:50:35 +01:00
Jonas Kvinge eb603e942f Move semaphore release 2021-02-16 18:53:51 +01:00
Jonas Kvinge b1e1c704b1 Use QTimer::singleShot() to delay signal from MessageReply 2021-02-16 18:50:43 +01:00
Jonas Kvinge 88874f0dcd Remove NewClosure 2021-01-30 21:53:53 +01:00
Jonas Kvinge 477ee14b6d Remove unused waitforsignal class 2021-01-30 16:17:11 +01:00
Jonas Kvinge ebf6ba9ca1 Use new connect syntax in DoAfter() 2021-01-30 14:27:25 +01:00
Jonas Kvinge 1ea8b064cc Read/save vorbis comment grouping tag
Fixes #639
2021-01-28 18:11:49 +01:00
Jonas Kvinge bf7c8df353
Connection syntax migration (#637) 2021-01-26 16:48:04 +01:00
Jonas Kvinge 514becc53a Bundle strawberry-tagreader on macOS using macdeployqt 2020-12-24 22:05:22 +01:00
Jonas Kvinge 1b140535a8 Add worker debug 2020-12-24 20:44:16 +01:00
Jonas Kvinge d56b76c9e3 Save both ID3v1 and ID3v2
Fixes #598
2020-11-23 22:25:47 +01:00
Jonas Kvinge cf4856a0c9 Fix signal not always emitted from messagreply 2020-11-19 18:29:03 +01:00
Jonas Kvinge 1b791c82fc Use qint64 for message request ID 2020-11-19 18:26:50 +01:00
Jonas Kvinge 3a27a3e868 Format code 2020-11-19 18:22:57 +01:00
Jonas Kvinge ee6675aee0 No longer need Core5Compat 2020-11-04 18:17:33 +01:00
Jonas Kvinge 62e0d9fe64 Remove all uses of QTextCodec 2020-11-04 18:16:23 +01:00
Jonas Kvinge 4bccb1ab47 Only save as ID3v2, and remove empty tags
Fixes #571
2020-10-29 18:47:09 +01:00
Jonas Kvinge 23ee17594d Simplify CMake Qt 2020-10-27 20:54:25 +01:00
Jonas Kvinge ffd2e2188a Fix crash with empty APE tag for MPC files 2020-10-21 20:29:06 +02:00
Jonas Kvinge 0e8d5bdc5d Fix crash with empty APE tag for WavPack and APE files 2020-10-21 20:27:43 +02:00
Jonas Kvinge b6693a71f9 Rename initialise to initialize 2020-10-17 17:29:09 +02:00
Jonas Kvinge 246e7018c3 Remove concurrentrun.h 2020-10-14 22:50:19 +02:00
Jonas Kvinge 287f0a3739 Remove redundant check for isNull() 2020-10-02 19:27:47 +02:00
Jonas Kvinge ae6a50626d Change Qt 5/6 option 2020-10-01 19:43:39 +02:00
Jonas Kvinge bba7be99a3 Remove override.h 2020-09-10 23:41:53 +02:00
Jonas Kvinge 71dc47d6c9 Use deleteLater() when destroying lazy initialized objects
Fixes #530
2020-09-04 20:25:46 +02:00
Jonas Kvinge 8e135e3e79 Set compilation for "Various Artists" in album artist tag too 2020-09-03 19:20:11 +02:00
Jonas Kvinge f645099a39 Remove FMPS parser 2020-08-21 22:38:40 +02:00
Jonas Kvinge c315e5016d Change mtime and ctime to qint64 2020-08-13 21:09:06 +02:00
Jonas Kvinge 3ff4885973 Fix reading ASF comment tag 2020-08-03 21:03:14 +02:00
Jonas Kvinge f9d45f7657 Fix reading and saving MP4 lyrics tag 2020-08-03 20:44:25 +02:00
Jonas Kvinge 425dac478e Replace QProcess::error() with QProcess::errorOccurred() 2020-07-18 16:23:39 +02:00
Jonas Kvinge 7af64b0782 Fix QRegularExpressionMatch in FMPSParser 2020-07-18 05:02:34 +02:00
Jonas Kvinge b84c70e811 Link Qt6::Core5Compat in libstrawberry-tagreader 2020-07-18 05:01:54 +02:00
Jonas Kvinge f5b245c72d Add option to compile with Qt 6 2020-07-18 04:47:54 +02:00
Jonas Kvinge cbcc223150 Replace QRegExp with QRegularExpression 2020-07-18 04:21:19 +02:00
Jonas Kvinge f24b6a520c Replace QDateTime::toTime_t() with QDateTime::toSecsSinceEpoch() 2020-07-18 03:53:30 +02:00
Jonas Kvinge 71a1ea481b Replace some uses of static_cast with qobject_cast 2020-07-17 01:32:07 +02:00
Jonas Kvinge 9e32f0d778 Silence some compile warnings with reinterpret cast 2020-07-16 22:46:31 +02:00
Jonas Kvinge 904097b7b1 Add back option to use system taglib, add warning at the bottom 2020-07-07 23:44:04 +02:00
Jonas Kvinge 5f71a558b9 Adapt most changes from taglib2 2020-06-26 23:30:30 +02:00
Jonas Kvinge 837ae2932f Add SYSTEM to system includes in target_include_directories 2020-06-26 23:26:04 +02:00
Jonas Kvinge b51cc21140 Use override 2020-06-26 23:01:57 +02:00
Jonas Kvinge dc36aee7ff Change some explicit usage 2020-06-26 22:41:38 +02:00
Jonas Kvinge 3b58c02db0
Improve CMake files (#460) 2020-06-17 22:56:20 +02:00
Jonas Kvinge 651020388d Use override 2020-06-15 21:55:05 +02:00
Jonas Kvinge 72ede666d4 Replace use of C style casts 2020-06-15 17:59:02 +02:00
Jonas Kvinge a68c249d4e Use parentheses for macro arguments 2020-06-15 00:33:47 +02:00
Jonas Kvinge 56caab4461 Remove redundant initialization 2020-06-15 00:11:52 +02:00
Jonas Kvinge 13b60351a6 Replace use of deprecated C++ headers 2020-06-14 23:54:18 +02:00
Jonas Kvinge 082c9097e4 Fix parameter name mispatches 2020-06-14 18:58:24 +02:00
Jonas Kvinge 2fbdb29ebc Replace 0 with nullptr 2020-06-14 17:02:47 +02:00
Jonas Kvinge 577b7d8ec8 Use lengthInMilliseconds() 2020-06-14 16:08:18 +02:00
Jonas Kvinge c35235371a Replace QString::SkipEmptyParts with Qt::SkipEmptyParts on Qt 5.14.0 or higher 2020-05-29 17:40:11 +02:00
Jonas Kvinge 5d5723ad58 Replace qrand with QRandomGenerator when using Qt 5.10 or higher 2020-05-29 17:37:46 +02:00
Jonas Kvinge ea4dc6f040 Add link directories 2020-04-24 19:48:57 +02:00
Jonas Kvinge e62ab23de2 Add taglib includes 2020-04-24 00:01:23 +02:00
Jonas Kvinge 8da4c88fd3 Fix compile warnings 2020-04-23 21:08:28 +02:00
Jonas Kvinge ac40094d37 Update CMakeLists.txt files 2020-04-23 20:59:09 +02:00
Jonas Kvinge 0213b6556b Add missing memory include 2020-03-08 19:13:13 +01:00
Jonas Kvinge e55d9cafb6 Update logger 2020-03-08 18:40:39 +01:00
Jonas Kvinge 8e0d792bf0 Reduce includes 2020-02-08 03:40:30 +01:00
Daniel Kolesa 814bb3006c
libstrawberry-common: check for library/includes for backtrace() (#364)
This is a non-standard header, so it should be checked properly.
This fixes compilation with musl libc and possibly other C library
implementations.
2020-02-06 20:04:23 +01:00
Jonas Kvinge 2af6fc7452 Add -DTAGLIB_STATIC 2020-01-16 01:40:30 +01:00
Jonas Kvinge 793f6b00e6 Allow 4 tagreader workers 2019-11-27 22:57:51 +01:00
Jonas Kvinge 1b65dcd7df Fix comparison between signed/unsigned 2019-11-15 00:23:06 +01:00
Jonas Kvinge bbad45f1e7 Minor cmake fixes 2019-11-15 00:22:41 +01:00
Jonas Kvinge cf5198ac64 Limit tagreader workers to 2 2019-10-19 15:09:18 +02:00
Jonas Kvinge ab72207027 Change domain 2019-09-24 00:06:37 +02:00
Jonas Kvinge b0a2edf5fa tagreader: remove use of deprecated taglib functions 2019-09-20 18:07:43 +02:00
Jonas Kvinge bdc089290d Add fallthrough comments and remove -Wimplicit-fallthrough=0
Signed-off-by: Jonas Kvinge <jonas@jkvinge.net>
2019-09-16 21:20:12 +02:00
Jonas Kvinge 2d67279180 Fix minor code issues 2019-09-15 20:27:32 +02:00
Jonas Kvinge b5eb13449b Safely close database connections and delete backends
Also fix NewClosure leak caused by disconnected object signals
2019-07-24 19:16:51 +02:00
Jonas Kvinge 2657b80adb Fix memory leak in tagreader 2019-07-21 15:12:28 +02:00
Jonas Kvinge 83d3725240 Fix MessageReply crash in tagreader 2019-07-10 22:40:30 +02:00
Jonas Kvinge 4081bdd752 Fix ctime in tagreader 2019-07-10 20:02:51 +02:00
Jonas Kvinge 4150e3efde Use QT_VERSION to check whether to use QFileInfo::birthTime() or
QFileInfo::created()
2019-07-08 22:54:13 +02:00
Jonas Kvinge c752d28c6a Change QFileInfo::created() to birthTime(), read lyrics from MP3 files 2019-07-08 22:01:34 +02:00
Jonas Kvinge d5ca0ca283 Change compiler flags 2019-07-08 21:59:07 +02:00
Jonas Kvinge 732b37aca0 Use QMap::contains() 2019-07-01 19:20:57 +02:00
Jonas Kvinge 5ef5da687d Fix macOS build 2019-06-12 06:34:59 +02:00
Jonas Kvinge d0135a5ff7 Change namespaces for compatibility 2019-04-26 01:12:42 +02:00
Jonas Kvinge 1c926cca45 Use namespace for static taglib to avoid collision with taglib
linked to vlc
2019-04-25 23:00:25 +02:00
Jonas Kvinge 27bafa8ab2 Fir formatting 2019-04-18 18:28:11 +02:00
Jonas Kvinge 907d18a83a Add moodbar 2019-04-18 15:03:01 +02:00
Jonas Kvinge 368bb54870 Formatting 2019-04-12 19:55:19 +02:00
Jonas Kvinge d1c2188e5c Change compiler flags 2019-04-05 23:09:00 +02:00
Jonas Kvinge 7ae0f5e246 Add better support for APE tags 2019-03-22 23:13:49 +01:00
Jonas Kvinge 954e0e8a59
Add translations support (#82)
* Add translations support
* Update .gitignore
2019-02-22 20:24:38 +01:00