Jonas Kvinge
388dcf2a1f
Fix dtor compile warnings with Clang
2024-07-30 16:34:20 +02:00
Jonas Kvinge
160356072f
TagReaderTagLib: Add missing override
2024-07-28 02:35:35 +02:00
Jonas Kvinge
9232ad0125
TagReaderTagLib: Use QString for converting TagLib::String
...
Converting directly to std::string does not seem to work correctly.
2024-07-09 15:56:07 +02:00
Jonas Kvinge
0de87b3e1e
TagReaderTagLib: Use UTF-8 when converting to CString
...
Fixes #1481
2024-07-09 15:06:07 +02:00
Jonas Kvinge
d956ae9726
TagReaderTagLib: Add consts for all fields, add more support for ASF
2024-07-05 21:26:28 +02:00
Jonas Kvinge
0435d6d7b9
TagReader: Cleanup string functions
2024-07-05 16:21:50 +02:00
Jonas Kvinge
0d9ededea9
tagreadermessages: Switch back to proto2
2024-07-01 17:39:42 +02:00
Jonas Kvinge
32baa95500
Add better error handling for Tag reader
2024-07-01 02:06:42 +02:00
Jonas Kvinge
5451c110b1
Replace QStringLiteral with QLatin1String
2024-06-12 20:30:36 +02:00
Jonas Kvinge
b233600b8c
Remove useless else
2024-06-12 17:38:58 +02:00
Jonas Kvinge
f1f79fb961
Move default constructor to header
2024-06-12 17:30:40 +02:00
Robert Gingras
e8be0adf37
TagReaderTagLib: Remove redundant ID3v2 validity check
...
TagLib will have created a valid ID3v2 tag on this file by this point in the code, due to the way it handles the tag() method for WAV::File. Thus the null pointer check is redundant and the hasID3v2() call is at best redundant and at worst will cause tags to not save when they otherwise should have
2024-04-24 01:23:51 +02:00
Robert Gingras
9f4a82bb62
TagReaderTagLib: Remove file_mpeg argument from the SetEmbeddedArt ID3v2 overload
2024-04-24 01:23:51 +02:00
Robert Gingras
d03d3622aa
TagReaderTagLib: Have RIFF WAV files save ID3v2 tags, when applicable
2024-04-24 01:23:51 +02:00
Robert Gingras
821c32992d
TagReaderTagLib: Refactor ID3v2 saving to a dedicated function
2024-04-24 01:23:51 +02:00
Robert Gingras
b52cf9f3cd
TagReaderTagLib: Reposition ParseID3v2Tag
2024-04-24 01:23:51 +02:00
Robert Gingras
ab8e687f96
TagReaderTagLib: Add id3v2 parsing for RIFF WAV files
2024-04-24 01:23:51 +02:00
Robert Gingras
90703703aa
TagReaderTagLib: Make id3v2 parsing reusable
2024-04-24 01:23:51 +02:00
Jonas Kvinge
398db964b8
Use QDateTime::currentSecsSinceEpoch
2024-04-23 16:48:51 +02:00
Jonas Kvinge
0c6872b352
Disable automatic conversions from 8-bit strings
2024-04-13 05:05:33 +02:00
Jonas Kvinge
58944993b8
Use QStringLiteral
2024-04-09 23:20:26 +02:00
Jonas Kvinge
002fa8f4aa
Fix mismatched definition
2023-10-13 22:49:20 +02:00
Jonas Kvinge
e201f71a74
CMake: Simplify Qt detection
2023-09-16 14:55:42 +02:00
Jonas Kvinge
d1a6e53f5c
TagReaderTagLib: Read FMPS_Playcount
...
Fixes #1248
2023-07-29 18:33:50 +02:00
Jonas Kvinge
d3352e476f
Remove `< 0` check on unsigned
2023-07-21 07:17:58 +02:00
Jonas Kvinge
bb6daca735
GME: Add static_cast to silence warnings
2023-07-12 16:22:02 +02:00
Jonas Kvinge
7616c06ff9
Use `find_package(Protobuf CONFIG)` for macOS too
2023-07-12 01:25:41 +02:00
Jonas Kvinge
3bcea249ac
TagReaderTagLib: Initialize cover_format
2023-06-06 23:19:25 +02:00
Jonas Kvinge
8ee32dfa88
Add static_cast to silence narrowing conversion warnings
2023-06-06 23:18:49 +02:00
Jonas Kvinge
331aa382f9
Rewrite album cover loader
2023-06-06 20:41:01 +02:00
Jonas Kvinge
b52ffd09b2
Use find_package Protobuf CONFIG
2023-05-14 23:54:36 +02:00
Jonas Kvinge
58278ab1e4
Replace protobuf_generate_cpp with protobuf_generate
2023-05-14 20:07:36 +02:00
Jonas Kvinge
f8d2c7eba3
Bump required Qt version to 5.12
2023-05-03 20:50:58 +02:00
Jonas Kvinge
2b9e7db924
TagReaderTagLib: Touch file over saving cover art
2023-03-26 22:37:21 +02:00
Jonas Kvinge
49384ce294
TagReaderTagLib: Fix reading MusicBrainz from ID3v2 tags
2023-03-26 04:33:15 +02:00
Jonas Kvinge
ac59fff346
TagReaderTagLib: Formatting
2023-03-26 04:14:03 +02:00
Jonas Kvinge
aedbd52e9d
Add AcoustID
2023-03-24 22:48:22 +01:00
Jonas Kvinge
faf4c817cd
TagReaderTagLib: Read AcoustID fingerprint
2023-03-24 20:54:05 +01:00
Jonas Kvinge
b4e1f283c9
tagreadermessages: Add AcoustID fingerprint tags to protobuf
2023-03-24 19:52:45 +01:00
Jonas Kvinge
a35146440c
TagReaderTagLib: Read MusicBrainz tags
2023-03-19 21:55:26 +01:00
Jonas Kvinge
8e79fafca9
tagreadermessages: Add MusicBrainz tags to protobuf
2023-03-19 21:50:54 +01:00
Jonas Kvinge
6f8780d3cc
TagReaderGME: Add header guard comment
2023-03-19 21:29:45 +01:00
Jonas Kvinge
264065a355
TagreaderGME: Don't call QByteArray::operator[]() on temporary
2023-03-19 20:42:30 +01:00
Jonas Kvinge
b606e4cd1a
TagReaderTagLib: Rename Decode to TStringToStdString
2023-03-19 20:35:47 +01:00
Jonas Kvinge
702851a958
TagReaderTagLib: Use constexpr
2023-03-19 19:34:05 +01:00
Jonas Kvinge
650f200a0b
TagReaderBase: Remove unused Decode function
2023-03-19 19:33:34 +01:00
Jonas Kvinge
e20cbe4170
Save embedded cover in the same process as tags
...
Possible fix for #1158
2023-03-18 20:03:07 +01:00
Jonas Kvinge
981d46fbd4
Link abseil_dll for MSVC
2023-03-09 16:14:32 +01:00
Jonas Kvinge
d8682b4403
Workaround absl linking errors on Windows with protobuf 3.22
2023-03-08 18:57:52 +01:00
Jonas Kvinge
40a4bf195a
Link with Protobuf_LIBRARIES
2023-03-08 18:56:15 +01:00