e8be0adf37
TagReaderTagLib: Remove redundant ID3v2 validity check
...
TagLib will have created a valid ID3v2 tag on this file by this point in the code, due to the way it handles the tag() method for WAV::File. Thus the null pointer check is redundant and the hasID3v2() call is at best redundant and at worst will cause tags to not save when they otherwise should have
2024-04-24 01:23:51 +02:00
9f4a82bb62
TagReaderTagLib: Remove file_mpeg argument from the SetEmbeddedArt ID3v2 overload
2024-04-24 01:23:51 +02:00
d03d3622aa
TagReaderTagLib: Have RIFF WAV files save ID3v2 tags, when applicable
2024-04-24 01:23:51 +02:00
821c32992d
TagReaderTagLib: Refactor ID3v2 saving to a dedicated function
2024-04-24 01:23:51 +02:00
b52cf9f3cd
TagReaderTagLib: Reposition ParseID3v2Tag
2024-04-24 01:23:51 +02:00
ab8e687f96
TagReaderTagLib: Add id3v2 parsing for RIFF WAV files
2024-04-24 01:23:51 +02:00
90703703aa
TagReaderTagLib: Make id3v2 parsing reusable
2024-04-24 01:23:51 +02:00
426de61525
Add const and std::as_const
2024-04-23 17:15:42 +02:00
398db964b8
Use QDateTime::currentSecsSinceEpoch
2024-04-23 16:48:51 +02:00
3edd218e3a
Remove redundant casts
2024-04-23 01:58:08 +02:00
0c6872b352
Disable automatic conversions from 8-bit strings
2024-04-13 05:05:33 +02:00
58944993b8
Use QStringLiteral
2024-04-09 23:20:26 +02:00
71a6d378d9
workerpool: Always search plugin path for tagreader on macOS
2023-10-14 03:27:32 +02:00
002fa8f4aa
Fix mismatched definition
2023-10-13 22:49:20 +02:00
e201f71a74
CMake: Simplify Qt detection
2023-09-16 14:55:42 +02:00
d61d4d0a74
macdeploycheck: Use static `QFile::exists`
2023-09-06 22:59:16 +02:00
4033cd61c2
logging: Ignore -Wold-style-cast for glib.h
2023-09-05 23:42:56 +02:00
d1a6e53f5c
TagReaderTagLib: Read FMPS_Playcount
...
Fixes #1248
2023-07-29 18:33:50 +02:00
d3352e476f
Remove `< 0` check on unsigned
2023-07-21 07:17:58 +02:00
bb6daca735
GME: Add static_cast to silence warnings
2023-07-12 16:22:02 +02:00
7616c06ff9
Use `find_package(Protobuf CONFIG)` for macOS too
2023-07-12 01:25:41 +02:00
f467331934
Add ifdefs around #pragma GCC diagnostic
2023-06-15 20:10:25 +02:00
3bcea249ac
TagReaderTagLib: Initialize cover_format
2023-06-06 23:19:25 +02:00
8ee32dfa88
Add static_cast to silence narrowing conversion warnings
2023-06-06 23:18:49 +02:00
331aa382f9
Rewrite album cover loader
2023-06-06 20:41:01 +02:00
b52ffd09b2
Use find_package Protobuf CONFIG
2023-05-14 23:54:36 +02:00
58278ab1e4
Replace protobuf_generate_cpp with protobuf_generate
2023-05-14 20:07:36 +02:00
f8d2c7eba3
Bump required Qt version to 5.12
2023-05-03 20:50:58 +02:00
e511b2faf9
Use new connect syntax for QMetaObject::invokeMethod
2023-05-03 20:08:51 +02:00
2b9e7db924
TagReaderTagLib: Touch file over saving cover art
2023-03-26 22:37:21 +02:00
49384ce294
TagReaderTagLib: Fix reading MusicBrainz from ID3v2 tags
2023-03-26 04:33:15 +02:00
ac59fff346
TagReaderTagLib: Formatting
2023-03-26 04:14:03 +02:00
c3ee3318d7
WorkerPool: Default to 1 worker
2023-03-26 00:08:23 +01:00
aedbd52e9d
Add AcoustID
2023-03-24 22:48:22 +01:00
faf4c817cd
TagReaderTagLib: Read AcoustID fingerprint
2023-03-24 20:54:05 +01:00
b4e1f283c9
tagreadermessages: Add AcoustID fingerprint tags to protobuf
2023-03-24 19:52:45 +01:00
a35146440c
TagReaderTagLib: Read MusicBrainz tags
2023-03-19 21:55:26 +01:00
8e79fafca9
tagreadermessages: Add MusicBrainz tags to protobuf
2023-03-19 21:50:54 +01:00
6f8780d3cc
TagReaderGME: Add header guard comment
2023-03-19 21:29:45 +01:00
264065a355
TagreaderGME: Don't call QByteArray::operator[]() on temporary
2023-03-19 20:42:30 +01:00
b606e4cd1a
TagReaderTagLib: Rename Decode to TStringToStdString
2023-03-19 20:35:47 +01:00
702851a958
TagReaderTagLib: Use constexpr
2023-03-19 19:34:05 +01:00
650f200a0b
TagReaderBase: Remove unused Decode function
2023-03-19 19:33:34 +01:00
e20cbe4170
Save embedded cover in the same process as tags
...
Possible fix for #1158
2023-03-18 20:03:07 +01:00
981d46fbd4
Link abseil_dll for MSVC
2023-03-09 16:14:32 +01:00
d8682b4403
Workaround absl linking errors on Windows with protobuf 3.22
2023-03-08 18:57:52 +01:00
40a4bf195a
Link with Protobuf_LIBRARIES
2023-03-08 18:56:15 +01:00
dd72fb4ca5
Use C++11 enum class
2023-02-18 14:09:30 +01:00
04f062547d
TagReaderTagParser: Fix timeconstants.h include
2023-01-22 13:22:02 +01:00
f19dda57f0
gstfastspectrum: Use static_cast
2023-01-08 06:21:34 +01:00
Robert Gingras
Jonas Kvinge
4fury-c3440d8