Jonas Kvinge
b964385024
AlbumCoverLoader: Remove const
2024-08-25 01:16:29 +02:00
Jonas Kvinge
3f3059c98b
Replace QLatin1String with QStringLiteral
2024-08-25 01:08:25 +02:00
Jonas Kvinge
8da616491d
Replace emit with Q_EMIT
2024-08-25 01:06:30 +02:00
Jonas Kvinge
cb0db8750f
CollectionModelUpdate: Remove reference from enum
2024-08-24 23:20:20 +02:00
Jonas Kvinge
08224443e3
MainWindow: Don't use the playlists backend on right click
...
Fixes #1478
2024-08-24 22:43:16 +02:00
Jonas Kvinge
5c2989196f
MainWindow: Fix comments
2024-08-24 22:40:20 +02:00
Jonas Kvinge
4c4c84e104
PlaylistManager: Add methods for accessing playlists
2024-08-24 22:39:55 +02:00
Jonas Kvinge
232399ea28
DynamicPlaylistControls: Make background follow system colors
...
Fixes #1483
2024-08-24 22:07:46 +02:00
Jonas Kvinge
9d22e4ec07
SongLoader: Use Song::kRejectedExtensions
...
Fixes #1525
2024-08-24 21:12:19 +02:00
Jonas Kvinge
ee5bc16e47
CollectionWatcher: Use Song::kRejectedExtensions
2024-08-24 21:10:52 +02:00
Jonas Kvinge
74f0f885b9
Song: Add rejected extensions
2024-08-24 21:10:27 +02:00
Jonas Kvinge
b914d9aaba
Update translations.pot
2024-08-24 21:09:22 +02:00
Jonas Kvinge
cb3a9bf195
Update translations.pot
2024-08-24 20:44:46 +02:00
Strawberry Bot
cb847951e6
Update translations
2024-08-24 20:43:21 +02:00
Jonas Kvinge
11228f0634
Player: Add missing override
2024-08-24 20:38:08 +02:00
Jonas Kvinge
a0889d60f1
Update translations.pot
2024-08-24 20:21:45 +02:00
Jonas Kvinge
0055ebe8a7
CMake: Move translations.pot to src dir
2024-08-24 20:21:37 +02:00
Strawberry Bot
6afc081ff0
Update translations
2024-08-24 20:15:38 +02:00
Jonas Kvinge
2c0ad2fc88
Move lyrics providers to own thread
2024-08-24 20:07:36 +02:00
Jonas Kvinge
77e934beab
SpotifyService: Use LoginError
2024-08-24 19:29:00 +02:00
Jonas Kvinge
69f8ca95bc
Add missing reference
2024-08-24 19:28:15 +02:00
Jonas Kvinge
dde8661e93
Use QDateTime::currentSecsSinceEpoch()
2024-08-24 17:28:29 +02:00
Jonas Kvinge
2604e1a0ff
Use multi-arg
2024-08-24 17:27:47 +02:00
Jonas Kvinge
e8471bcc66
MusixmatchCoverProvider: Use static QRegularExpression
2024-08-24 17:27:05 +02:00
Jonas Kvinge
d230dd7365
Use fully-qualified namespaces in slot parameters
2024-08-24 17:25:56 +02:00
Jonas Kvinge
74dce24e91
Mpris2: Remove QtDBus include
2024-08-24 17:24:56 +02:00
Jonas Kvinge
bc667a6474
Use static QRegularExpression
2024-08-24 17:23:10 +02:00
Jonas Kvinge
a2cae06582
Remove QtConcurrent include
2024-08-24 17:01:53 +02:00
Jonas Kvinge
efd42bc68f
MusicBrainzClient: Remove unneeded values from qDeleteAll
2024-08-23 20:40:36 +02:00
Jonas Kvinge
ebaa2e7918
BlockAnalyzer: Replace value with at
2024-08-23 20:32:56 +02:00
Jonas Kvinge
7ebcc73a49
More const detach fixes
2024-08-23 20:30:59 +02:00
Jonas Kvinge
be09011bb7
CollectionWatcher: Use mutex for stop and abort
2024-08-23 20:22:18 +02:00
Jonas Kvinge
2778a55e8e
SpotifySettingsPage: Update Wiki page URL
2024-08-23 19:16:17 +02:00
Jonas Kvinge
9b5fe3bfd6
GstEnginePipeline: Rename PlaybinProbe to PadProbe
2024-08-23 00:17:33 +02:00
Jonas Kvinge
91eef0d695
GstEnginePipeline: Sort variables
2024-08-23 00:08:14 +02:00
Jonas Kvinge
88704efad8
Add lyricfind.com lyrics provider
2024-08-18 20:35:09 +02:00
Jonas Kvinge
f4e4483392
HtmlLyricsProvider: Remove extra QRegularExpression
2024-08-18 19:58:57 +02:00
Jonas Kvinge
8890a3dd0f
Delay play until playlists have finished loading
...
Fixes #1465
2024-08-17 22:38:48 +02:00
Strawberry Bot
4808188964
Update translations
2024-08-12 22:36:10 +02:00
Jonas Kvinge
1bb045b3b0
Mpris2: Remove .desktop file extension in DesktopEntry
...
According to the specifications it should be the desktop entry without .desktop file extension: https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
Fixes #1516
2024-08-12 21:49:25 +02:00
Jonas Kvinge
bdca60c0ad
Add missing const
2024-08-12 18:12:26 +02:00
Jonas Kvinge
8d9c135498
DeviceManager: Remove no longer relevant comment
2024-08-12 01:09:59 +02:00
Jonas Kvinge
0f76482916
GioLister: Remove undef signals
2024-08-12 01:09:33 +02:00
Jonas Kvinge
cbce9892d5
Replace slots with Q_SLOTS
2024-08-12 01:06:15 +02:00
Jonas Kvinge
f624b7a331
Add cpp files for classes with only header files
2024-08-12 00:48:16 +02:00
Jonas Kvinge
1ebcd61a75
PlaylistListView: Fix incorrect header guard
2024-08-11 23:30:03 +02:00
Jonas Kvinge
358da72ffe
Replace signals with Q_SIGNALS
2024-08-11 23:23:12 +02:00
Jonas Kvinge
9666feca37
GstEngine: Rename variable
2024-08-11 18:40:07 +02:00
Jonas Kvinge
03eb52eac8
GstEngine: Ensure no fading is done with exclusive mode
2024-08-11 17:37:23 +02:00
Jonas Kvinge
6562cc710c
GstEngine: Disconnect old pipelines
...
Fixes #1518
2024-08-11 15:53:41 +02:00
Jonas Kvinge
222001bc13
GstEnginePipeline: Fix buffering
2024-08-11 14:52:00 +02:00
Jonas Kvinge
7119f1bc81
Add filename and url to text search columns
2024-08-11 00:12:41 +02:00
Jonas Kvinge
548fa3f6ee
Wait for set state to finish before deleting pipeline
...
Setting state to GST_STATE_NULL sometimes blocks, to fix this use the threadpool to set the state to NULL and wait with deleting the pipeline until the state is changed.
This fixes blocking the main thread when switching Spotify songs.
2024-08-10 18:22:56 +02:00
Jonas Kvinge
8ddd309d5d
FilterTree: Use `Song::PrettyTitle` for title
...
Uses the filename instead if the title tag is emtpy.
2024-08-10 12:43:38 +02:00
Jonas Kvinge
8c8acbb546
GstEnginePipeline: Rename variables
2024-08-09 19:29:12 +02:00
Jonas Kvinge
fe30f27af3
GstEngine: Simplify use of `State`
2024-08-09 19:26:15 +02:00
Jonas Kvinge
d5d2eaba8a
CollectionWatcher: Make const
2024-08-08 17:13:14 +02:00
Jonas Kvinge
e8f64bfe8f
CollectionWatcher: Formatting
2024-08-08 17:12:51 +02:00
Jonas Kvinge
e3b8f9cb8c
Windows7ThumbBar: Fix namespace
2024-08-07 01:15:26 +02:00
Jonas Kvinge
819463a865
Use anonymous namespace for constants
2024-08-07 00:52:58 +02:00
Jonas Kvinge
c69777ca39
ContextView: Only update top text when changed
2024-08-06 23:24:58 +02:00
Jonas Kvinge
40f3e828aa
ResizableTextEdit: Store current text
2024-08-06 23:23:27 +02:00
Jonas Kvinge
dc8520ebec
Move translations.pot to binary directory
2024-08-06 23:05:26 +02:00
Jonas Kvinge
7ffbedf0dd
AnalyzerContainer: Fix setting default analyzer
2024-08-06 22:59:26 +02:00
Jonas Kvinge
826fad1ad4
SpotifyRequest: Limit returned albums to queried artists
2024-08-05 18:24:47 +02:00
Jonas Kvinge
1c4d3aebad
Rename enums
2024-08-05 17:53:07 +02:00
Jonas Kvinge
ff6e93fc15
CollectionWatcher: Only start transaction with scan on startup
...
Fixes #1469
2024-08-03 00:44:47 +02:00
Jonas Kvinge
17e88bb97d
Add const
2024-08-02 23:35:52 +02:00
Jonas Kvinge
d3dd26c596
GstEnginePipeline: Set Spotify bitrate to 320
2024-08-01 23:22:19 +02:00
Strawberry Bot
b80d239820
Update translations
2024-07-31 17:26:35 +02:00
Jonas Kvinge
9bfd14d067
FancyTabBar: Add missing override
2024-07-30 16:33:50 +02:00
Jonas Kvinge
061e0562d1
CollectionView: Fix search for this
...
Fixes #1510
2024-07-29 20:23:42 +02:00
Jonas Kvinge
2ba20b013d
Move fancy tabbar classes into separate files
2024-07-29 18:19:41 +02:00
Jonas Kvinge
dc36f87a6e
FancyTabWidget: Remove use of `QTabBar::tabText`
...
Fixes #1476
Fixes #1389
2024-07-29 17:15:33 +02:00
Jonas Kvinge
e82ecb48b8
PlaylistTabBar: Don't use `QTabBar::tabText`
...
Fixes #1499
2024-07-29 16:17:46 +02:00
Jonas Kvinge
c56a134179
Update translations.pot
2024-07-29 13:02:37 +02:00
Jonas Kvinge
11028456ad
LocalRedirectServer: Remove unused declaration
2024-07-29 01:53:16 +02:00
Jonas Kvinge
81fcb02974
OpenTidalCoverProvider: Only login when required
...
Fixes #1500
2024-07-29 00:48:16 +02:00
Jonas Kvinge
5ef4976c53
SpotifyRequest: Remove unused variable
2024-07-28 14:55:42 +02:00
Strawberry Bot
c10df5b634
Update French translations
2024-07-28 01:26:26 +02:00
Jonas Kvinge
70fdd5b0b3
Use anonymous namespace instead of static for constants
2024-07-28 01:24:56 +02:00
Strawberry Bot
66b1c22174
Update translations
2024-07-25 02:27:38 +02:00
Jonas Kvinge
03c69be421
Rename translation files
2024-07-25 01:29:40 +02:00
Jonas Kvinge
3a9a952cb0
Add translations.pot
2024-07-24 22:39:05 +02:00
Eri the Switch
3bd0331aa3
Use accumulator for seeking via scrolling
...
This results in much smoother experience on my touchpad.
The value of 120 was chosen as the most common for mice,
according to Qt 6 documentation.
2024-07-24 20:02:33 +02:00
Eri the Switch
3ecf224d91
Use accumulator for volume scrolling events
...
This results in much smoother experience on my touchpad.
2024-07-24 20:02:33 +02:00
Jonas Kvinge
37743606a2
CollectionModel: Remove unused ExpandAll function
2024-07-24 19:58:53 +02:00
Jonas Kvinge
49f074737c
Remove placeholder text
2024-07-22 20:48:46 +02:00
Jonas Kvinge
3d53a8b434
AppearanceSettingsPage: Remove translatable
2024-07-22 19:00:24 +02:00
Jonas Kvinge
e260433c7a
settings: Remove translatable
2024-07-22 18:58:18 +02:00
Jonas Kvinge
fbdac36f6f
PlaylistView: Adjust initial header layout
2024-07-20 15:19:50 +02:00
Jonas Kvinge
da3876bd83
StretchHeaderView: Properly implement reset
2024-07-20 15:19:28 +02:00
Jonas Kvinge
d303e700ae
CollectionFilter: Override mimedata function
2024-07-20 01:55:53 +02:00
Jonas Kvinge
92a1173b9e
Remove unused FilterParserRatingComparatorDecorator
2024-07-19 18:18:02 +02:00
Jonas Kvinge
1a8690e1f2
StretchHeaderView: Make sure section size never is zero
...
Fixes #1085
2024-07-19 17:51:49 +02:00
Jonas Kvinge
6543e4c5da
Use common filter parser for collection and playlist
2024-07-19 17:29:05 +02:00
Jonas Kvinge
dd904fe3c2
Remove unused CollectionQueryOptions class
2024-07-18 02:06:48 +02:00
Jonas Kvinge
95c265ffd3
CollectionFilter: Match individual words
2024-07-17 01:41:25 +02:00
Jonas Kvinge
31c1ae68df
EditTagDialog: Fix build without MusicBrainz
...
Fixes #1492
2024-07-17 00:00:17 +02:00
Jonas Kvinge
f2eb0c3b6b
CollectionModel: Add `ItemNeverHasChildren`
2024-07-15 14:28:29 +02:00
Jonas Kvinge
32be33847c
CollectionFilter: Move early return
2024-07-15 14:16:56 +02:00
Jonas Kvinge
3100b0c044
CollectionFilter: Use recursive filtering
...
Fixes #1486
Fixes #1487
2024-07-15 13:44:50 +02:00
Jonas Kvinge
f4ec3ab379
CollectionModel: Don't append artist if song is compilation
2024-07-14 20:21:08 +02:00
Mikel Pérez
8ad560ce0e
simplify CreateElementForMimeType + good practices
...
suggestions from gstreamer dev slomo on gst's matrix:
- whole static_pad_templates loop can be avoided with
gst_element_factory_can_src_any_caps
- ffmpeg elements have been av* prefixed for a while now
- should be looking for Muxer instead of Codec/Muxer,
Encoder/Audio instead of Codec/Encoder/Audio,
and there are constants for that
2024-07-14 17:24:42 +02:00
Jonas Kvinge
41d9d15dda
MainWindow: Only show sponsor dialog if update dialog is answered
2024-07-13 18:24:47 +02:00
Jonas Kvinge
1f2b8d8bf6
Rename playlist filter classes
2024-07-10 18:27:17 +02:00
Jonas Kvinge
8327751b91
CollectionFilter: Optimize use of QRegularExpression
...
Possible fix for #1482
2024-07-09 22:06:42 +02:00
Jonas Kvinge
6417f89596
CollectionFilter: Add std::as_const
2024-07-09 18:06:46 +02:00
Jonas Kvinge
67f04a81b3
Playlist: Add data changed when setting current row
2024-07-09 16:21:09 +02:00
Jonas Kvinge
74b8cd6156
StretchHeaderView: Formatting
2024-07-09 11:35:01 +02:00
Jonas Kvinge
ac959387fe
StretchHeaderView: Fix infinite loop
...
Fixes #1480
2024-07-09 11:14:31 +02:00
Jonas Kvinge
625929133c
Rename analyzers and add turbine analyzer
2024-07-09 04:39:48 +02:00
Jonas Kvinge
527a61f909
OpenTidalCoverProvider: Handle authentication required
2024-07-09 02:37:21 +02:00
Jonas Kvinge
a15ebcde24
Song: Update supported fields for ASF
2024-07-05 21:27:49 +02:00
Jonas Kvinge
2a4fd346f9
Rename QueryType to Type
2024-07-02 18:34:27 +02:00
Jonas Kvinge
6200fed224
Add missing const
2024-07-02 18:33:15 +02:00
Jonas Kvinge
e1b4585dc7
CollectionModel: Minor change in debug log
2024-07-02 17:53:14 +02:00
Jonas Kvinge
c5eb72fa9f
SpotifyRequest: Use artist from albums reply
2024-07-02 17:50:55 +02:00
Jonas Kvinge
d2e19ef4c3
SpotifyRequest: Add include_groups for albums query
2024-07-02 17:50:11 +02:00
Jonas Kvinge
4509c43b81
SpotifyRequest: Check for download covers
2024-07-02 17:49:56 +02:00
Jonas Kvinge
e2ffe716e7
SpotifyRequest: Remove unused variable
2024-07-02 17:49:40 +02:00
Jonas Kvinge
2edc4369d2
CollectionModel: Only prepend artist on album group by
2024-07-01 17:11:14 +02:00
Jonas Kvinge
32baa95500
Add better error handling for Tag reader
2024-07-01 02:06:42 +02:00
Jonas Kvinge
ad9f3ce078
playlistparsers: Rename collection_search to collection_lookup
2024-07-01 02:06:42 +02:00
Jonas Kvinge
c1f66b1885
CueParser: Remove unused variable
2024-06-29 15:24:54 +02:00
Jonas Kvinge
93660bfc81
Formatting
2024-06-27 18:00:44 +02:00
Jonas Kvinge
6446942e73
Add error handling to playlist parsers
2024-06-24 20:20:49 +02:00
Jonas Kvinge
0038cf8c4e
CollectionWatcher: Make sure periodic scan is stopped
2024-06-24 19:43:09 +02:00
Jonas Kvinge
7f177aef08
CollectionModel: Always separate albums by different artists
...
Fixes #1276
2024-06-24 19:21:24 +02:00
Jonas Kvinge
a7a42ea5ec
AnalyzerContainer: Use constexpr
2024-06-22 00:48:21 +02:00
Jonas Kvinge
14cddfd42f
AnalyzerContainer: Add parameter
2024-06-22 00:48:03 +02:00
Jonas Kvinge
ae0ce65674
AnalyzerContainer: Remove unused declaration
2024-06-22 00:47:52 +02:00
Jonas Kvinge
9c9926d5a7
PlaylistHeader: Cast column to int
...
Fixes #1468
2024-06-22 00:43:20 +02:00
Jonas Kvinge
4be9265546
PlaylistView: Use `Playlist::ColumnCount`
2024-06-20 23:00:33 +02:00
Jonas Kvinge
9f9c46e370
Update individual playlist columns, use enum class
2024-06-20 22:52:27 +02:00
Jonas Kvinge
5816d0bb12
About: Update contributors
2024-06-20 16:48:45 +02:00
Jonas Kvinge
70c2b99771
ContextAlbum: Delete timeline to delete previous cover
...
QTimeLine was holding the previous covers shared pointer in the signal/slot connection, which caused it to never be free'd even though it's removed from the previous_covers_ list.
To fix this, make sure the QTimeLine is deleted.
This fixes a huge memory leak.
Addresses issue #1464
2024-06-20 16:05:07 +02:00
Jonas Kvinge
6177d4a2c4
ContextAlbum: Use const reference for image parameter
2024-06-20 15:59:34 +02:00
Jonas Kvinge
05f012e590
ContextAlbum: Formatting
2024-06-20 15:58:24 +02:00
Jonas Kvinge
cc0506490f
ContextAlbum: Use constexpr for kFadeTimeLineMs
2024-06-20 15:57:53 +02:00
Jonas Kvinge
06114c9835
ContextAlbum: Add explicit for PreviousCover
2024-06-20 15:57:12 +02:00
Jonas Kvinge
2518e4d47d
ContextAlbum: Remove unused function declaration
2024-06-20 15:56:49 +02:00
Jonas Kvinge
ceea805196
main: Remove `QCoreApplication::setQuitLockEnabled(false);`
...
This was a workaround for QTBUG-124386.
2024-06-19 21:33:01 +02:00
Jonas Kvinge
b275f91a58
PlaylistView: Set new default column sizes
2024-06-18 19:52:51 +02:00
Jonas Kvinge
b8ef96028c
StretchHeaderView: Refactor code and improve header view
...
Save what sections are visible, and always save sizes.
Do not set section size to zero when hiding sections.
When resizing columns in stretch mode, only resize the right column to fit the left column.
Fixes #1085
2024-06-18 19:52:34 +02:00
Jonas Kvinge
d576777d94
CueParser: Always set track
2024-06-14 21:19:18 +02:00
Jonas Kvinge
1f7344ca1b
CueParser: Move artist / album variables
...
Fixes #1463
2024-06-14 21:19:04 +02:00
Jonas Kvinge
87c69f7456
CueParser: Formatting
2024-06-14 21:17:59 +02:00
Jonas Kvinge
a684b35203
ParserBase: Always read file, CUE depends on it
2024-06-14 21:03:52 +02:00
Jonas Kvinge
37855fe836
CollectionBackend: Remove QUrl::FullyDecoded from QUrl::toString()
2024-06-14 18:46:48 +02:00