From da86b86776aacd8d6b9eb6d0fd7fcee38116e66f Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Wed, 14 Jul 2021 12:53:28 +0200 Subject: [PATCH] Rename variable --- src/radios/radioview.cpp | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/src/radios/radioview.cpp b/src/radios/radioview.cpp index d22b0e079..34b1ff9b5 100644 --- a/src/radios/radioview.cpp +++ b/src/radios/radioview.cpp @@ -105,13 +105,19 @@ void RadioView::contextMenuEvent(QContextMenuEvent *e) { void RadioView::AddToPlaylist() { - emit AddToPlaylistSignal(model()->mimeData(selectedIndexes())); + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; + + emit AddToPlaylistSignal(model()->mimeData(selected_indexes)); } void RadioView::ReplacePlaylist() { - QMimeData *qmimedata = model()->mimeData(selectedIndexes()); + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; + + QMimeData *qmimedata = model()->mimeData(selected_indexes); if (MimeData *mimedata = qobject_cast(qmimedata)) { mimedata->clear_first_ = true; } @@ -122,7 +128,10 @@ void RadioView::ReplacePlaylist() { void RadioView::OpenInNewPlaylist() { - QMimeData *qmimedata = model()->mimeData(selectedIndexes()); + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; + + QMimeData *qmimedata = model()->mimeData(selected_indexes); if (RadioMimeData *mimedata = qobject_cast(qmimedata)) { mimedata->open_in_new_playlist_ = true; if (!mimedata->songs.isEmpty()) { @@ -136,10 +145,11 @@ void RadioView::OpenInNewPlaylist() { void RadioView::Homepage() { - const QModelIndexList indexes = selectedIndexes(); + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; QList urls; - for (const QModelIndex &idx : indexes) { + for (const QModelIndex &idx : selected_indexes) { QUrl url = idx.data(RadioModel::Role_Homepage).toUrl(); if (!urls.contains(url)) { urls << url; @@ -154,10 +164,11 @@ void RadioView::Homepage() { void RadioView::Donate() { - const QModelIndexList indexes = selectedIndexes(); + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; QList urls; - for (const QModelIndex &idx : indexes) { + for (const QModelIndex &idx : selected_indexes) { QUrl url = idx.data(RadioModel::Role_Donate).toUrl(); if (!urls.contains(url)) { urls << url; @@ -172,10 +183,10 @@ void RadioView::Donate() { void RadioView::DoubleClicked() { - const QModelIndexList indexes = selectedIndexes(); - if (indexes.isEmpty()) return; + const QModelIndexList selected_indexes = selectedIndexes(); + if (selected_indexes.isEmpty()) return; - for (const QModelIndex &idx : indexes) { + for (const QModelIndex &idx : selected_indexes) { if (idx.data(RadioModel::Role_Type).toInt() != RadioItem::Type_Channel) { return; }