Cleanup includes

src/collection/collection.cpp

@@ -31,7 +31,6 @@
 #include "core/application.h"
 #include "core/taskmanager.h"
 #include "core/database.h"
-#include "core/player.h"
 #include "core/tagreaderclient.h"
 #include "core/thread.h"
 #include "core/song.h"
@@ -41,7 +40,6 @@
 #include "collectionwatcher.h"
 #include "collectionbackend.h"
 #include "collectionmodel.h"
-#include "playlist/playlistmanager.h"
 #include "scrobbler/lastfmimport.h"
 #include "settings/collectionsettingspage.h"
 

src/collection/collectionbackend.h

@@ -34,10 +34,8 @@
 #include <QStringList>
 #include <QUrl>
 #include <QSqlDatabase>
-#include <QSqlQuery>
 
 #include "core/song.h"
-#include "core/sqlquery.h"
 #include "collectionfilteroptions.h"
 #include "collectionquery.h"
 #include "collectiondirectory.h"

src/collection/collectionfilterwidget.cpp

@@ -48,7 +48,6 @@
 #include "core/logging.h"
 #include "collectionfilteroptions.h"
 #include "collectionmodel.h"
-#include "collectionquery.h"
 #include "savedgroupingmanager.h"
 #include "collectionfilterwidget.h"
 #include "groupbydialog.h"

src/collection/collectionfilterwidget.h

@@ -31,8 +31,6 @@
 #include <QHash>
 #include <QString>
 
-#include "collectionquery.h"
-#include "collectionqueryoptions.h"
 #include "collectionmodel.h"
 
 class QTimer;
@@ -135,7 +133,6 @@ class CollectionFilterWidget : public QWidget {
   QString settings_group_;
   QString saved_groupings_settings_group_;
   QString settings_prefix_;
-
 };
 
 #endif  // COLLECTIONFILTERWIDGET_H

src/collection/collectionmodel.cpp

@@ -68,10 +68,10 @@
 #include "collectionmodel.h"
 #include "playlist/playlistmanager.h"
 #include "playlist/songmimedata.h"
-#include "covermanager/albumcoverloader.h"
+#include "covermanager/albumcoverloaderoptions.h"
 #include "covermanager/albumcoverloaderresult.h"
+#include "covermanager/albumcoverloader.h"
 #include "settings/collectionsettingspage.h"
-#include "settings/coverssettingspage.h"
 
 const int CollectionModel::kPrettyCoverSize = 32;
 const char *CollectionModel::kPixmapDiskCacheDir = "pixmapcache";

src/collection/collectionmodel.h

@@ -48,10 +48,9 @@
 #include "core/simpletreemodel.h"
 #include "core/song.h"
 #include "core/sqlrow.h"
-#include "covermanager/albumcoverloader.h"
 #include "covermanager/albumcoverloaderoptions.h"
+#include "covermanager/albumcoverloaderresult.h"
 #include "collectionfilteroptions.h"
-#include "collectionquery.h"
 #include "collectionqueryoptions.h"
 #include "collectionitem.h"
 

src/collection/collectionquery.cpp

@@ -32,13 +32,10 @@
 #include <QSqlDatabase>
 #include <QSqlQuery>
 
-#include "core/logging.h"
-#include "core/sqlquery.h"
 #include "core/song.h"
 
 #include "collectionquery.h"
 #include "collectionfilteroptions.h"
-#include "collectionqueryoptions.h"
 
 CollectionQuery::CollectionQuery(const QSqlDatabase &db, const QString &songs_table, const QString &fts_table, const CollectionFilterOptions &filter_options)
     : QSqlQuery(db),

src/collection/collectionquery.h

@@ -32,7 +32,6 @@
 #include <QSqlQuery>
 
 #include "collectionfilteroptions.h"
-#include "collectionqueryoptions.h"
 
 class CollectionQuery : public QSqlQuery {
  public:

src/collection/collectionqueryoptions.cpp

@@ -21,7 +21,6 @@
 #include <QString>
 
 #include "collectionqueryoptions.h"
-#include "collectionfilteroptions.h"
 
 CollectionQueryOptions::CollectionQueryOptions()
     : compilation_requirement_(CollectionQueryOptions::CompilationRequirement::None),

src/core/mainwindow.cpp

@@ -127,7 +127,6 @@
 #include "collection/collectiondirectorymodel.h"
 #include "collection/collectionfilterwidget.h"
 #include "collection/collectionmodel.h"
-#include "collection/collectionquery.h"
 #include "collection/collectionview.h"
 #include "collection/collectionviewcontainer.h"
 #include "playlist/playlist.h"
@@ -163,6 +162,7 @@
 #include "settings/settingsdialog.h"
 #include "settings/behavioursettingspage.h"
 #include "settings/backendsettingspage.h"
+#include "settings/collectionsettingspage.h"
 #include "settings/playlistsettingspage.h"
 #ifdef HAVE_SUBSONIC
 #  include "settings/subsonicsettingspage.h"
@@ -199,7 +199,6 @@
 #endif
 
 #include "smartplaylists/smartplaylistsviewcontainer.h"
-#include "smartplaylists/smartplaylistsview.h"
 
 #ifdef Q_OS_WIN
 #  include "windows7thumbbar.h"

src/core/mainwindow.h

@@ -54,7 +54,6 @@
 #include "tagreaderclient.h"
 #include "engine/enginebase.h"
 #include "osd/osdbase.h"
-#include "collection/collectionmodel.h"
 #include "playlist/playlist.h"
 #include "playlist/playlistitem.h"
 #include "settings/settingsdialog.h"

src/core/player.cpp

@@ -64,9 +64,6 @@
 #include "settings/backendsettingspage.h"
 #include "settings/behavioursettingspage.h"
 #include "settings/playlistsettingspage.h"
-#include "internet/internetservices.h"
-#include "internet/internetservice.h"
-#include "scrobbler/audioscrobbler.h"
 
 const char *Player::kSettingsGroup = "Player";
 

src/core/tagreaderclient.cpp

@@ -36,7 +36,6 @@
 
 #include "song.h"
 #include "tagreaderclient.h"
-#include "settings/collectionsettingspage.h"
 
 const char *TagReaderClient::kWorkerExecutableName = "strawberry-tagreader";
 TagReaderClient *TagReaderClient::sInstance = nullptr;

src/covermanager/albumcoverchoicecontroller.cpp

@@ -55,7 +55,6 @@
 #include "utilities/filenameconstants.h"
 #include "utilities/strutils.h"
 #include "utilities/mimeutils.h"
-#include "utilities/imageutils.h"
 #include "utilities/coveroptions.h"
 #include "utilities/coverutils.h"
 #include "utilities/screenutils.h"

src/covermanager/albumcoverchoicecontroller.h

@@ -40,7 +40,6 @@
 #include "core/song.h"
 #include "core/tagreaderclient.h"
 #include "utilities/coveroptions.h"
-#include "settings/collectionsettingspage.h"
 #include "albumcoverloaderoptions.h"
 #include "albumcoverimageresult.h"
 

src/covermanager/albumcoverfetchersearch.cpp

@@ -21,8 +21,8 @@
 
 #include "config.h"
 
-#include <algorithm>
 #include <cmath>
+#include <algorithm>
 
 #include <QObject>
 #include <QCoreApplication>

src/covermanager/albumcovermanager.cpp

@@ -64,22 +64,21 @@
 #include <QSize>
 #include <QtEvents>
 
-#include "utilities/strutils.h"
-#include "utilities/fileutils.h"
-#include "utilities/imageutils.h"
-#include "utilities/mimeutils.h"
-#include "utilities/screenutils.h"
 #include "core/application.h"
 #include "core/iconloader.h"
 #include "core/tagreaderclient.h"
 #include "core/database.h"
 #include "core/sqlrow.h"
+#include "utilities/strutils.h"
+#include "utilities/fileutils.h"
+#include "utilities/imageutils.h"
+#include "utilities/mimeutils.h"
+#include "utilities/screenutils.h"
 #include "widgets/forcescrollperpixel.h"
 #include "widgets/qsearchfield.h"
 #include "collection/collectionbackend.h"
 #include "collection/collectionquery.h"
 #include "playlist/songmimedata.h"
-#include "settings/collectionsettingspage.h"
 #include "coverproviders.h"
 #include "albumcovermanager.h"
 #include "albumcoversearcher.h"

src/covermanager/albumcovermanager.h

@@ -42,7 +42,6 @@
 #include "albumcoverloaderresult.h"
 #include "albumcoverchoicecontroller.h"
 #include "coversearchstatistics.h"
-#include "settings/collectionsettingspage.h"
 
 class QWidget;
 class QMimeData;

src/covermanager/coverfromurldialog.cpp

@@ -31,8 +31,8 @@
 #include <QNetworkRequest>
 #include <QUrl>
 
-#include "utilities/mimeutils.h"
 #include "core/networkaccessmanager.h"
+#include "utilities/mimeutils.h"
 #include "widgets/busyindicator.h"
 #include "albumcoverimageresult.h"
 #include "coverfromurldialog.h"

src/covermanager/qobuzcoverprovider.cpp

@@ -41,7 +41,6 @@
 #include "core/song.h"
 #include "internet/internetservices.h"
 #include "qobuz/qobuzservice.h"
-#include "qobuz/qobuzbaserequest.h"
 #include "albumcoverfetcher.h"
 #include "jsoncoverprovider.h"
 #include "qobuzcoverprovider.h"

src/covermanager/qobuzcoverprovider.h

@@ -36,7 +36,6 @@
 class QNetworkReply;
 class Application;
 class NetworkAccessManager;
-class QobuzService;
 
 class QobuzCoverProvider : public JsonCoverProvider {
   Q_OBJECT

src/device/devicemanager.cpp

@@ -44,10 +44,10 @@
 
 #include "devicemanager.h"
 
+#include "core/logging.h"
 #include "core/application.h"
 #include "core/database.h"
 #include "core/iconloader.h"
-#include "core/logging.h"
 #include "core/musicstorage.h"
 #include "core/taskmanager.h"
 #include "core/simpletreemodel.h"

src/device/filesystemdevice.cpp

@@ -25,8 +25,8 @@
 #include <QString>
 #include <QUrl>
 
-#include "core/application.h"
 #include "core/logging.h"
+#include "core/application.h"
 #include "core/song.h"
 
 #include "collection/collectionbackend.h"

src/device/gpodloader.cpp

@@ -29,10 +29,10 @@
 #include <QByteArray>
 #include <QString>
 
-#include "collection/collectionbackend.h"
 #include "core/logging.h"
 #include "core/song.h"
 #include "core/taskmanager.h"
+#include "collection/collectionbackend.h"
 #include "gpodloader.h"
 
 GPodLoader::GPodLoader(const QString &mount_point, TaskManager *task_manager, CollectionBackend *backend, std::shared_ptr<ConnectedDevice> device, QObject *parent)

src/device/mtpconnection.h

@@ -25,6 +25,7 @@
 #include "config.h"
 
 #include <memory>
+
 #include <libmtp.h>
 
 #include <QtGlobal>

src/device/mtpdevice.cpp

@@ -33,11 +33,11 @@
 #include <QString>
 #include <QUrl>
 
-#include "collection/collectionmodel.h"
-#include "collection/collectionbackend.h"
 #include "core/logging.h"
 #include "core/application.h"
 #include "core/musicstorage.h"
+#include "collection/collectionmodel.h"
+#include "collection/collectionbackend.h"
 #include "connecteddevice.h"
 #include "mtpdevice.h"
 #include "mtploader.h"

src/engine/ebur128analysis.cpp

@@ -22,15 +22,17 @@
 #include <cmath>
 #include <cstdlib>
 #include <cstring>
-#include <memory>
 #include <optional>
+#include <tuple>
+#include <vector>
+#include <memory>
 
-#include <ebur128.h>
 #include <glib-object.h>
 #include <glib.h>
-#include <gst/app/gstappsink.h>
-#include <gst/audio/audio-channels.h>
 #include <gst/gst.h>
+#include <gst/audio/audio-channels.h>
+#include <gst/app/gstappsink.h>
+#include <ebur128.h>
 
 #include <QCoreApplication>
 #include <QElapsedTimer>

src/engine/gstengine.cpp

@@ -22,12 +22,13 @@
 
 #include "config.h"
 
+#include <cmath>
+#include <algorithm>
+#include <optional>
+#include <memory>
+
 #include <glib.h>
 #include <glib-object.h>
-#include <memory>
-#include <algorithm>
-#include <vector>
-#include <cmath>
 
 #include <gst/gst.h>
 #include <gst/pbutils/pbutils.h>

src/engine/gstengine.h

@@ -26,6 +26,7 @@
 #include "config.h"
 
 #include <memory>
+#include <optional>
 
 #include <gst/gst.h>
 #include <gst/pbutils/pbutils.h>
@@ -38,7 +39,6 @@
 #include <QString>
 #include <QUrl>
 
-#include "utilities/timeconstants.h"
 #include "enginebase.h"
 #include "gststartup.h"
 #include "gstbufferconsumer.h"

src/engine/gstenginepipeline.cpp

@@ -51,7 +51,6 @@
 #include "core/signalchecker.h"
 #include "utilities/timeconstants.h"
 #include "settings/backendsettingspage.h"
-#include "enginebase.h"
 #include "gstengine.h"
 #include "gstenginepipeline.h"
 #include "gstbufferconsumer.h"

src/engine/vlcengine.cpp

@@ -21,6 +21,9 @@
 
 #include "config.h"
 
+#include <algorithm>
+#include <optional>
+
 #include <vlc/vlc.h>
 
 #include <QtGlobal>

src/engine/vlcengine.h

@@ -24,6 +24,8 @@
 
 #include "config.h"
 
+#include <optional>
+
 #include <vlc/vlc.h>
 
 #include <QtGlobal>

src/internet/internetcollectionview.h

@@ -32,9 +32,10 @@
 #include <QString>
 #include <QPixmap>
 
-#include "widgets/autoexpandingtreeview.h"
 #include "core/song.h"
 
+#include "widgets/autoexpandingtreeview.h"
+
 class QWidget;
 class QMenu;
 class QAction;

src/internet/internetplaylistitem.cpp

@@ -25,11 +25,8 @@
 #include <QVariant>
 
 #include "internetplaylistitem.h"
-#include "internetservices.h"
 #include "internetservice.h"
-#include "core/settingsprovider.h"
 #include "core/sqlrow.h"
-#include "playlist/playlistbackend.h"
 
 InternetPlaylistItem::InternetPlaylistItem(const Song::Source source)
     : PlaylistItem(source),

src/internet/internetsearchview.h

@@ -43,7 +43,6 @@
 #include "core/song.h"
 #include "collection/collectionmodel.h"
 #include "covermanager/albumcoverloaderresult.h"
-#include "settings/settingsdialog.h"
 
 class QSortFilterProxyModel;
 class QMimeData;

src/lyrics/geniuslyricsprovider.cpp

@@ -44,11 +44,9 @@
 
 #include "core/logging.h"
 #include "core/networkaccessmanager.h"
-#include "utilities/strutils.h"
 #include "utilities/randutils.h"
 #include "internet/localredirectserver.h"
 #include "jsonlyricsprovider.h"
-#include "lyricsfetcher.h"
 #include "geniuslyricsprovider.h"
 
 const char *GeniusLyricsProvider::kSettingsGroup = "GeniusLyrics";

src/lyrics/lyricscomlyricsprovider.cpp

@@ -34,7 +34,6 @@
 
 #include "core/logging.h"
 #include "core/networkaccessmanager.h"
-#include "utilities/strutils.h"
 #include "lyricssearchrequest.h"
 #include "lyricssearchresult.h"
 #include "lyricscomlyricsprovider.h"

src/lyrics/lyricsfetchersearch.cpp

@@ -26,7 +26,6 @@
 #include <QList>
 
 #include "core/logging.h"
-#include "lyricsfetcher.h"
 #include "lyricsfetchersearch.h"
 #include "lyricssearchrequest.h"
 #include "lyricssearchresult.h"

src/lyrics/lyricsfetchersearch.h

@@ -27,7 +27,6 @@
 #include <QMap>
 #include <QString>
 
-#include "lyricsfetcher.h"
 #include "lyricssearchrequest.h"
 #include "lyricssearchresult.h"
 

src/moodbar/moodbarpipeline.cpp

@@ -17,8 +17,10 @@
 
 #include "moodbarpipeline.h"
 
-#include <memory>
 #include <cstdlib>
+
+#include <memory>
+
 #include <glib.h>
 #include <glib-object.h>
 #include <gst/gst.h>

src/organize/organize.cpp

@@ -19,10 +19,11 @@
  *
  */
 
+#include <QtGlobal>
+
 #include <functional>
 #include <chrono>
 
-#include <QtGlobal>
 #include <QThread>
 #include <QFile>
 #include <QFileInfo>

src/playlist/playlist.cpp

@@ -67,7 +67,7 @@
 #include "collection/collection.h"
 #include "collection/collectionbackend.h"
 #include "collection/collectionplaylistitem.h"
-#include "covermanager/albumcoverloader.h"
+#include "covermanager/albumcoverloaderresult.h"
 #include "queue/queue.h"
 #include "playlist.h"
 #include "playlistitem.h"
@@ -87,6 +87,7 @@
 
 #include "internet/internetplaylistitem.h"
 #include "internet/internetsongmimedata.h"
+#include "internet/internetservice.h"
 
 #include "radios/radiomimedata.h"
 #include "radios/radioplaylistitem.h"

src/playlist/playlistitem.cpp

@@ -30,7 +30,6 @@
 #include "core/sqlquery.h"
 #include "core/song.h"
 
-#include "collection/collection.h"
 #include "collection/collectionplaylistitem.h"
 #include "playlistitem.h"
 #include "songplaylistitem.h"

src/playlist/playlistlistcontainer.cpp

@@ -21,8 +21,8 @@
 
 #include "config.h"
 
-#include <memory>
 #include <utility>
+#include <memory>
 
 #include <QObject>
 #include <QWidget>

src/playlist/playlistmanager.cpp

@@ -21,7 +21,6 @@
 
 #include "config.h"
 
-#include <functional>
 #include <utility>
 
 #include <QtGlobal>

src/playlist/playlisttabbar.cpp

@@ -43,8 +43,8 @@
 #include <QtEvents>
 #include <QSettings>
 
-#include "core/iconloader.h"
 #include "core/logging.h"
+#include "core/iconloader.h"
 #include "core/mimedata.h"
 #include "widgets/favoritewidget.h"
 #include "widgets/renametablineedit.h"

src/playlistparsers/asxiniparser.h

@@ -21,13 +21,14 @@
 #ifndef ASXINIPARSER_H
 #define ASXINIPARSER_H
 
+#include "config.h"
+
 #include <QObject>
 #include <QByteArray>
 #include <QString>
 #include <QStringList>
 #include <QDir>
 
-#include "config.h"
 #include "core/song.h"
 #include "settings/playlistsettingspage.h"
 #include "parserbase.h"

src/playlistparsers/asxparser.h

@@ -21,13 +21,14 @@
 #ifndef ASXPARSER_H
 #define ASXPARSER_H
 
+#include "config.h"
+
 #include <QObject>
 #include <QByteArray>
 #include <QString>
 #include <QStringList>
 #include <QDir>
 
-#include "config.h"
 #include "core/song.h"
 #include "settings/playlistsettingspage.h"
 #include "xmlparser.h"

src/providers/musixmatchprovider.h

@@ -21,7 +21,6 @@
 #define MUSIXMATCHPROVIDER_H
 
 #include <QString>
-#include <QRegularExpression>
 
 class MusixmatchProvider {
 

src/radios/radioservice.cpp

@@ -26,8 +26,8 @@
 #include <QJsonDocument>
 #include <QJsonObject>
 
-#include "core/application.h"
 #include "core/logging.h"
+#include "core/application.h"
 #include "radioservice.h"
 
 RadioService::RadioService(const Song::Source source, const QString &name, const QIcon &icon, Application *app, NetworkAccessManager *network, QObject *parent)

src/smartplaylists/smartplaylistsearchtermwidget.cpp

@@ -34,8 +34,8 @@
 #include <QKeyEvent>
 #include <QEnterEvent>
 
-#include "utilities/colorutils.h"
 #include "core/iconloader.h"
+#include "utilities/colorutils.h"
 #include "playlist/playlist.h"
 #include "playlist/playlistdelegates.h"
 #include "smartplaylistsearchterm.h"

src/smartplaylists/smartplaylistsmodel.cpp

@@ -27,15 +27,14 @@
 #include <QMimeData>
 #include <QSettings>
 
+#include "core/logging.h"
 #include "core/application.h"
-#include "core/database.h"
 #include "core/iconloader.h"
 #include "core/simpletreemodel.h"
 #include "collection/collectionbackend.h"
 
 #include "smartplaylistsitem.h"
 #include "smartplaylistsmodel.h"
-#include "smartplaylistsview.h"
 #include "smartplaylistsearch.h"
 #include "playlistgenerator.h"
 #include "playlistgeneratormimedata.h"

src/smartplaylists/smartplaylistsviewcontainer.cpp

@@ -33,9 +33,7 @@
 #include "smartplaylistsviewcontainer.h"
 #include "smartplaylistsmodel.h"
 #include "smartplaylistsview.h"
-#include "smartplaylistsearchterm.h"
 #include "smartplaylistwizard.h"
-#include "playlistquerygenerator.h"
 #include "playlistgenerator_fwd.h"
 
 #include "ui_smartplaylistsviewcontainer.h"

src/smartplaylists/smartplaylistsviewcontainer.h

@@ -94,7 +94,6 @@ class SmartPlaylistsViewContainer : public QWidget {
   QAction *action_add_to_playlist_enqueue_;
   QAction *action_add_to_playlist_enqueue_next_;
   QModelIndex context_menu_index_;
-
 };
 
 #endif  // SMARTPLAYLISTSVIEWCONTAINER_H

src/subsonic/subsonicrequest.h

@@ -146,7 +146,6 @@ class SubsonicRequest : public SubsonicBaseRequest {
   bool no_results_;
   QList<QNetworkReply*> replies_;
   QList<QNetworkReply*> album_cover_replies_;
-
 };
 
 #endif  // SUBSONICREQUEST_H

src/subsonic/subsonicscrobblerequest.h

@@ -81,7 +81,6 @@ class SubsonicScrobbleRequest : public SubsonicBaseRequest {
 
   QStringList errors_;
   QList<QNetworkReply*> replies_;
-
 };
 
 #endif  // SUBSONICSCROBBLEREQUEST_H

src/subsonic/subsonicurlhandler.h

@@ -49,7 +49,6 @@ class SubsonicUrlHandler : public UrlHandler {
 
  private:
   SubsonicService *service_;
-
 };
 
 #endif  // SUBSONICURLHANDLER_H

src/tidal/tidalrequest.h

@@ -38,6 +38,7 @@
 #include <QJsonObject>
 
 #include "core/song.h"
+
 #include "tidalbaserequest.h"
 
 class QNetworkReply;

src/tidal/tidalservice.cpp

@@ -41,9 +41,9 @@
 #include <QSettings>
 #include <QSortFilterProxyModel>
 
+#include "core/logging.h"
 #include "core/application.h"
 #include "core/player.h"
-#include "core/logging.h"
 #include "core/networkaccessmanager.h"
 #include "core/database.h"
 #include "core/song.h"

src/tidal/tidalurlhandler.h

@@ -59,7 +59,6 @@ class TidalUrlHandler : public UrlHandler {
   Application *app_;
   TidalService *service_;
   QMap<uint, Request> requests_;
-
 };
 
 #endif  // TIDALURLHANDLER_H

src/transcoder/transcoder.cpp

@@ -21,13 +21,15 @@
 
 #include "config.h"
 
-#include <memory>
+#include <QtGlobal>
+
 #include <algorithm>
+#include <memory>
+
 #include <glib.h>
 #include <glib/gtypes.h>
 #include <gst/gst.h>
 
-#include <QtGlobal>
 #include <QThread>
 #include <QCoreApplication>
 #include <QStandardPaths>

src/utilities/fileutils.cpp

@@ -18,10 +18,10 @@
  *
  */
 
-#include <memory>
-
 #include <QtGlobal>
 
+#include <memory>
+
 #include <QByteArray>
 #include <QString>
 #include <QIODevice>

src/utilities/transliterate.cpp

@@ -19,9 +19,9 @@
 
 #include "config.h"
 
-#include <string>
 #include <memory>
 #include <cstdio>
+#include <string>
 
 #ifdef HAVE_ICU
 #  include <unicode/translit.h>