diff --git a/src/engine/alsadevicefinder.cpp b/src/engine/alsadevicefinder.cpp index 76ca7dcce..7211f6b71 100644 --- a/src/engine/alsadevicefinder.cpp +++ b/src/engine/alsadevicefinder.cpp @@ -24,7 +24,6 @@ #include #include -#include #include #include @@ -34,9 +33,9 @@ AlsaDeviceFinder::AlsaDeviceFinder() : DeviceFinder("alsa", { "alsa", "alsasink" }) {} -QList AlsaDeviceFinder::ListDevices() { +DeviceFinder::DeviceList AlsaDeviceFinder::ListDevices() { - QList ret; + DeviceList ret; snd_pcm_stream_name(SND_PCM_STREAM_PLAYBACK); diff --git a/src/engine/alsadevicefinder.h b/src/engine/alsadevicefinder.h index 5a11ac26f..31a0fc60f 100644 --- a/src/engine/alsadevicefinder.h +++ b/src/engine/alsadevicefinder.h @@ -22,8 +22,6 @@ #include "config.h" -#include - #include "devicefinder.h" class AlsaDeviceFinder : public DeviceFinder { @@ -31,7 +29,7 @@ class AlsaDeviceFinder : public DeviceFinder { explicit AlsaDeviceFinder(); bool Initialize() override { return true; } - QList ListDevices() override; + DeviceList ListDevices() override; private: Q_DISABLE_COPY(AlsaDeviceFinder) diff --git a/src/engine/alsapcmdevicefinder.cpp b/src/engine/alsapcmdevicefinder.cpp index 1ea391868..9f6a5501c 100644 --- a/src/engine/alsapcmdevicefinder.cpp +++ b/src/engine/alsapcmdevicefinder.cpp @@ -21,7 +21,6 @@ #include -#include #include #include @@ -31,9 +30,9 @@ AlsaPCMDeviceFinder::AlsaPCMDeviceFinder() : DeviceFinder("alsa", { "alsa", "alsasink" }) {} -QList AlsaPCMDeviceFinder::ListDevices() { +DeviceFinder::DeviceList AlsaPCMDeviceFinder::ListDevices() { - QList ret; + DeviceList ret; void **hints = nullptr; if (snd_device_name_hint(-1, "pcm", &hints) < 0) { diff --git a/src/engine/alsapcmdevicefinder.h b/src/engine/alsapcmdevicefinder.h index 68b32e29c..b288ee71f 100644 --- a/src/engine/alsapcmdevicefinder.h +++ b/src/engine/alsapcmdevicefinder.h @@ -22,8 +22,6 @@ #include "config.h" -#include - #include "devicefinder.h" class AlsaPCMDeviceFinder : public DeviceFinder { @@ -31,7 +29,7 @@ class AlsaPCMDeviceFinder : public DeviceFinder { explicit AlsaPCMDeviceFinder(); bool Initialize() override { return true; } - QList ListDevices() override; + DeviceList ListDevices() override; private: Q_DISABLE_COPY(AlsaPCMDeviceFinder) diff --git a/src/engine/devicefinder.h b/src/engine/devicefinder.h index 6da1dde1b..f3d2515d8 100644 --- a/src/engine/devicefinder.h +++ b/src/engine/devicefinder.h @@ -40,6 +40,7 @@ class DeviceFinder { int card; int device; }; + using DeviceList = QList; virtual ~DeviceFinder() {} @@ -51,7 +52,7 @@ class DeviceFinder { virtual bool Initialize() = 0; // Returns a list of available devices. - virtual QList ListDevices() = 0; + virtual DeviceList ListDevices() = 0; protected: explicit DeviceFinder(const QString &name, const QStringList &outputs); diff --git a/src/engine/directsounddevicefinder.cpp b/src/engine/directsounddevicefinder.cpp index 2ff6b85e1..091e1020c 100644 --- a/src/engine/directsounddevicefinder.cpp +++ b/src/engine/directsounddevicefinder.cpp @@ -27,7 +27,6 @@ #include -#include #include #include #include @@ -37,7 +36,7 @@ DirectSoundDeviceFinder::DirectSoundDeviceFinder() : DeviceFinder("directsound", { "directsound", "dsound", "directsoundsink", "directx", "directx2" }) {} -QList DirectSoundDeviceFinder::ListDevices() { +DeviceFinder::DeviceList DirectSoundDeviceFinder::ListDevices() { State state; DirectSoundEnumerateA(&DirectSoundDeviceFinder::EnumerateCallback, &state); return state.devices; diff --git a/src/engine/directsounddevicefinder.h b/src/engine/directsounddevicefinder.h index ed6b6589f..2d775a031 100644 --- a/src/engine/directsounddevicefinder.h +++ b/src/engine/directsounddevicefinder.h @@ -33,11 +33,11 @@ class DirectSoundDeviceFinder : public DeviceFinder { explicit DirectSoundDeviceFinder(); virtual bool Initialize() { return true; } - virtual QList ListDevices(); + virtual DeviceList ListDevices(); private: struct State { - QList devices; + DeviceList devices; }; static BOOL CALLBACK EnumerateCallback(LPGUID guid, LPCSTR description, LPCSTR module, LPVOID state_voidptr); diff --git a/src/engine/macosdevicefinder.cpp b/src/engine/macosdevicefinder.cpp index 5931da7b3..799ab01a3 100644 --- a/src/engine/macosdevicefinder.cpp +++ b/src/engine/macosdevicefinder.cpp @@ -24,7 +24,6 @@ #include -#include #include #include "core/logging.h" @@ -64,9 +63,9 @@ std::unique_ptr GetProperty(const AudioDeviceID &device_id, const AudioObject MacOsDeviceFinder::MacOsDeviceFinder() : DeviceFinder("osxaudio", { "osxaudio", "osx", "osxaudiosink" }) {} -QList MacOsDeviceFinder::ListDevices() { +DeviceFinder::DeviceList MacOsDeviceFinder::ListDevices() { - QList ret; + DeviceList ret; AudioObjectPropertyAddress address = { kAudioHardwarePropertyDevices, diff --git a/src/engine/macosdevicefinder.h b/src/engine/macosdevicefinder.h index fb80483ca..69fc2f394 100644 --- a/src/engine/macosdevicefinder.h +++ b/src/engine/macosdevicefinder.h @@ -23,8 +23,6 @@ #include "config.h" -#include - #include "devicefinder.h" class MacOsDeviceFinder : public DeviceFinder { @@ -32,7 +30,7 @@ class MacOsDeviceFinder : public DeviceFinder { explicit MacOsDeviceFinder(); virtual bool Initialize() { return true; } - virtual QList ListDevices(); + virtual DeviceList ListDevices(); }; #endif // MACOSDEVICEFINDER_H diff --git a/src/engine/mmdevicefinder.cpp b/src/engine/mmdevicefinder.cpp index c618ad04d..115a28b29 100644 --- a/src/engine/mmdevicefinder.cpp +++ b/src/engine/mmdevicefinder.cpp @@ -29,7 +29,6 @@ #endif #include -#include #include #include @@ -43,11 +42,11 @@ MMDeviceFinder::MMDeviceFinder() : DeviceFinder("mmdevice", { "wasapisink" }) {} -QList MMDeviceFinder::ListDevices() { +DeviceFinder::DeviceList MMDeviceFinder::ListDevices() { HRESULT hr_coinit = CoInitializeEx(NULL, COINIT_MULTITHREADED); - QList devices; + DeviceList devices; Device default_device; default_device.description = "Default device"; default_device.iconname = GuessIconName(default_device.description); diff --git a/src/engine/mmdevicefinder.h b/src/engine/mmdevicefinder.h index f41eca05e..038bd62dc 100644 --- a/src/engine/mmdevicefinder.h +++ b/src/engine/mmdevicefinder.h @@ -29,7 +29,7 @@ class MMDeviceFinder : public DeviceFinder { explicit MMDeviceFinder(); virtual bool Initialize() { return true; } - virtual QList ListDevices(); + virtual DeviceList ListDevices(); }; #endif // MMDEVICEFINDER_H diff --git a/src/engine/pulsedevicefinder.cpp b/src/engine/pulsedevicefinder.cpp index 984e1f107..c6f128b4b 100644 --- a/src/engine/pulsedevicefinder.cpp +++ b/src/engine/pulsedevicefinder.cpp @@ -80,10 +80,10 @@ bool PulseDeviceFinder::Reconnect() { } } -QList PulseDeviceFinder::ListDevices() { +DeviceFinder::DeviceList PulseDeviceFinder::ListDevices() { if (!context_ || pa_context_get_state(context_) != PA_CONTEXT_READY) { - return QList(); + return DeviceList(); } retry: diff --git a/src/engine/pulsedevicefinder.h b/src/engine/pulsedevicefinder.h index a40150bcf..9e28313cd 100644 --- a/src/engine/pulsedevicefinder.h +++ b/src/engine/pulsedevicefinder.h @@ -27,8 +27,6 @@ #include #include -#include - #include "devicefinder.h" class PulseDeviceFinder : public DeviceFinder { @@ -37,14 +35,14 @@ class PulseDeviceFinder : public DeviceFinder { ~PulseDeviceFinder() override; bool Initialize() override; - QList ListDevices() override; + DeviceList ListDevices() override; private: struct ListDevicesState { ListDevicesState() : finished(false) {} bool finished; - QList devices; + DeviceList devices; }; bool Reconnect(); diff --git a/src/engine/uwpdevicefinder.cpp b/src/engine/uwpdevicefinder.cpp index 766455945..0b689dcd1 100644 --- a/src/engine/uwpdevicefinder.cpp +++ b/src/engine/uwpdevicefinder.cpp @@ -23,7 +23,6 @@ #include #include -#include #include #include @@ -70,40 +69,40 @@ static std::string hstring_to_stdstring(HString *hstr) { } // namespace -QList UWPDeviceFinder::ListDevices() { +DeviceFinder::DeviceList UWPDeviceFinder::ListDevices() { ComPtr device_info_statics; HRESULT hr = ABI::Windows::Foundation::GetActivationFactory(HStringReference(RuntimeClass_Windows_Devices_Enumeration_DeviceInformation).Get(), &device_info_statics); if (FAILED(hr)) { - return QList(); + return DeviceList(); } ComPtr> async_op; hr = device_info_statics->FindAllAsyncDeviceClass(DeviceClass::DeviceClass_AudioRender, &async_op); device_info_statics.Reset(); if (FAILED(hr)) { - return QList(); + return DeviceList(); } hr = SyncWait(async_op.Get()); if (FAILED(hr)) { - return QList(); + return DeviceList(); } ComPtr> device_list; hr = async_op->GetResults(&device_list); async_op.Reset(); if (FAILED(hr)) { - return QList(); + return DeviceList(); } unsigned int count = 0; hr = device_list->get_Size(&count); if (FAILED(hr)) { - return QList(); + return DeviceList(); } - QList devices; + DeviceList devices; { Device default_device; diff --git a/src/engine/uwpdevicefinder.h b/src/engine/uwpdevicefinder.h index 1732d74b3..d7fdf5d6d 100644 --- a/src/engine/uwpdevicefinder.h +++ b/src/engine/uwpdevicefinder.h @@ -29,7 +29,7 @@ class UWPDeviceFinder : public DeviceFinder { explicit UWPDeviceFinder(); virtual bool Initialize() { return true; } - virtual QList ListDevices(); + virtual DeviceList ListDevices(); }; #endif // UWPDEVICEFINDER_H