From 83d3725240043cf3b9a60374dc0ea672dc3dc902 Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Wed, 10 Jul 2019 22:40:30 +0200 Subject: [PATCH] Fix MessageReply crash in tagreader --- ext/libstrawberry-common/core/messagereply.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/libstrawberry-common/core/messagereply.h b/ext/libstrawberry-common/core/messagereply.h index 5e9bf8c60..eb4847a8c 100644 --- a/ext/libstrawberry-common/core/messagereply.h +++ b/ext/libstrawberry-common/core/messagereply.h @@ -80,15 +80,18 @@ MessageReply::MessageReply(const MessageType& request_message, QObj template void MessageReply::SetReply(const MessageType& message) { + Q_ASSERT(!finished_); reply_message_.MergeFrom(message); finished_ = true; success_ = true; - emit Finished(success_); qLog(Debug) << "Releasing ID" << id() << "(finished)"; semaphore_.release(); + + emit Finished(success_); + } #endif // MESSAGEREPLY_H