Funkwhale/strawberry-audio-player-windows-mac-linux
1
0
Fork 0
mirror of https://github.com/strawberrymusicplayer/strawberry synced 2025-02-08 07:48:48 +01:00
Code Issues Releases Wiki Activity

Fix buffer overflow when coverting S24LE

Browse Source
This commit is contained in:
Jonas Kvinge 2020-07-04 01:55:36 +02:00
parent b22e8b4702
commit 7fd5c058be
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/engine/gstenginepipeline.cpp
View File

@ -630,6 +630,7 @@ GstPadProbeReturn GstEnginePipeline::HandoffCallback(GstPad *pad, GstPadProbeInf
gst_buffer_map(buf, &map_info, GST_MAP_READ); gst_buffer_map(buf, &map_info, GST_MAP_READ);
char *s24 = reinterpret_cast<char*>(map_info.data); char *s24 = reinterpret_cast<char*>(map_info.data);
char *s24e = s24 + map_info.size;
int samples = (map_info.size / sizeof(char)) / channels; int samples = (map_info.size / sizeof(char)) / channels;
int buf16_size = samples * sizeof(int16_t) * channels; int buf16_size = samples * sizeof(int16_t) * channels;
int16_t *s16 = static_cast<int16_t*>(g_malloc(buf16_size)); int16_t *s16 = static_cast<int16_t*>(g_malloc(buf16_size));
@ -637,6 +638,7 @@ GstPadProbeReturn GstEnginePipeline::HandoffCallback(GstPad *pad, GstPadProbeInf
for (int i = 0 ; i < (samples * channels) ; ++i) { for (int i = 0 ; i < (samples * channels) ; ++i) {
s16[i] = *(reinterpret_cast<int16_t*>(s24+1)); s16[i] = *(reinterpret_cast<int16_t*>(s24+1));
s24 += 3; s24 += 3;
if (s24 >= s24e) break;
} }
gst_buffer_unmap(buf, &map_info); gst_buffer_unmap(buf, &map_info);
buf16 = gst_buffer_new_wrapped(s16, buf16_size); buf16 = gst_buffer_new_wrapped(s16, buf16_size);