Funkwhale
/
strawberry-audio-player-windows-mac-linux
mirror of https://github.com/strawberrymusicplayer/strawberry
1
0
Fork 0
Code Issues Releases Wiki Activity

Song: Check that filetype is supported for writing tags 

Fixes #1413
This commit is contained in:
Jonas Kvinge 2024-04-03 20:45:52 +02:00
parent 57750efcb2
commit 7bc5579fb7
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/core/song.cpp
View File

@ -549,6 +549,26 @@ bool Song::has_valid_art() const { return art_embedded() || art_automatic_is_val
void Song::clear_art_automatic() { d->art_automatic_.clear(); }
void Song::clear_art_manual() { d->art_manual_.clear(); }
bool Song::write_tags_supported() const {
return d->filetype_ == FileType::FLAC ||
d->filetype_ == FileType::WavPack ||
d->filetype_ == FileType::OggFlac ||
d->filetype_ == FileType::OggVorbis ||
d->filetype_ == FileType::OggOpus ||
d->filetype_ == FileType::OggSpeex ||
d->filetype_ == FileType::MPEG ||
d->filetype_ == FileType::MP4 ||
d->filetype_ == FileType::ASF ||
d->filetype_ == FileType::AIFF ||
d->filetype_ == FileType::MPC ||
d->filetype_ == FileType::TrueAudio ||
d->filetype_ == FileType::APE ||
d->filetype_ == FileType::DSF ||
d->filetype_ == FileType::DSDIFF;
}
bool Song::additional_tags_supported() const {
return d->filetype_ == FileType::FLAC ||
@ -752,7 +772,7 @@ QString Song::PrettyRating() const {
}
bool Song::IsEditable() const {
return d->valid_ && d->url_.isValid() && (d->url_.isLocalFile() || d->source_ == Source::Stream) && !has_cue();
return d->valid_ && d->url_.isValid() && ((d->url_.isLocalFile() && write_tags_supported() && !has_cue()) || d->source_ == Source::Stream);
}
bool Song::IsMetadataEqual(const Song &other) const {

1
src/core/song.h
View File

@ -335,6 +335,7 @@ class Song {
void clear_art_automatic();
void clear_art_manual();
bool write_tags_supported() const;
bool additional_tags_supported() const;
bool albumartist_supported() const;
bool composer_supported() const;