From 75ab6f25f48db2153f3a9ebdf987e392aa0037ba Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Fri, 21 Jul 2023 07:12:20 +0200 Subject: [PATCH] Check return of QSqlQuery::prepare --- src/collection/collectionquery.cpp | 2 +- src/dialogs/console.cpp | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/collection/collectionquery.cpp b/src/collection/collectionquery.cpp index ced0980b..ab3c4d85 100644 --- a/src/collection/collectionquery.cpp +++ b/src/collection/collectionquery.cpp @@ -210,7 +210,7 @@ bool CollectionQuery::Exec() { sql.replace("%fts_table_noprefix", fts_table_.section('.', -1, -1)); sql.replace("%fts_table", fts_table_); - QSqlQuery::prepare(sql); + if (!QSqlQuery::prepare(sql)) return false; // Bind values for (const QVariant &value : bound_values_) { diff --git a/src/dialogs/console.cpp b/src/dialogs/console.cpp index d5c4ec5c..25966089 100644 --- a/src/dialogs/console.cpp +++ b/src/dialogs/console.cpp @@ -60,7 +60,10 @@ void Console::RunQuery() { QSqlDatabase db = app_->database()->Connect(); QSqlQuery query(db); - query.prepare(ui_.query->text()); + if (!query.prepare(ui_.query->text())) { + qLog(Error) << query.lastError(); + return; + } if (!query.exec()) { qLog(Error) << query.lastError(); return;