Funkwhale/strawberry-audio-player-windows-mac-linux
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use const reference for AlbumCoverLoaderOptions::Types

Browse Source
This commit is contained in:
Jonas Kvinge 2023-07-21 07:17:26 +02:00
parent 38b9c7c38a
commit 4b4c5fc0ab
6 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/covermanager/albumcoverexporter.cpp
View File

@ -44,7 +44,7 @@ void AlbumCoverExporter::SetDialogResult(const AlbumCoverExport::DialogResult &d
dialog_result_ = dialog_result; dialog_result_ = dialog_result;
} }
void AlbumCoverExporter::SetCoverTypes(const AlbumCoverLoaderOptions::Types cover_types) { void AlbumCoverExporter::SetCoverTypes(const AlbumCoverLoaderOptions::Types &cover_types) {
cover_types_ = cover_types; cover_types_ = cover_types;
} }

2
src/covermanager/albumcoverexporter.h
View File

@ -43,7 +43,7 @@ class AlbumCoverExporter : public QObject {
static const int kMaxConcurrentRequests; static const int kMaxConcurrentRequests;
void SetDialogResult(const AlbumCoverExport::DialogResult &dialog_result); void SetDialogResult(const AlbumCoverExport::DialogResult &dialog_result);
void SetCoverTypes(const AlbumCoverLoaderOptions::Types cover_types); void SetCoverTypes(const AlbumCoverLoaderOptions::Types &cover_types);
void AddExportRequest(const Song &song); void AddExportRequest(const Song &song);
void StartExporting(); void StartExporting();
void Cancel(); void Cancel();

2
src/covermanager/albumcoverloaderoptions.cpp
View File

@ -23,7 +23,7 @@
#include "settings/coverssettingspage.h" #include "settings/coverssettingspage.h"
AlbumCoverLoaderOptions::AlbumCoverLoaderOptions(const Options _options, const QSize _desired_scaled_size, const qreal _device_pixel_ratio, const Types _types) AlbumCoverLoaderOptions::AlbumCoverLoaderOptions(const Options _options, const QSize _desired_scaled_size, const qreal _device_pixel_ratio, const Types &_types)
: options(_options), : options(_options),
desired_scaled_size(_desired_scaled_size), desired_scaled_size(_desired_scaled_size),
device_pixel_ratio(_device_pixel_ratio), device_pixel_ratio(_device_pixel_ratio),

2
src/covermanager/albumcoverloaderoptions.h
View File

@ -43,7 +43,7 @@ class AlbumCoverLoaderOptions {
}; };
using Types = QList<Type>; using Types = QList<Type>;
explicit AlbumCoverLoaderOptions(const Options _options = AlbumCoverLoaderOptions::Option::ScaledImage, const QSize _desired_scaled_size = QSize(32, 32), const qreal device_pixel_ratio = 1.0F, const Types _types = QList<AlbumCoverLoaderOptions::Type>() << AlbumCoverLoaderOptions::Type::Embedded << AlbumCoverLoaderOptions::Type::Automatic << AlbumCoverLoaderOptions::Type::Manual); explicit AlbumCoverLoaderOptions(const Options _options = AlbumCoverLoaderOptions::Option::ScaledImage, const QSize _desired_scaled_size = QSize(32, 32), const qreal device_pixel_ratio = 1.0F, const Types &_types = QList<AlbumCoverLoaderOptions::Type>() << AlbumCoverLoaderOptions::Type::Embedded << AlbumCoverLoaderOptions::Type::Automatic << AlbumCoverLoaderOptions::Type::Manual);
Options options; Options options;
QSize desired_scaled_size; QSize desired_scaled_size;

2
src/covermanager/coverexportrunnable.cpp
View File

@ -32,7 +32,7 @@
#include "albumcoverexport.h" #include "albumcoverexport.h"
#include "coverexportrunnable.h" #include "coverexportrunnable.h"
CoverExportRunnable::CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types cover_types, const Song &song, QObject *parent) CoverExportRunnable::CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types &cover_types, const Song &song, QObject *parent)
: QObject(parent), : QObject(parent),
dialog_result_(dialog_result), dialog_result_(dialog_result),
cover_types_(cover_types), cover_types_(cover_types),

2
src/covermanager/coverexportrunnable.h
View File

@ -36,7 +36,7 @@ class CoverExportRunnable : public QObject, public QRunnable {
Q_OBJECT Q_OBJECT
public: public:
explicit CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types cover_types, const Song &song, QObject *parent = nullptr); explicit CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types &cover_types, const Song &song, QObject *parent = nullptr);
void run() override; void run() override;