From 35c7b5730861468611926ab03d9d6ac8ef2abe6b Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Fri, 13 Aug 2021 22:39:05 +0200 Subject: [PATCH] Allow fading when a ALSA PCM device is selected --- src/settings/backendsettingspage.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/settings/backendsettingspage.cpp b/src/settings/backendsettingspage.cpp index 24a975c0..6281863e 100644 --- a/src/settings/backendsettingspage.cpp +++ b/src/settings/backendsettingspage.cpp @@ -789,8 +789,10 @@ void BackendSettingsPage::FadingOptionsChanged() { if (!configloaded_ || !EngineInitialized()) return; EngineBase::OutputDetails output = ui_->combobox_output->itemData(ui_->combobox_output->currentIndex()).value(); - if (engine()->type() == Engine::GStreamer && !(engine()->ALSADeviceSupport(output.name) && !ui_->lineedit_device->text().isEmpty()) && ui_->checkbox_volume_control->isChecked()) { - ui_->groupbox_fading->setDisabled(false); + if (engine()->type() == Engine::GStreamer && + !(engine()->ALSADeviceSupport(output.name) && !ui_->lineedit_device->text().isEmpty() && (ui_->lineedit_device->text().contains(QRegularExpression("^hw:.*")) || ui_->lineedit_device->text().contains(QRegularExpression("^plughw:.*")))) && + ui_->checkbox_volume_control->isChecked()) { + ui_->groupbox_fading->setEnabled(true); } else { ui_->groupbox_fading->setDisabled(true);