Funkwhale/strawberry-audio-player-windows-mac-linux
1
0
Fork 0
mirror of https://github.com/strawberrymusicplayer/strawberry synced 2025-01-29 16:49:27 +01:00
Code Issues Releases Wiki Activity

tests: Fixed ignored return value

Browse Source
This commit is contained in:
Jonas Kvinge 2025-01-10 00:58:41 +01:00
parent 9095b0d6b2
commit 319558c535
3 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/src/songplaylistitem_test.cpp
View File

@ -47,7 +47,7 @@ class SongPlaylistItemTest : public ::testing::TestWithParam<const char*> {
void SetUp() override {
// SongPlaylistItem::Url() checks if the file exists, so we need a real file
temp_file_.open();
EXPECT_TRUE(temp_file_.open());
absolute_file_name_ = QFileInfo(temp_file_.fileName()).absoluteFilePath();

40
tests/src/tagreader_test.cpp
View File

@ -160,7 +160,7 @@ TEST_F(TagReaderTest, TestFLACAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.flac"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -168,7 +168,7 @@ TEST_F(TagReaderTest, TestFLACAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -325,7 +325,7 @@ TEST_F(TagReaderTest, TestWavPackAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.wv"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -333,7 +333,7 @@ TEST_F(TagReaderTest, TestWavPackAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -490,7 +490,7 @@ TEST_F(TagReaderTest, TestOggFLACAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.oga"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -498,7 +498,7 @@ TEST_F(TagReaderTest, TestOggFLACAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -655,7 +655,7 @@ TEST_F(TagReaderTest, TestOggVorbisAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.ogg"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -663,7 +663,7 @@ TEST_F(TagReaderTest, TestOggVorbisAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -819,7 +819,7 @@ TEST_F(TagReaderTest, TestOggOpusAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.opus"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -827,7 +827,7 @@ TEST_F(TagReaderTest, TestOggOpusAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -984,7 +984,7 @@ TEST_F(TagReaderTest, TestOggSpeexAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.spx"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -992,7 +992,7 @@ TEST_F(TagReaderTest, TestOggSpeexAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -1149,7 +1149,7 @@ TEST_F(TagReaderTest, TestAIFFAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.aif"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -1157,7 +1157,7 @@ TEST_F(TagReaderTest, TestAIFFAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -1314,7 +1314,7 @@ TEST_F(TagReaderTest, TestASFAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.asf"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -1322,7 +1322,7 @@ TEST_F(TagReaderTest, TestASFAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -1480,7 +1480,7 @@ TEST_F(TagReaderTest, TestMP3AudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.mp3"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -1488,7 +1488,7 @@ TEST_F(TagReaderTest, TestMP3AudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();
@ -1645,7 +1645,7 @@ TEST_F(TagReaderTest, TestM4AAudioFileTagging) {
QByteArray temp_file_data;
{
QFile orig_file(u":/audio/strawberry.m4a"_s);
orig_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(orig_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(orig_file.isOpen());
orig_file_data = orig_file.readAll();
orig_file.close();
@ -1653,7 +1653,7 @@ TEST_F(TagReaderTest, TestM4AAudioFileTagging) {
{
QFile temp_file(r.fileName());
temp_file.open(QIODevice::ReadOnly);
EXPECT_TRUE(temp_file.open(QIODevice::ReadOnly));
EXPECT_TRUE(temp_file.isOpen());
temp_file_data = temp_file.readAll();
temp_file.close();

4
tests/src/test_utils.cpp
View File

@ -65,10 +65,10 @@ void PrintTo(const ::QUrl &url, std::ostream &os) {
TemporaryResource::TemporaryResource(const QString &filename, QObject *parent) : QTemporaryFile(parent) {
setFileTemplate(QDir::tempPath() + u"/strawberry_test-XXXXXX."_s + filename.section(u'.', -1, -1));
open();
Q_ASSERT(open());
QFile resource(filename);
resource.open(QIODevice::ReadOnly);
Q_ASSERT(resource.open(QIODevice::ReadOnly));
write(resource.readAll());
reset();