From 264065a355413803104622c5665fa3692b7ee9f7 Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 19 Mar 2023 20:42:30 +0100 Subject: [PATCH] TagreaderGME: Don't call QByteArray::operator[]() on temporary --- ext/libstrawberry-tagreader/tagreadergme.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/libstrawberry-tagreader/tagreadergme.cpp b/ext/libstrawberry-tagreader/tagreadergme.cpp index d4544215..f2907cf5 100644 --- a/ext/libstrawberry-tagreader/tagreadergme.cpp +++ b/ext/libstrawberry-tagreader/tagreadergme.cpp @@ -84,7 +84,8 @@ void GME::SPC::Read(const QFileInfo &file_info, spb::tagreader::SongMetadata *so // Make sure to check id6 documentation before changing the read values! file.seek(HAS_ID6_OFFSET); - bool has_id6 = (file.read(1)[0] == static_cast(xID6_STATUS::ON)); + const QByteArray id6_status = file.read(1); + const bool has_id6 = id6_status.length() >= 1 && id6_status[0] == static_cast(xID6_STATUS::ON); file.seek(SONG_TITLE_OFFSET); song_info->set_title(QString::fromLatin1(file.read(32)).toStdString());