From 129587e94ade604d607a99dd3ed16f886c90b5e8 Mon Sep 17 00:00:00 2001
From: Jonas Kvinge <jonas@jkvinge.net>
Date: Thu, 12 Jan 2023 23:36:34 +0100
Subject: [PATCH] TranscoderOptionsMP3: Change default settings

---
 src/transcoder/transcoderoptionsmp3.cpp | 12 ++++++------
 src/transcoder/transcoderoptionsmp3.h   |  4 ++--
 src/transcoder/transcoderoptionsmp3.ui  | 15 +++++++++------
 3 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/transcoder/transcoderoptionsmp3.cpp b/src/transcoder/transcoderoptionsmp3.cpp
index d47c236d..4cee0893 100644
--- a/src/transcoder/transcoderoptionsmp3.cpp
+++ b/src/transcoder/transcoderoptionsmp3.cpp
@@ -60,10 +60,10 @@ void TranscoderOptionsMP3::Load() {
     ui_->target_bitrate->setChecked(true);
   }
 
-  ui_->quality_spinbox->setValue(s.value("quality", 10).toFloat());
+  ui_->quality_spinbox->setValue(s.value("quality", 10.0F).toFloat());
   ui_->bitrate_slider->setValue(s.value("bitrate", 320).toInt());
   ui_->cbr->setChecked(s.value("cbr", false).toBool());
-  ui_->encoding_engine_quality->setCurrentIndex(s.value("encoding-engine-quality", 1).toInt());
+  ui_->encoding_engine_quality->setCurrentIndex(s.value("encoding-engine-quality", 2).toInt());
   ui_->mono->setChecked(s.value("mono", false).toBool());
 
   s.endGroup();
@@ -86,10 +86,10 @@ void TranscoderOptionsMP3::Save() {
 
 }
 
-void TranscoderOptionsMP3::QualitySliderChanged(int value) {
-  ui_->quality_spinbox->setValue(static_cast<float>(value) / 100);
+void TranscoderOptionsMP3::QualitySliderChanged(const int value) {
+  ui_->quality_spinbox->setValue(static_cast<float>(value) / 100.0);
 }
 
-void TranscoderOptionsMP3::QualitySpinboxChanged(double value) {
-  ui_->quality_slider->setValue(static_cast<int>(value * 100));
+void TranscoderOptionsMP3::QualitySpinboxChanged(const double value) {
+  ui_->quality_slider->setValue(static_cast<int>(value * 100.0));
 }
diff --git a/src/transcoder/transcoderoptionsmp3.h b/src/transcoder/transcoderoptionsmp3.h
index a63ec276..b3660437 100644
--- a/src/transcoder/transcoderoptionsmp3.h
+++ b/src/transcoder/transcoderoptionsmp3.h
@@ -42,8 +42,8 @@ class TranscoderOptionsMP3 : public TranscoderOptionsInterface {
   void Save() override;
 
  private slots:
-  void QualitySliderChanged(int value);
-  void QualitySpinboxChanged(double value);
+  void QualitySliderChanged(const int value);
+  void QualitySpinboxChanged(const double value);
 
  private:
   static const char *kSettingsGroup;
diff --git a/src/transcoder/transcoderoptionsmp3.ui b/src/transcoder/transcoderoptionsmp3.ui
index 2d133795..6aae395a 100644
--- a/src/transcoder/transcoderoptionsmp3.ui
+++ b/src/transcoder/transcoderoptionsmp3.ui
@@ -54,10 +54,10 @@
         <item>
          <widget class="QSlider" name="quality_slider">
           <property name="maximum">
-           <number>999</number>
+           <number>1000</number>
           </property>
           <property name="value">
-           <number>400</number>
+           <number>1000</number>
           </property>
           <property name="orientation">
            <enum>Qt::Horizontal</enum>
@@ -72,11 +72,14 @@
         </item>
         <item>
          <widget class="QDoubleSpinBox" name="quality_spinbox">
+          <property name="minimum">
+           <double>0.000000000000000</double>
+          </property>
           <property name="maximum">
-           <double>9.990000000000000</double>
+           <double>10.000000000000000</double>
           </property>
           <property name="value">
-           <double>4.000000000000000</double>
+           <double>10.000000000000000</double>
           </property>
          </widget>
         </item>
@@ -128,7 +131,7 @@
            <number>320</number>
           </property>
           <property name="value">
-           <number>128</number>
+           <number>320</number>
           </property>
           <property name="orientation">
            <enum>Qt::Horizontal</enum>
@@ -156,7 +159,7 @@
            <number>8</number>
           </property>
           <property name="value">
-           <number>128</number>
+           <number>320</number>
           </property>
          </widget>
         </item>