Funkwhale
/
strawberry-audio-player-windows-mac-linux
mirror of https://github.com/strawberrymusicplayer/strawberry
1
0
Fork 0
Code Issues Releases Wiki Activity

CONTRIBUTING: Clarify "Commit messages" section. 

Specifically:
- Clarify what "class" is referring to
- Use an actual example, which requires moving out two bits of explanation
This commit is contained in:
William Andrea 2024-01-09 17:54:51 -05:00 committed by Jonas Kvinge
parent f901f802bb
commit 11061bdd07
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
CONTRIBUTING.md
View File

@ -48,24 +48,27 @@ small as possible.
### Commit messages ### Commit messages
The first line should start with "Class:", which referer to the class The first line should start with the name of the class that is changed
that is changed. Don't use a trailing period after the first line. followed by a colon then a short explanation of the commit.
If this change affects more than one class, omit the class and write a Don't use a trailing period after the first line.
If this change affects more than one class, omit the class name and write a
more general message. more general message.
You only need to include a main description (body) for larger changes You only need to include a main description (body) for larger changes
where the one line is not enough to describe everything. where the one line is not enough to describe everything.
The main description starts after two newlines, it is normal prose and The main description starts after two newlines, it is normal prose and
should use normal punctuation and capital letters where appropriate. should use normal punctuation and capital letters where appropriate.
It should explain exactly what's changed, why it's changed,
and what bugs were fixed.
An example of the expected format for git commit messages is as follows: An example of the expected format for git commit messages is as follows:
``` ```
class: Short explanation of the commit StretchHeaderView: Set default section size
Longer explanation explaining exactly what's changed, why it's changed, As of Qt 6.6.1, style changes are resetting the column sizes. To prevent this, we set a default section size.
and what bugs were fixed.
Fixes #1234 Fixes #1328
``` ```