e8c2b4b267
Fix missing buffers sent to analyzer
...
This is a regression in the upgrade to gstreamer1.0.
The gst_buffer_unref() is incorrect as it removes the buffer when it is still needed by the chunker.
Forcing the pointer to be null prevents it from segfaulting but causes it to skip all chunks in the buffer, dropping the framerate and causing a worse case of #4321 .
Removing these 2 lines restores original functionality.
2014-10-03 20:53:07 -04:00
51667c77ad
Update the database total size of Jamendo catalogue. Fixes #4554
2014-10-03 13:17:12 +02:00
66b2d996d3
Install qt framework Info.plists correctly.
2014-10-01 15:32:31 +02:00
b4784e82fd
Make Soup check SSL against our shipped root certs.
2014-10-01 15:06:22 +02:00
96387803cd
Disable this Spotify hack for now, as it is useless anyway.
...
Somewhat related to issue #4545 , but when plugin was installed by user wasn't logged in.
2014-09-30 21:35:27 +02:00
a667dceb29
Check if the blob is availabe in Spotify search provider.
2014-09-29 18:44:20 +02:00
40a5590108
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-29 10:01:34 +02:00
fdb88d4738
Fixed formatting for merge.
2014-09-28 19:34:28 -04:00
72cfa126ac
Fix a bug that makes Vk to be always displayed when trying to show any service's config.
...
Call stack: SettingsDialog::showEvent -> VkSettingsPage::Load -> VkService::ReloadSettings -> VkService::Logout -> VkService::UpdateRoot -> VkService::ShowConfig
Would probably be better to not call service in VkSettingsPage::Load and read QSettings only, but I don't think it's good either to call ShowConfig when user is being logged-out.
2014-09-28 02:13:56 +02:00
f81fa2d119
Add the ability to remove tracks from Spotify playlists
2014-09-28 02:00:32 +02:00
442d126b03
Hack to make the C++11 override keyword work with old compilers.
2014-09-26 20:33:02 +10:00
8b19b300b5
Stop using some C++11 features not supported by g++ 4.6.4 on Ubuntu 12.04
2014-09-26 11:43:54 +02:00
7b651136d8
Use the system's sha2 library if it's available. Fixes #4217
2014-09-25 23:51:46 +10:00
389d2972f5
Use decodebin in the transcoder (decodebin2 doesn't exist in gst-1.0).
2014-09-25 23:51:45 +10:00
3587e4197d
Renamed rootPath to just path, changed dialog message to reflect UI message.
2014-09-24 19:53:13 -04:00
e77c520ddd
Merge branch 'master' of github.com:clementine-player/Clementine
2014-09-22 22:43:15 +02:00
39db4dbefe
Add the ability to add a Spotify track to a Spotify playlist through context menu.
...
TODO: drag and drop (i.e. implement DropMimeData), update special playlist (Favorites), remove from playlist.
2014-09-22 22:40:21 +02:00
4bb3147006
Fix Spotify Blob installation promt. Fixes #4538 .
2014-09-22 21:20:48 +02:00
60d82e212d
Merge branch 'master' of github.com:clementine-player/Clementine
2014-09-22 19:32:18 +02:00
eaad4c32ee
Merge branch 'gstreamer-1.2'
...
Fixes #3332
2014-09-22 22:45:28 +10:00
39d99247a2
gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
...
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
763ee3df8d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-22 10:01:32 +02:00
c891a44243
Remove useless check
2014-09-21 20:48:42 +02:00
bb08a0f416
Fix misleading offset_bytes names
2014-09-22 00:13:00 +10:00
3f0dc01b06
Make Spotify work with gstreamer-1.0.
2014-09-21 22:39:30 +10:00
a2408f7c0e
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
src/moodbar/moodbarloader.cpp
2014-09-21 19:39:27 +10:00
d24eaef2e5
Don't crash if we can't write to the moodbar cache
2014-09-21 19:38:14 +10:00
6b32ecec27
Various bits for gstreamer-1.0 compatability
2014-09-21 19:38:13 +10:00
50551d987a
Rewrite moodbar stuff for gstreamer-1.0:
...
- Rewrite gstspectrum (1.0) to use FFTW (2x faster) and emit raw magnitude
values (not log scaled).
- Rewrite the moodbar generation code to be somewhat understandable, and
do it in Clementine instead of gstreamer.
2014-09-21 19:38:13 +10:00
38c51508f2
Added a preference to disable the pause notification. Fixes #2450 .
2014-09-16 12:54:35 +02:00
431f2e2978
Changed the transcode import tooltip and reimplemented using QDirIterator.
2014-09-15 16:45:47 -04:00
f3ec15cda3
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-15 10:01:36 +02:00
bfaf127ed7
Remove few Ubuntu One things remaining
2014-09-14 21:43:13 +02:00
3e17a0adb5
Remove dead code
2014-09-14 02:39:35 +02:00
160b151652
Add seek ability to Spotify tracks.
...
This is functional but pretty hacky.
And, as noted in the comments, there is a small delay (depends, but usually several seconds) to have the seek taken into account. But IMHO it's better than nothing.
Fixes #2503
2014-09-14 02:15:58 +02:00
bc1d56f935
When clicking on a provider, on the global search result list, add all results from this provider to the playlist.
...
Fixes issue 3132.
2014-09-13 22:57:58 +02:00
8be65b8565
Better check (avoid to add invalid results, leading to a crash when adding this invalid item).
...
Fixes issue 3132, but I would like to improve this in a second step: clicking the provider adding all the songs for this provider to the playlist.
2014-09-13 21:31:33 +02:00
f54e2da535
Adds an import button to the transcode UI, allowing the user to pull in all files in a folder heirarchy to be transcoded.
2014-09-09 20:21:54 -04:00
b3f838216f
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-08 10:01:55 +02:00
cbc6e5cf4d
Pause spotify track (issue 2503)
...
(patch slightly modified, not sure why it wasn't applied before: it looks good to me)
2014-09-06 19:21:23 +02:00
631c120515
Allow to change rating when "inline" editing is not enabled
2014-09-06 17:54:50 +02:00
d61688e1c5
QUrl fix.
2014-09-04 18:48:49 +06:00
2dfb7f8f4c
Increase cover image size.
2014-09-04 18:08:17 +06:00
e8fbff4382
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-01 10:01:38 +02:00
3d10c86863
Merge pull request #4499 from ppkt/remove_dead_items
...
Remove unavailable items from playlist
2014-08-27 16:38:33 +01:00
e5df59aeb2
Fix for m3u parser bug when an artist's name had a hyphen.
2014-08-27 02:21:11 -06:00
40b5499fc9
Merge pull request #4502 from gavinhoward/library_sort
...
Ignore Articles for Library Sorting
2014-08-26 18:04:40 +01:00
0e030b5461
Ran make format.
2014-08-26 10:54:05 -06:00
54742de613
A quick patch to have the library ignore all articles when sorting.
2014-08-25 21:22:53 -06:00
e44f19f5c4
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-08-25 10:01:35 +02:00
43a6740b48
Remove unavailable items from playlist
2014-08-24 10:44:27 +02:00
13cda62c5c
Merge pull request #4497 from gavinhoward/playlist_save
...
Playlist Save UI Fixes
2014-08-20 23:16:58 +02:00
eb953bdef2
Changed UI messages per Arnaud Bienner's suggestions.
2014-08-20 00:30:49 -06:00
fbb43468a4
Merge pull request #4495 from gavinhoward/playlist_save
...
Playlist Save Fixes
2014-08-19 22:35:26 +02:00
9141cd65bc
Fixes requested by ArnaudBienner.
2014-08-19 13:26:00 -06:00
d9572bdcdd
Be more forgiving of broken permissions on the cache directory.
2014-08-19 11:13:06 +02:00
96f7fb31d1
Merge pull request #4489 from gavinhoward/playlist_save
...
Playlist Save Preferences 2
2014-08-19 10:59:32 +02:00
f41bebbeb2
Ran 'make format' on my patch.
2014-08-18 09:56:01 -06:00
d8ba0c4f91
Minor changes requested by hatstand.
2014-08-18 08:08:14 -06:00
784721f8bc
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-08-18 10:01:34 +02:00
a468085c3a
Finished the changes to the quick change menu. Everything should work.
2014-08-15 18:52:01 -06:00
1cddc696ae
Add a quick change menu to the playlist container.
2014-08-15 15:37:31 -06:00
c026b599b4
Finish the last of my Playlist path preferences patch.
2014-08-13 22:47:26 -06:00
a0bbe2cfaf
Quick try to get metadata working on XSPF and M3U.
2014-08-13 22:47:26 -06:00
0efb23994d
Hopefully this finishes the path part of playlist preferences.
2014-08-13 22:47:26 -06:00
e8d3aa9254
Slight change to the QSettings keys for playlist paths and metadata.
2014-08-13 22:47:26 -06:00
5b7819f14d
Added UI and QSettings support for playlist metadata and path types.
2014-08-13 22:47:25 -06:00
ba3998e79b
Merge pull request #4465 from Mikah89/fix_album_shuffle_issue
...
Fix album shuffle issue
2014-08-13 10:16:28 +02:00
7a46629d97
Fix a stupid missed semicolon
...
I appear to be suffering from too much Python...
2014-08-12 21:36:00 +01:00
e876df1b23
Merge pull request #4456 from Shedward/vk-broadcasting
...
Vk.com broadcasting.
2014-08-12 22:04:45 +02:00
08c0f7d28f
Fix misspelled names.
2014-08-13 02:15:33 +07:00
054749b690
Merge pull request #4479 from alanbriolat/playlist-path-separators
...
Always convert path separators when reading playlists (fixes #1838 )
2014-08-12 14:30:59 +02:00
c02ea88bfe
Always convert path separators when reading playlists ( fixes #1838 )
2014-08-12 13:01:59 +01:00
a0c890592f
Fix detection of parent-relative paths in playlist saving
...
File or directory names containing ``..`` caused saved playlists to
contain absolute paths instead of relative paths even when the relative
path was "safe". This changes the detection to be more strict.
Potentially related to #4463 .
2014-08-12 11:40:20 +01:00
8b5a6eb1f8
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-08-11 10:01:34 +02:00
57ad86064d
Limit the MusicBrainz requests by track.
...
3 should be enough. It's unlikely that the other ids will be really revelant.
2014-08-11 00:37:02 +02:00
9b8d09061f
We should not sort result from Musicbrainz: they seem to be already sorted by relevance.
2014-08-10 14:23:07 +02:00
80d272f3d0
None was OK to achieve what I want. Should be better now
2014-08-10 14:22:42 +02:00
bc7bc9910d
Actually, I was wrong modifying UniqueResults. We should just not sort the results at the end, to keep the initial order we wanted
2014-08-10 13:20:11 +02:00
93b4b2caac
Get more results from MusicBrainz, and sort them by relevance.
...
We were stopping at the first one in AcoustidClient::RequestFinished.
To make things worse, it seems that results we received weren't sorted, so we sometimes ignored the most relevant one.
2014-08-09 01:48:35 +02:00
47108a9a68
Add a message in CMake to notify that ccache has been found and will be used (+ some minor, unrelated things).
2014-08-06 20:05:41 +02:00
4d9e500fe1
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-08-04 10:01:39 +02:00
e65596cba6
make format
2014-08-03 19:40:06 +07:00
bff79664bc
Broadcasting realisation.
2014-08-03 19:10:09 +07:00
e4054fad5e
Clarified comment to be more accurate of what it does
2014-08-03 10:48:01 +01:00
e62b603826
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-07-28 10:01:39 +02:00
56fc242520
complemented condition inside reshuffleindices function to take into account the selected track
2014-07-27 23:07:50 +01:00
0976cc7e5c
Give Clementine the answer to the ultimate question of life, the universe and everything
...
Probably my most valuable contribution so far
2014-07-24 23:48:45 +02:00
cbfd3218f2
Cleaning unnecessary code
2014-07-23 23:47:12 +01:00
0c2d4e9f1c
Fixed a minor issue where the playlist wasnt updating the queue order, when a track was dequeued using the ctrl-d shortcut
2014-07-23 00:15:06 +01:00
bc754e0a26
Merge pull request #4440 from Chocobozzz/master
...
No namespaces for DBus interfaces. Fixes #4401
2014-07-21 13:36:09 +02:00
d600685c0b
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-07-21 10:01:43 +02:00
82a8c64ac8
Add ampache compatibility
2014-07-16 18:49:58 +02:00
ec580cb815
No namespaces for DBus interfaces. Fixes #4401
2014-07-16 15:57:25 +02:00
793dfe3676
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-07-07 10:01:45 +02:00
40431b7616
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-06-30 10:01:48 +02:00
80009ea260
Add a tooltip to this new option. IMO the text description might be not obvious enough to everyone
2014-06-24 21:42:34 +02:00
9095c8744d
Merge pull request #4416 from alecksphillips/click-show-cover
...
Added left-click to show fullsize cover on NowPlayingWidget.
2014-06-24 15:19:49 +02:00
843029b334
Changes as requested
...
Removed unnecessary () and changed to hypnotoad_.get()
2014-06-24 11:17:46 +01:00
62ecfe19f7
Add an option to disable inline song metadata editing through click
2014-06-23 18:40:00 +02:00
a9c944e42a
Added left-click to show fullsize cover on NowPlayingWidget.
...
This intuitively mirrors the behaviour of clicking an image in the Artist Info page
2014-06-22 18:18:23 +01:00
03eb241c00
Add header for std::pow
2014-06-19 15:34:10 +02:00
d5617c0daf
Set the media role for pulse audio
2014-06-19 22:51:58 +10:00
a8c2537056
RainbowDash analyzer now more pretty
2014-06-18 23:37:43 +06:00
60ae9e9408
Now Bar Analyzer respects color scheme
2014-06-18 21:55:29 +06:00
e0920054a9
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-06-16 10:01:47 +02:00
554e1bcc4d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-06-09 10:01:48 +02:00
6bb81328e8
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
ext/clementine-spotifyblob/mediapipeline.cpp
gst/moodbar/gstfftwspectrum.c
src/core/songloader.cpp
src/core/songloader.h
src/engines/gstengine.cpp
src/engines/gstenginepipeline.cpp
src/moodbar/moodbarpipeline.cpp
src/musicbrainz/chromaprinter.cpp
src/transcoder/transcoder.cpp
src/ui/mainwindow.cpp
src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
0cd3d9b34f
Don't do seafile stuff unless signed in.
2014-06-07 15:29:28 +10:00
01ae151f8a
Delay writing WMA ratings and play counts until playback has finished. Fixes #3593
2014-06-07 15:29:23 +10:00
f6a72828a9
Write statistics and ratings in Library, not LibraryBackend.
2014-06-07 15:19:43 +10:00
c8625deffb
Update persistent model indexes properly when sorting the playlist. Fixes #4358
2014-06-07 13:31:25 +10:00
bfc941bb7f
Use a better colour for labels in the edit tag dialog on dark themes. Fixes #4377
2014-06-07 12:48:32 +10:00
53be1e1f65
Revert "Use guaranteed random number generator." Fixes #4400
...
This reverts commit 9f6899ac82
2014-06-07 12:12:08 +10:00
96ad4554d9
Merge pull request #4392 from Chocobozzz/master
...
Add Seafile Support
2014-06-05 16:50:45 +02:00
571ffdff1d
delete another delegating constructor
2014-06-05 16:34:15 +02:00
09acc2336f
Delete the delegating constructors (entry and treeitem)
2014-06-05 14:24:06 +02:00
c03c0def19
Add menu items for updating and doing a full rescan of Google Drive
2014-06-05 20:20:58 +10:00
f14ec51a60
add constant for max tries and correct memory leaks
2014-06-04 18:44:23 +02:00
e484306631
Correction after hatstand's review
2014-06-04 17:58:28 +02:00
1fc95cb7ed
Add Seafile Support
2014-06-03 14:33:07 +02:00
fd7daf2839
deleting track/disc/year in the spinbox should correct to the nearest
...
value and not to the last digit
2014-06-02 22:38:42 +02:00
838da7f790
Merge pull request #4375 from paperbagcorner/fix-musicbrainz
...
Fix parsing of MusicBrainz data for discid
2014-06-02 16:45:06 +02:00
ac162c3477
Move qRegisterMetaType back to SetUpTestCase(). Add comment
...
regarding ownership of the optional argument to MusicBrainzClient().
2014-06-02 16:34:03 +02:00
ae1d26d7b7
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-06-02 10:01:57 +02:00
1e3cfb0a2c
Don't try to update the scope if there's no buffer yet. Fixes #4388
2014-06-02 12:46:45 +10:00
e72cd6648a
Set a minimum height on the equaliser sliders. Fixes #4380
2014-06-01 20:45:14 +10:00
162b2efbb0
If we don't know the length of a song from the metadata, get it from the pipeline which has the real length. Fixes #2818 when the length isn't in the podcast metadata.
2014-05-29 21:33:53 +10:00
d99f4032b3
Do case insensitive comparisons on XML namespaces in podcasts. Fixes parsing of the length field in some (most?) podcasts. Fixes #2818 .
2014-05-29 21:11:49 +10:00
453a012f21
Make it impossible to collapse either side of the MainWindow splitter. Fixes #4384
2014-05-29 20:43:43 +10:00
c8661541a4
Merge pull request #4383 from TheUbuntuGuy/libcache
...
Fix memory leak in pixmap disk cache
2014-05-29 07:57:41 +10:00
b463f32459
Fix memory leak in pixmap disk cache
2014-05-28 17:30:07 -04:00
acaa374139
Merge pull request #4382 from TheUbuntuGuy/libcache
...
Add persistent disk cache for library pixmaps. Fixes #4379
2014-05-28 14:55:51 +10:00
b2bd7828c4
More style changes
2014-05-27 20:18:24 -04:00
94b391e0c9
Optimizations and style changes
2014-05-27 18:21:30 -04:00
2332a74bbe
Add persistent disk cache for library pixmaps
...
I'll reference #4379
When viewing the library with album covers visible, the covers load very slowly the first time
as they have to wait on the tagreaders. If I scroll down the library, it takes minutes for the
tagreader to catch up. The nice thing is that the pixmaps are cached. However, once
Clementine is restarted, the whole process has to happen again.
This patch adds a persistent disk cache in the form of a QNetworkDiskCache to store the
pixmaps on disk and load them into the QPixmapCache as required.
I've noted literally night and day performance improvements, not only when scrolling through the library.
There is much better interface responsiveness when searching, and I no longer see the no_cover_icon
temporarily anymore.
2014-05-27 17:40:25 -04:00
f9be68a3a1
Merge pull request #4376 from TheUbuntuGuy/master
...
Fix dbz possibility in moodbar
2014-05-27 12:33:07 +02:00
26014890e9
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-05-26 10:01:56 +02:00
134b617ec4
Emit dataChanged when changing skip track state.
...
Otherwise, when changing this for the currently playing track, the "strike out" change wasn't visible.
2014-05-25 18:44:54 +02:00
af42ccea38
Fix dbz possibility in moodbar
...
Took me forever to find this. Randomly happens when changing tracks.
2014-05-25 00:16:12 -04:00
0be0498e94
Reset the model during init of CddaDevice
...
This ensures that the track list in the device tab is correctly updated when a
disc is replaced with one that doesn't exist in the MusicBrainz database.
2014-05-24 13:54:07 +02:00
68d445fed2
Parse discid xml from MusicBrainz correctly. Fixes #4025 .
2014-05-24 13:54:07 +02:00
e14c59948f
Add test for MusicBrainzClient.
2014-05-24 13:54:07 +02:00
f65c48ef9c
Fix the rendering of the little numbers in the boxes on queued items in the playlist
2014-05-24 14:05:21 +10:00
96dd87a4f3
Treat trashed files as deleted. Fixes #4374
2014-05-24 13:48:45 +10:00
5f05353939
Change Name to Action in the Configure Shortcuts settings page. Fixes #4310
2014-05-24 13:29:46 +10:00
c217450d0c
Fix some bad sizeof -> arraysize changes from revision 41e9c15248.
2014-05-23 21:31:50 +10:00
c404552682
Fix random artifacting on nyanalyzer on startup
...
memset works on bytes, not the source datatype width
2014-05-23 07:20:13 -04:00
0dae8ecf27
Merge pull request #4367 from TheUbuntuGuy/master
...
Add new analyzer "Rainbow Dash"
2014-05-22 16:00:47 +01:00
f2a1defa2a
Make sizeof more generic
2014-05-22 10:58:08 -04:00
Mark Furneaux
Chocobozzz
John Maguire
Arnaud Bienner
Andreas
Clementine Buildbot
Matthew Scheirer
David Sansome
pie.or.paj
maximko
Gavin Howard
ppkt
Alan Briolat
Vlad Maltsev
Helder Martins
Chocobozzz
alecksphillips
Gu1
Alibek Omarov
Chocobozzz
Narfinger
Mattias Andersson