Martin Babutzka
0b16dad50f
- Fixed decoding of non-ASCII lyric texts
...
- Lyrics can now be viewed/edited in the metadata-editor
Squashed commit of the following:
commit 0851f619c27348e3ceeaf31a8edc3a567ccee99c
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Wed Jun 10 21:21:50 2015 +0200
'make format' and brackets in a condition clause.
commit bab7a1d07af3bc53034e3883d352ae6d4dd33e2a
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sun Jun 7 01:51:31 2015 +0200
Added capability to SAVE lyrics frames to mp3 files in tagreader.
Improved scaling properties of edittags dialog.
commit 4bd71a2d6a4479a664bf8b5b3ead05c23c86e15d
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sat Jun 6 23:33:22 2015 +0200
Updated lyrics tag buddy to lyrics
commit 2ceb8967f67e76a0f78b25a7a128c4429a93bcd9
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sun May 17 18:52:33 2015 +0200
Add lyrics field to tag editor
commit 04b65e33a83e449055659a72a283954311a12fb7
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Fri May 8 23:24:02 2015 +0200
Using decode method to fix non-ASCII letters.
2015-06-10 21:23:40 +02:00
Chocobozzz
b96c1f060f
Add tests to check the tag edition of FLAC/OGG files and make format
2015-01-17 12:11:33 +01:00
Chocobozzz
2a7d4e6d5e
Improve edit tag when set values
2015-01-17 11:31:02 +01:00
David Sansome
bfc941bb7f
Use a better colour for labels in the edit tag dialog on dark themes. Fixes #4377
2014-06-07 12:48:32 +10:00
John Maguire
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire
5469c0469e
Merge pull request #4192 from pejakm/trfixes
...
[EditTag Dialog] Fix not displaying translated string
2014-02-07 17:21:55 +01:00
Mladen Pejaković
4c534e54ec
[EdiTag Dialog] Fix not displaying translated string
2014-02-07 17:10:53 +01:00
Krzysztof A. Sobiecki
0ecf1e76a6
Reformat done with clang-3.5 svn200967
2014-02-07 17:08:31 +01:00
John Maguire
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
Uwe Klotz
a6d3b48231
Extend tag support: performer, grouping
...
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.
Fixes issue 2556
2013-03-10 18:16:03 +11:00
David Sansome
e3c8caa613
Preserve user stats like play/skip counts when reloading song metadata when opening the edit tag dialog. Fixes issue 3359.
2012-12-26 00:50:32 +11:00
David Sansome
413f3b5186
Scale the missing cover image in the Edit Tag dialog, and don't overwrite the art_automatic field when reloading metadata.
2012-06-17 16:55:19 +01:00
David Sansome
5b40338257
Oops - update the year as well when completing tags automatically. Fixes issue 2779
2012-03-04 13:51:08 +00:00
David Sansome
a315bb41f6
Fix a crash when changing a song's rating in the edit tag dialog. Fixes issue 2773
2012-03-04 13:36:22 +00:00
David Sansome
bacef04405
Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader.
2012-02-26 14:40:51 +00:00
David Sansome
48f15c9fc7
Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere.
2012-02-26 14:40:51 +00:00
David Sansome
101195d1a2
Show shortcut key tooltips on the next/previous buttons in the edit tag dialog. Fixes issue 2550
2012-01-29 19:32:36 +00:00
David Sansome
281d69581c
Add Edit file information and Show in file browser actions to the files view. Fixes issue 2559
2012-01-29 18:44:00 +00:00
David Sansome
4618651cf4
Merge branch 'master' into external-tagreader
2012-01-07 22:52:18 +00:00
David Sansome
9be641ee87
The external tagreader mostly works now:
...
* Make TagReaderClient a singleton until it's easier to pass dependencies around
* Add a WaitForSignal() that uses a local event loop to wait for a signal to be emitted
* Add a WaitForFinished() to _MessageReplyBase that blocks using a semaphore
* Add blocking versions of all TagReaderClient methods
* Use the TagReaderClient everywhere that Song::InitFromFile and friends were used before
2012-01-07 00:26:07 +00:00
John Maguire
f241124b1d
Remove old OFA fingerprinter.
2012-01-06 16:40:08 +00:00
David Sansome
0edb8abc7a
Save the last used tab in the edit tag dialog in QSettings so it's shared between instances. Fixes issue 2260
2011-11-27 20:37:22 +00:00
David Sansome
f6750202b1
Don't forget which tab was selected in the edit tag dialog. QTabWidget takes care of enabled/disabled state
...
Fixes issue 2260
2011-11-13 00:53:39 +00:00
David Sansome
143bbb4019
Make the BusyIndicator contain a label too
2011-08-27 15:03:04 +01:00
David Sansome
38100f5e59
Make CoverProviders not a singleton
2011-07-23 19:34:41 +01:00
David Sansome
62bd3694ec
Remove cover provider factories and refactor everything else to use cover providers directly instead.
2011-06-19 23:15:51 +00:00
Paweł Bara
d1d177769a
cover providers are now recreated every search (this will lead to simpler API of theirs in a moment)
...
initial migration from SIP -> PythonQt in cover providers
2011-05-17 17:53:36 +00:00
David Sansome
ccb9f8cf94
Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests.
2011-04-28 12:27:53 +00:00
Paweł Bara
fdda938c53
now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users
2011-04-27 19:10:37 +00:00
David Sansome
3eedc916ad
Add a new logging system
2011-04-22 16:50:29 +00:00
Paweł Bara
032b5f7e48
initial commit of "multiple covers providers" feature:
...
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00
David Sansome
cf826aeee0
Support dragging and dropping image files onto the now playing widget and edit tag dialog to set an album's cover art
2011-03-14 20:01:27 +00:00
David Sansome
8690438ad4
Cancel network requests and outstanding fingerprint operations when cancelling musicbrainz lookups
2011-03-13 12:52:08 +00:00
David Sansome
1fb7dae446
Show a helpful error if the gstofa plugin isn't available
2011-03-12 22:29:13 +00:00
David Sansome
b51566cdd9
Remove the dependencies on libtunepimp, libofa, libmusicbrainz. Use the gstreamer ofa plugin instead to fingerprint songs.
2011-03-12 21:19:41 +00:00
David Sansome
c2445edad5
Add a "complete tags automatically" shortcut to the playlist context menu. Fixes issue #1532
2011-03-06 14:07:41 +00:00
David Sansome
4a020c0c04
Add support for fetching tags for multiple songs at once. Fixes issue #1399
2011-03-05 19:24:44 +00:00
David Sansome
507c5e2632
Change the fields in Song from seconds to nanoseconds
2011-02-13 18:34:30 +00:00
Paweł Bara
77151d7ebd
Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers).
2011-02-02 21:01:08 +00:00
Paweł Bara
8aedda1795
moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
...
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Arnaud Bienner
9159e3c47e
Oups... miss to also correct this
2011-01-29 16:11:20 +00:00
Arnaud Bienner
8b681a5dd2
Allow autotagging for non-library music files. Fixes issue 1389
2011-01-29 16:02:23 +00:00
Paweł Bara
2fec795b89
fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
...
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
Paweł Bara
4a9d38bbdd
final refactoring stage of cover changing code (common QAction*s)
...
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
Paweł Bara
ebfbdba8a9
further refactoring of cover changing code (saving covers in controller)
2011-01-24 17:53:31 +00:00
Arnaud Bienner
03df8195b0
Minors modification on TagFetcher. Fixes issue #1346
2011-01-24 17:03:36 +00:00
Paweł Bara
8bce92e69b
refactoring the code that handles common UI album cover related actions into a common controller
...
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00
Paweł Bara
3e2ffd3647
ability to load cover from URL in all the usual places: cover manager, now playing widget and edit tag dialog (fixes issue #517 )
2011-01-23 20:24:17 +00:00
Arnaud Bienner
c929db4637
Oops...
2011-01-20 23:55:22 +00:00