Mark Furneaux
87ca578a00
Scroll to last played track when switching playlists
...
Currently we just scroll to the last viewed index of the last playlist in the new one. This makes no sense and is frustrating when switching between long and short playlists.
This change scrolls to the last played track in each playlist on transition.
2015-05-19 22:23:03 -04:00
Mark Furneaux
361b2420f9
I just remembered we have an about box
...
Am I worthy? I know it's only been a year, but it would mean a lot to me.
I completely understand otherwise.
I also bumped the height up a tad so that no text gets cut off due to the extra line.
2015-05-18 14:13:32 -04:00
John Maguire
02069b7c60
Merge pull request #4861 from TheUbuntuGuy/master
...
Fix Last.fm scrobbling after seek
2015-05-18 18:28:34 +01:00
Mark Furneaux
fde8ae0f30
Add constants and variable units
...
Scrobble point constants are now defined as the minimum and maximum time last.fm requires for a scrobble to be valid.
2015-05-18 13:22:55 -04:00
Mark Furneaux
50ff5f5b0e
Spelling
2015-05-18 13:03:44 -04:00
Mark Furneaux
99dffe216c
Fix Last.fm scrobbling after seek
...
Fixes #4836
Last.fm defines a scrobble should be sent if:
-the track is longer than 30 seconds.
-the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)
Clementine has treated this as seconds from the start of the track, and if any seeking occurs, it nullifies the scrobble.
This IMO is incorrect. If I skip the first 10 seconds of a song, but listen to the rest (still meeting the time requirements),
I should still be able to scrobble the play. This change moves the scrobble point with every seek, requiring continuous playback
from any point that satisfies the time criteria.
2015-05-18 12:53:07 -04:00
Clementine Buildbot
1714d0be8a
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2015-05-18 10:01:18 +02:00
John Maguire
70cc291b98
Merge pull request #4845 from Chocobozzz/master
...
Fix setting album artist tag for FLAC files if it already exists
2015-05-12 14:21:30 +01:00
Clementine Buildbot
2cbd13ebba
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2015-05-11 10:01:17 +02:00
Chocobozzz
60a8ae5880
Fix setting album artist tag for FLAC files if it already exists
2015-05-09 21:13:39 +02:00
John Maguire
5256a112fc
Merge pull request #4840 from abika/chromaprinter
...
Simplification and cleanup fixes for chromaprint fingerprint creation.
2015-05-08 12:06:27 +01:00
Andreas
059aa7f832
Move watcher->deleteLater(); at the end of the BlockingSearchFinished() function to ensure the watcher object is still available when emitting the signals.
2015-05-04 16:25:49 +02:00
Alexander Bikadorov
96f4d64449
Minor coding improvements for c71aa6 .
2015-05-04 15:43:23 +02:00
Alexander Bikadorov
c71aa61f8f
Simplification and cleanup fixes for chromaprint fingerprint creation.
...
Fixes among other things the "GLib-CRITICAL **: Source ID XXX was not found" error.
2015-05-04 15:11:31 +02:00
ArnaudBienner
28fb6e5fcb
Merge pull request #4838 from joppi/master
...
Add lyrics field to device databases.
2015-05-04 13:21:54 +02:00
Clementine Buildbot
a00761fecd
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2015-05-04 10:01:18 +02:00
Andreas
488d64b702
Bump protocol buffer message version.
2015-05-03 19:19:30 +02:00
Andreas
d59e864947
Send search provider icon to the remote when sending the search results.
2015-05-03 18:30:58 +02:00
Michal Opler
2e796a36c6
Add lyrics field to device databases.
...
Connecting and scanning of a new device failed due to the missing lyrics
field. This fixes it.
2015-05-03 15:12:07 +02:00
Andreas
4c9f7e6a5e
Revert "Fix mono playback. This was broken with commit eaad4c32eeeb83302632aba887d51d2eccb55eed."
...
Spotify doesn't work with this fix anymore, gstreamer throws `gst_segment_to_stream_time: assertion 'segment->format == format' failed`. Using `audio/*` for caps doesn't work either, the channes property is ignored. An `if (url_.scheme == "spotify")` would work, but maybe there is a more elegant solution.
This reverts commit 8799222d64
2015-05-02 17:12:55 +02:00
Andreas
8799222d64
Fix mono playback. This was broken with commit eaad4c32ee.
2015-05-02 16:14:44 +02:00
John Maguire
49ad549611
crypto++ isn't required on all platforms
2015-05-01 15:38:15 +01:00
John Maguire
082a1d3e94
Nicer way to check for multiple pkgconfig names.
2015-05-01 15:36:53 +01:00
John Maguire
af6e0d2f15
Really fix crypto++ on Fedora
2015-05-01 15:34:12 +01:00
John Maguire
e1ea116bfb
Remove Grooveshark support.
...
Well that was nice while it lasted.
2015-05-01 11:57:59 +01:00
John Maguire
c0cf5e1220
Check for both names of libcrypto++
...
Fixes #4835
2015-05-01 11:52:40 +01:00
Andreas
dfbf6a954b
NSI: Delete gstreamer-1.0-0.dll instead of 0.10.
2015-05-01 12:23:23 +02:00
Andreas
d322c12387
Update windows uninstaller to remove all files correctly.
2015-04-30 10:28:27 +02:00
Andreas
7cd4a567d7
Fix two Delete statements. They didn't delete the files in the install dir.
2015-04-29 19:08:15 +02:00
Andreas
580cfa4977
Installer was always pointing to C:\Programs\Clementine when an active installation was found. This commit fixes this.
2015-04-29 19:07:29 +02:00
Andreas
150270aa54
Properly get the old install path. Fixes #4806 now.
2015-04-29 19:06:27 +02:00
Andreas
1e2fa10747
Revert "Remember last install dir on windows. Fixes #4806 "
...
This reverts commit 9deb331399
2015-04-29 19:03:37 +02:00
Andreas
d30bd3b3e4
Revert "Fix writing install dir reg key."
...
This reverts commit d2bb07ead6
2015-04-29 19:03:29 +02:00
Andreas
a32f725c5f
Register QList<int> as a media type. Under windows, the connect doesn't work without it.
2015-04-29 17:14:37 +02:00
John Maguire
c822871d21
Merge pull request #4831 from narunlifescience/master
...
White pixel around spinner GIF image
2015-04-28 13:28:43 +01:00
John Maguire
319b8a5824
Use SHA512 signatures for the spotify blob.
...
SHA512 is unsupported by reasonable QCA versions so we must use
libcrypto++ instead.
2015-04-28 12:27:07 +01:00
Arun Narayanankutty
0a02a7240f
White pixel around spinner GIF image
...
Default spinner gif image shows white pixels around the image. this is
clearly visible when using a dark theme. I included a new gif image
which fixes this.
2015-04-27 18:16:46 -05:00
John Maguire
4cbe098b83
Fix memory leak in Amazon Cloud Drive.
2015-04-27 14:02:07 +01:00
John Maguire
8d2e3373a8
Use a GTlsDatabase for gstreamer SSL on mac.
2015-04-27 11:21:22 +01:00
John Maguire
c3e88aced5
Update root certs file for mac
2015-04-27 11:21:22 +01:00
Clementine Buildbot
2da11e0d90
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2015-04-27 10:01:21 +02:00
Arnaud Bienner
44cd2f916c
Merge branch 'alphapapa-read-new-ratings-from-files'
2015-04-25 18:33:29 +02:00
Adam Porter
bb5a952e25
Re-read FMPS_Rating from file when changed
...
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database. This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine. Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
2015-04-25 18:32:34 +02:00
Arnaud Bienner
20583b8b0a
Correct typo
2015-04-25 18:01:32 +02:00
ArnaudBienner
c7416cbfb5
Merge pull request #4599 from cincodenada/spotify-improvements
...
Improve handling of Spotify Top Tracks and compilations
2015-04-25 17:59:27 +02:00
Arnaud Bienner
99521ac15f
Add missing certificate for api.soundcloud.com
...
Fixes #4794 .
2015-04-25 17:51:08 +02:00
Andreas
a0f24dff86
Network remote: Only start transcoder when we actually have something to transcode.
2015-04-24 17:43:18 +02:00
Andreas
c152bc26d9
Network remote: Don't send downloader the first data since it's not needed.
2015-04-24 17:30:21 +02:00
Andreas
136fca6dc2
Network remote: Send filesize on songoffer.
2015-04-24 17:24:14 +02:00
Andreas
d93917ce9b
Network remote: Send song url as well.
2015-04-24 15:35:18 +02:00
