Lukas Prediger
a504c1d391
RipCDDialog: References to pointers in function args.
2022-01-26 01:09:50 +00:00
Lukas Prediger
794c1b8c92
Ripper: Ensuring that GetProgress does never divide by zero
...
Also removed superfluous null check in RipCDDialog
2022-01-26 01:09:50 +00:00
Lukas Prediger
f35e1b543d
Regular progress bar updates for CD ripping.
...
Previously the progress bar of the CD ripping dialog would only update
after a track completed, now it gets updated continuously during the
ripping process.
2022-01-26 01:09:50 +00:00
Lukas Prediger
cefe81d0c1
Removing Ripper dependence on cdio
...
and therefore no longer exposing cdio through CddaDevice
2022-01-10 16:39:58 +00:00
Lukas Prediger
0895297297
CD ripping now transcodes directly from disc.
2022-01-10 16:39:58 +00:00
Lukas Prediger
bb618efc5d
Transcoder now accepts URLs for sources.
2022-01-10 16:39:58 +00:00
Lukas Prediger
fd585e8aa4
RipCDDialog: no longer forces Cdda* to emit signals
...
- CddaDevice: Removed LoadSongs() method (then renamed ForceLoadSongs to LoadSongs)
- CddaDevice: added songs() method to get currently song list
- CddaSongLoader: cached_tracks is now thread-safe
2021-09-21 10:53:43 +01:00
Lukas Prediger
62b5a0e77b
CddaDevice now does not re-read song list if disc is not changed
2021-09-21 10:53:43 +01:00
Lukas Prediger
50404a967b
RipCDDialog now only depends on CddaDevice, no longer on CddaSongLoader
2021-09-21 10:53:43 +01:00
Lukas Prediger
90ec6f6a24
CddaSongLoader now reads CD-Text for metadata
...
currently this gets overwritten by musicbrainz response almost immediately, though
2021-09-21 10:53:43 +01:00
Lukas Prediger
e556a59aea
RipCDDialog: Changing metadata edits now updates filename preview
2021-09-04 15:24:44 +01:00
Lukas Prediger
c8c110efaf
Fix: RipCDDialog now correctly loads and stores chosen transcoder preset
2021-08-31 10:19:32 +01:00
Lukas Prediger
a72e252ec6
RipCDDialog: Added file name preview
2021-08-31 10:19:32 +01:00
Lukas Prediger
b0704331d7
Integrate file name format options into RipCDDialog
...
for consistency with OrganiseDialog and reducing code duplication
2021-08-31 10:19:32 +01:00
Jonas Kvinge
f379ad84d4
Fix use of emit
...
Adds missing emits.
QTreeView::collapse and QTreeView::expand are slots, not signals. So
remove emit.
2021-07-14 10:18:47 +01:00
Lukas Prediger
57b5911f13
Fixes from code review for PR #7037
2021-06-21 12:51:44 +01:00
Lukas Prediger
a4ad507704
Removed some unused includes.
2021-06-21 12:51:44 +01:00
Lukas Prediger
d2240ec0ae
Device change watchdog timer no longer freezes main thread while CddaSongLoader is active.
2021-06-21 12:51:44 +01:00
Lukas Prediger
2dd566653f
Dealing with cdio_open failures in CddaDevice constructor
2021-06-21 12:51:44 +01:00
Lukas Prediger
ae9824e26a
RipCDDialog no longer needs to LoadSongs on show.
2021-06-21 12:51:44 +01:00
Lukas Prediger
63953e1045
RipCDDialog now allows selecting the CD drive
2021-06-21 12:51:44 +01:00
Lukas Prediger
3c06b92b24
Ripper now works with a cdio instance passed into constructor
...
which comes from a CddaDevice corresponding to the device
2021-06-21 12:51:44 +01:00
Lukas Prediger
ae3037984c
RipCDDialog now uses CddaSongLoader from passed in CddaDevice
2021-06-21 12:51:44 +01:00
Lukas Prediger
9ca75ae357
RipCDDialog now relies on CddaDevice to be notified about disc changes
2021-06-21 12:51:44 +01:00
Lukas Prediger
86bbd2ace6
Formatting/linting fixes.
2021-05-18 12:12:01 +01:00
Lukas Prediger
54a497b302
RipCDDialog rejects metadata lists if number of tracks does not match disc.
...
First step for addressing #7020 .
2021-05-18 12:12:01 +01:00
Lukas Prediger
75de59703c
Fix: Transcoding for CD rips not starting.
...
due to making Transcoder::Start a non-slot in 8d11e9ff
2021-05-15 10:14:18 +01:00
Jim Broadus
281da05325
transcoder: Provide user feedback in options error condition
...
Remove condition that allows no dialog to be displayed when user selects
options for transcoding. Display the dialog with an error message
instead. This also applies to the transcode options dialog in the
ripping and network remote settings.
2021-02-02 09:58:20 +00:00
Jim Broadus
b735f5d1c3
transcoder: Change TranscoderOptionsDialog constructor
...
Take a reference to a TranscoderPreset object instead of the the type.
This will allow the dialog to provide better information and correct
options.
2021-02-02 09:58:20 +00:00
John Maguire
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
Jonas Kvinge
1a2274bd2b
Merge branch 'master' into qt5-update
2019-07-21 14:20:59 +02:00
Filip Gawin
be827f4f7f
Simplify some statements
2019-02-22 18:49:48 +01:00
Jonas Kvinge
d4fab4a2ea
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-11 22:46:07 +01:00
Amish Naidu
107e945872
Convert uses of QtAlgorithms to std:: algorithms
2018-10-09 19:17:54 +01:00
Jonas Kvinge
c29c2e95cc
Fixed merge conflicts
2018-09-30 15:11:06 +02:00
Mattias Andersson
e9a4db0192
Prevent closing of the RipCDDialog if the ripper is running
...
This prevents a segfault when a running dialog is closed and later reopened.
2018-07-07 10:23:49 +01:00
Mattias Andersson
10d4c502fd
Set the parent to avoid a memory leak
2018-07-06 17:09:21 +01:00
Mattias Andersson
3e53e23bb8
Fix formatting
2018-07-06 17:09:21 +01:00
Mattias Andersson
2c084e45b6
Finnish immideately if there are no tracks to rip
2018-07-06 17:09:21 +01:00
Mattias Andersson
059b5ed04f
Add Musicbrainz integration to the cd ripper
2018-07-06 17:09:21 +01:00
Chocobozzz
ff7026c9fe
Merge remote-tracking branch 'upstream/master' into qt5
2015-12-13 20:05:12 +01:00
narunlifescience
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
Mattias Andersson
41d7d792ae
Show track durations in the CD ripper dialog.
...
The duration in seconds is computed using integer division which should be close enough.
2015-10-11 12:18:15 +02:00
Chocobozzz
631a6cdabd
Merge branch 'master' into qt5
2015-09-16 17:40:54 +02:00
Mattias Andersson
aad6401cec
Use consistent string replacment scheme
...
Make the CD ripper dialog use the same naming scheme for replacement
strings as the organise dialog.
2015-06-16 16:47:20 +02:00
Chocobozzz
e986ab5a4b
Merge master branch and adapt it to qt5
2015-04-16 17:16:34 +02:00
Mattias Andersson
8ad0e93381
Construct file paths correctly on all platforms
2015-02-20 19:19:45 +01:00
Mattias Andersson
666faa5b37
Simplify some things. Use iterators instead of non-const references in
...
two loops.
2015-02-19 13:31:53 +01:00
Mattias Andersson
f7185101ce
Update the target file name after transcoding
...
After a transcoding job is complete, we need to update the corresponding
filename since the transcoder, rather than overwriting an existing file,
changes the filename of the output file. This ensures that the right
file is tagged later on.
2015-02-19 11:07:06 +01:00
Mattias Andersson
7d0d7be568
Some ui changes to the ripcd dialog.
...
- Move the Rip audio CD menu item to the Tools menu.
- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
2015-02-18 20:08:02 +01:00