Jonas Kvinge
8c198a99a5
Qt 5 fixes
2018-11-21 10:31:17 +00:00
Antonio Russo
6a312e7459
Limit both QSettings reads and writes ( #6057 )
...
Any access, read or write, via QSettings requires locking
`Clementine.conf`. On some devices, this can be slow. Moreover, it also
increases power use and wear on devices such as SSDs.
To improve the situation, defer QSettings updates until program close
for window resize, current playlist tab, and playlist geometry, i.e.
`PlaylistView::SaveGeometry`.
Also, limit `PlaylistView::LoadGeometry` to once per program run.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2018-05-22 11:18:54 +01:00
Chocobozzz
16b4f9a991
Merge remote-tracking branch 'upstream/master' into qt5
2018-05-14 08:25:27 +02:00
Jonas Kvinge
c393926be6
Fix background not loading.
2018-03-12 07:55:59 -04:00
Chocobozzz
fc517ce7a5
Merge remote-tracking branch 'upstream/master' into qt5
2017-06-05 21:28:05 +02:00
Grace Dolphy
52f1982353
Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack ( #5702 )
...
* Fix delete functionality. Skips to next song if deleted song is also currently playing.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Update mainwindow.cpp
* Formatting Changes
* Update playlist.cpp
Simplified condition statement.
* Added in a missed boolean for RemoveSelected
* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Chocobozzz
ff7026c9fe
Merge remote-tracking branch 'upstream/master' into qt5
2015-12-13 20:05:12 +01:00
narunlifescience
b9eca5e323
Lock/Unlock Ratings edit status
2015-10-24 23:05:23 -05:00
John Maguire
fad1767f6c
Revert "Lock/Unlock Ratings edit status"
2015-10-20 18:39:42 +01:00
narunlifescience
bcceae175d
Lock/Unlock Ratings edit status
...
add comment
organize
unclutter
patch to work with other languages
Update playlistheader.cpp
2015-10-18 23:06:35 -05:00
Chocobozzz
631a6cdabd
Merge branch 'master' into qt5
2015-09-16 17:40:54 +02:00
Eduardo Sánchez Muñoz
11b61c2a67
Use Player::SeekForward() and Player::SeekBackward() to handle seeking with arrow keys.
2015-07-02 14:59:30 +02:00
Chocobozzz
8b226c2171
Update non optionnals sources to qt5
2015-04-11 23:24:07 +02:00
Helder Martins
cbfd3218f2
Cleaning unnecessary code
2014-07-23 23:47:12 +01:00
Helder Martins
0c2d4e9f1c
Fixed a minor issue where the playlist wasnt updating the queue order, when a track was dequeued using the ctrl-d shortcut
2014-07-23 00:15:06 +01:00
John Maguire
192b60d965
Use nullptr as parent parameter default everywhere
2014-02-10 16:03:54 +01:00
John Maguire
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
David Sansome
d3749eace9
Select the current item if the selection is empty when using Tab to move from
...
the playlist filter to the playlist view. Fixes #4116
2014-01-14 20:07:03 +11:00
David Sansome
122d5ad139
Clean up the appearance settings page and add sensible defaults
2013-02-17 14:03:39 +11:00
David Sansome
c03f69daa7
Restore the blur amount setting when the settings dialog is loaded. Also remove some unusued variables. Fixes issue 3497
2013-02-17 13:55:54 +11:00
Mateusz Kowalczyk
f40b8ab892
Add adjustable transparency to album art background.
...
Fixes issue #3431
2013-02-15 14:39:14 +01:00
David Sansome
577d131c6a
Use qt_blurImage instead of the handwritten function
2012-11-10 18:04:55 +11:00
Arnaud Bienner
65f1dca716
Minor style changes
2012-11-09 20:30:32 +01:00
Mateusz Kowalczyk
c4796564ea
Add an option to blur background image.
...
Fixes issue 3266.
2012-11-09 20:17:26 +01:00
Arnaud Bienner
ab0a050855
Add a fading animation when background image change
2012-03-16 22:39:39 +01:00
Arnaud Bienner
4e54634504
Reset current_covert_art when player is stopped
2012-03-13 23:15:53 +01:00
Arnaud Bienner
b676676b9a
Precompute the (CPU expensive) opacity filter in a new set_background_image function.
...
Also, convert the image and modify only alpha channel
2012-03-10 18:55:22 +01:00
Arnaud Bienner
0b9d7f2a1a
Move all the logic about background precomputation in a new method, to make paintEvent cleaner
2012-03-08 22:39:27 +01:00
John Maguire
8e6dd551ef
Fix background image rendering on Mac by pre-computing the opacity change.
...
Fixes issue #2745
2012-03-06 13:40:19 +01:00
Arnaud Bienner
3b19d730b6
Add the ability to have the current playing song cover as playlist's background.
...
I think it can be nice. But some users' feedback about this might be nice...
Also, few things may be improved (like adding fading when cover changes)
2012-03-03 01:20:37 +01:00
Arnaud Bienner
906d6f5995
Force background redraw when changing background preferences.
2012-02-19 22:40:58 +01:00
Arnaud Bienner
2f710a9395
Add the ability to modify the playlistview's background image.
...
Updates issue 365
It is now possible to also modify background image, instead of just hide the default one
2012-02-18 19:57:36 +01:00
David Sansome
7166f0d922
When pressing Ctrl+C on a playlist item, copy the text of all visible columns, rather than just the text of the "current" one. Fixes issue 2558
2012-01-29 19:24:13 +00:00
David Sansome
bfd725f2ed
Don't crash when adding new columns to a stretch header view.
...
Fixes issue 2562
2012-01-04 18:45:08 +00:00
John Maguire
bcf9475f2b
Add a source column to the playlist view with appropriate icons.
2012-01-04 11:56:09 +00:00
David Sansome
efce2498ca
Indicate which column alignment action is currently set on each column in the menu.
2011-11-12 16:23:41 +00:00
David Sansome
63fdf11cd8
Keep the playlist column alignment setting in PlaylistView instead of in each individual Playlist, ensuring all playlists share the same column alignments and there's only one place to save/restore them.
...
Fixes issue 1795
2011-11-12 16:12:51 +00:00
David Sansome
d62d11df8d
When songs are added to the end of the playlist, scroll the playlist to ensure the top one is visible.
2011-09-27 22:28:12 +01:00
David Sansome
8f3ea57a64
Fix the background colour of items in the global search popup in Qt 4.7 with the GTK style.
2011-09-19 11:06:25 +01:00
David Sansome
30f68d6981
Store the floating point proportional playlist column widths directly instead of storing the integer pixel widths then recalculating the floating point values on startup, which would lead to floating point errors over time. Fixes a bug where columns would slowly change size the more times you opened and closed clementine.
2011-07-24 12:47:48 +01:00
Tyler Rhodes
827d37e64b
Add 'Enable playlist background image' to preferences.
...
Fixes issue #365
2011-06-08 14:48:43 +00:00
Paweł Bara
823f798451
new option for greying out deleted songs on startup
2011-03-19 09:41:00 +00:00
Arnaud Bienner
57ac8c441a
Play/Pause when pressing space (on playlistview). Fixes issue 244
2011-02-23 23:59:12 +00:00
Arnaud Bienner
9c0094b9a6
Improve playlist view: focus on playlistview or search filter, depending on keyboard event. Fixes issue 606
2011-02-23 22:21:17 +00:00
Arnaud Bienner
79159700fc
Center on last played song when restoring playlist. Fixes issue 410.
2011-02-10 20:55:19 +00:00
Arnaud Bienner
05a4cae370
Add track seeking from playlistview
2011-01-26 23:20:56 +00:00
David Sansome
95ef57cf1e
Add column text alignment options to the playlist header menu. Thanks brunciter!
2010-12-22 10:45:14 +00:00
Paweł Bara
32f9825794
global shortcuts for rating songs (Fixes issue #1089 )
...
renaming *index* methods in Playlist to *row*
2010-12-17 00:21:20 +00:00
David Sansome
2dce2e44fd
Fix a regression where dragging songs into the playlist while a song was selected would abort the drop and start a new drag from the selected item.
2010-12-06 22:18:00 +00:00