Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Update modified fields boldness when fetching tags

This commit is contained in:
Alexander Bikadorov 2016-01-04 18:56:28 +01:00
parent bad9e4af5e
commit ff86ecddc5
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/ui/edittagdialog.cpp
View File

@ -365,7 +365,6 @@ bool EditTagDialog::IsValueModified(const QModelIndexList& sel,
void EditTagDialog::InitFieldValue(const FieldData& field, void EditTagDialog::InitFieldValue(const FieldData& field,
const QModelIndexList& sel) { const QModelIndexList& sel) {
const bool varies = DoesValueVary(sel, field.id_); const bool varies = DoesValueVary(sel, field.id_);
const bool modified = IsValueModified(sel, field.id_);
if (ExtendedEditor* editor = dynamic_cast<ExtendedEditor*>(field.editor_)) { if (ExtendedEditor* editor = dynamic_cast<ExtendedEditor*>(field.editor_)) {
editor->clear(); editor->clear();
@ -377,10 +376,7 @@ void EditTagDialog::InitFieldValue(const FieldData& field,
} }
} }
QFont new_font(font()); UpdateModifiedField(field, sel);
new_font.setBold(modified);
field.label_->setFont(new_font);
field.editor_->setFont(new_font);
} }
void EditTagDialog::UpdateFieldValue(const FieldData& field, void EditTagDialog::UpdateFieldValue(const FieldData& field,
@ -401,9 +397,13 @@ void EditTagDialog::UpdateFieldValue(const FieldData& field,
data_[i.row()].set_value(field.id_, value); data_[i.row()].set_value(field.id_, value);
} }
// Update the boldness UpdateModifiedField(field, sel);
}
void EditTagDialog::UpdateModifiedField(const FieldData& field, const QModelIndexList& sel) {
const bool modified = IsValueModified(sel, field.id_); const bool modified = IsValueModified(sel, field.id_);
// Update the boldness
QFont new_font(font()); QFont new_font(font());
new_font.setBold(modified); new_font.setBold(modified);
field.label_->setFont(new_font); field.label_->setFont(new_font);
@ -855,12 +855,12 @@ void EditTagDialog::FetchTagSongChosen(const Song& original_song,
// Is it currently being displayed in the UI? // Is it currently being displayed in the UI?
if (ui_->song_list->currentRow() == id) { if (ui_->song_list->currentRow() == id) {
// Yes! Additionally update UI // Yes! Additionally update UI
const QModelIndexList sel =
ui_->song_list->selectionModel()->selectedIndexes();
ignore_edits_ = true; ignore_edits_ = true;
ui_->title->set_text(new_metadata.title()); for (const FieldData& field : fields_) {
ui_->artist->set_text(new_metadata.artist()); InitFieldValue(field, sel);
ui_->album->set_text(new_metadata.album()); }
ui_->track->setValue(new_metadata.track());
ui_->year->setValue(new_metadata.year());
ignore_edits_ = false; ignore_edits_ = false;
} }
} }

1
src/ui/edittagdialog.h
View File

@ -127,6 +127,7 @@ signals:
void InitFieldValue(const FieldData& field, const QModelIndexList& sel); void InitFieldValue(const FieldData& field, const QModelIndexList& sel);
void UpdateFieldValue(const FieldData& field, const QModelIndexList& sel); void UpdateFieldValue(const FieldData& field, const QModelIndexList& sel);
void UpdateModifiedField(const FieldData& field, const QModelIndexList& sel);
void ResetFieldValue(const FieldData& field, const QModelIndexList& sel); void ResetFieldValue(const FieldData& field, const QModelIndexList& sel);
void UpdateSummaryTab(const Song& song); void UpdateSummaryTab(const Song& song);