diff --git a/src/ui/albumcovermanager.cpp b/src/ui/albumcovermanager.cpp index 96382b61d..f73cebbcd 100644 --- a/src/ui/albumcovermanager.cpp +++ b/src/ui/albumcovermanager.cpp @@ -384,7 +384,7 @@ void AlbumCoverManager::UpdateFilter() { if (!should_hide) { total_count++; - if (!ItemHasCover(item)) { + if (!ItemHasCover(*item)) { without_cover++; } } @@ -397,7 +397,7 @@ void AlbumCoverManager::UpdateFilter() { bool AlbumCoverManager::ShouldHide(const QListWidgetItem& item, const QString& filter, HideCovers hide) const { - bool has_cover = ItemHasCover(&item); + bool has_cover = ItemHasCover(item); if (hide == Hide_WithCovers && has_cover) { return true; } else if (hide == Hide_WithoutCovers && !has_cover) { @@ -427,7 +427,7 @@ void AlbumCoverManager::FetchAlbumCovers() { for (int i = 0; i < ui_->albums->count(); ++i) { QListWidgetItem* item = ui_->albums->item(i); if (item->isHidden()) continue; - if (ItemHasCover(item)) continue; + if (ItemHasCover(*item)) continue; quint64 id = cover_fetcher_->FetchAlbumCover( EffectiveAlbumArtistName(item), item->data(Role_AlbumName).toString()); @@ -498,7 +498,7 @@ bool AlbumCoverManager::eventFilter(QObject* obj, QEvent* event) { bool some_with_covers = false; for (QListWidgetItem* item : context_menu_items_) { - if (ItemHasCover(item)) some_with_covers = true; + if (ItemHasCover(*item)) some_with_covers = true; } album_cover_choice_controller_->cover_from_file_action()->setEnabled( @@ -781,7 +781,7 @@ void AlbumCoverManager::ExportCovers() { QListWidgetItem* item = ui_->albums->item(i); // skip hidden and coverless albums - if (item->isHidden() || !ItemHasCover(item)) { + if (item->isHidden() || !ItemHasCover(*item)) { continue; } @@ -853,6 +853,6 @@ QImage AlbumCoverManager::GenerateNoCoverImage( return square_nocover; } -bool AlbumCoverManager::ItemHasCover(const QListWidgetItem* item) const { - return item->icon().cacheKey() != no_cover_item_icon_.cacheKey(); +bool AlbumCoverManager::ItemHasCover(const QListWidgetItem& item) const { + return item.icon().cacheKey() != no_cover_item_icon_.cacheKey(); } diff --git a/src/ui/albumcovermanager.h b/src/ui/albumcovermanager.h index d9de938fd..7ecfe3d78 100644 --- a/src/ui/albumcovermanager.h +++ b/src/ui/albumcovermanager.h @@ -170,7 +170,7 @@ signals: AlbumCoverExporter* cover_exporter_; QImage GenerateNoCoverImage(const QIcon& no_cover_icon) const; - bool ItemHasCover(const QListWidgetItem* item) const; + bool ItemHasCover(const QListWidgetItem& item) const; QIcon artist_icon_; QIcon all_artists_icon_;