From dd1393ea3ab5ae58aff8f8cc444aee3c8e4830fb Mon Sep 17 00:00:00 2001 From: Lukas Prediger Date: Sat, 20 Nov 2021 13:14:49 +0200 Subject: [PATCH] Transcodedialog: moving things into more specific scope --- src/transcoder/transcodedialog.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/transcoder/transcodedialog.cpp b/src/transcoder/transcodedialog.cpp index e19d3643c..dcb93c179 100644 --- a/src/transcoder/transcodedialog.cpp +++ b/src/transcoder/transcodedialog.cpp @@ -212,13 +212,14 @@ void TranscodeDialog::JobComplete(const QUrl& input, const QString& output, UpdateProgress(); bool overwrite_existing = ui_->remove_original->isChecked(); - QFileInfo input_fileinfo(input); - QFileInfo output_fileinfo(output); - bool same_extension = input_fileinfo.suffix() == output_fileinfo.suffix(); - bool same_path = - input_fileinfo.absolutePath() == output_fileinfo.absolutePath(); if (success && overwrite_existing) { + QFileInfo input_fileinfo(input); + QFileInfo output_fileinfo(output); + bool same_extension = input_fileinfo.suffix() == output_fileinfo.suffix(); + bool same_path = + input_fileinfo.absolutePath() == output_fileinfo.absolutePath(); + QFile(input).remove(); if (same_path && same_extension) { QFile(output).rename(input);